From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA94DA0540; Wed, 21 Sep 2022 13:37:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1B254067C; Wed, 21 Sep 2022 13:37:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D87D440F17 for ; Wed, 21 Sep 2022 13:37:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663760241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RO7JkBZrAslilyODqwdW0xBd8/twDBQAc1Poj/X9xqA=; b=KlWFMQ6GUvavnnFMl13x6mywM6G60OdFAgT38NFMC2XfwaZN3C6zw46hMQZWTAadztZkpp GPWczLsMTLPfr7JYGProOnPnVbpuB4dqoPAUatt2bIy6DGZwxoJFvWjSTFnofILHfurRPM KsVXJUI8m1aGYvJp8fZXje8HN6XY+l0= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-635-OoITV1rIOSuXGCY7YvBEnQ-1; Wed, 21 Sep 2022 07:37:20 -0400 X-MC-Unique: OoITV1rIOSuXGCY7YvBEnQ-1 Received: by mail-lf1-f70.google.com with SMTP id bp4-20020a056512158400b0049f93244164so1956012lfb.13 for ; Wed, 21 Sep 2022 04:37:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=RO7JkBZrAslilyODqwdW0xBd8/twDBQAc1Poj/X9xqA=; b=f/h+RjTpDlIJBb7mSdGLTpEKuUvHTQBGW7ORRYPqDtglh+xz3MDvEAj/V7o6O5POF+ 7DoJE2IK40UWx97EURYLrCUHsIGUZsrP25P4jsI59bJUdNtoN2m5g4niQTuDH7HxTdNo MjVG1OK/HfbZmvYUP4s7bqpimkXaO4HC6HjC/9QHtBycgwmTW9K4Uci7Vc8ypWoPbloh igrWGngHxTw4Dl73IgJFDHPV5kQMoqhh9dxkjWPxfPxQ4/xZ9V3CRqz2IMzS0QG+fBeN shVvBDjFnfXNXmBsrHXwkPjVbMo3A6fwW0aqEzWgLwdop8epjV66ip8RCfZUhLogurF4 oDxg== X-Gm-Message-State: ACrzQf0c6W8haI4JO5Mf8kPm1kE8loZjD0kZBmpfcLtKtJeQa5qY7pxb /7tzyECwUaxOqngUp9s8RJV7sM3vegQhmkEj5uQ7W7IBz5YipWUQpErtZ1OKykRtecR7h8VzjWP bz60lfHiIO7oGoTEGJSs= X-Received: by 2002:a2e:8541:0:b0:261:b44b:1a8b with SMTP id u1-20020a2e8541000000b00261b44b1a8bmr9215687ljj.46.1663760237196; Wed, 21 Sep 2022 04:37:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5/MrTUwvbim+K18s3ZpdB+/9c1aXztj3ppZiGLpMXFJLTZ4JX/UFGB3iAe1qyY+Unj5YbiJVvO70ZMIWZ5mU4= X-Received: by 2002:a2e:8541:0:b0:261:b44b:1a8b with SMTP id u1-20020a2e8541000000b00261b44b1a8bmr9215676ljj.46.1663760236843; Wed, 21 Sep 2022 04:37:16 -0700 (PDT) MIME-Version: 1.0 References: <20220825223355.410540-1-dmitry.kozliuk@gmail.com> <20220827113222.3951505-1-dmitry.kozliuk@gmail.com> <20220827113222.3951505-5-dmitry.kozliuk@gmail.com> In-Reply-To: <20220827113222.3951505-5-dmitry.kozliuk@gmail.com> From: David Marchand Date: Wed, 21 Sep 2022 13:37:05 +0200 Message-ID: Subject: Re: [PATCH v4 4/4] eal: remove unneeded includes from a public header To: Dmitry Kozlyuk Cc: dev@dpdk.org, ci@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Aug 27, 2022 at 1:33 PM Dmitry Kozlyuk w= rote: > > Do not include , , and from , > because they are not used by this file. > Include the needed headers directly from the files that need them. > > Signed-off-by: Dmitry Kozlyuk > --- [snip] > examples/vdpa/main.c | 1 + > examples/vhost/main.c | 2 ++ > examples/vhost/virtio_net.c | 1 + > examples/vhost_blk/vhost_blk.c | 1 + We are missing an update of vm_power_manager example: ../../../dpdk/examples/vm_power_manager/parse.c: In function =E2=80=98parse= _set=E2=80=99: ../../../dpdk/examples/vm_power_manager/parse.c:28:16: error: implicit declaration of function =E2=80=98isblank=E2=80=99 [-Werror=3Dimplicit-function-declaration] 28 | while (isblank(*str)) | ^~~~~~~ ../../../dpdk/examples/vm_power_manager/parse.c:9:1: note: include =E2=80=98=E2=80=99 or provide a declaration of =E2=80=98isblank=E2= =80=99 8 | #include "parse.h" +++ |+#include 9 | I am surprised the CI did not catch this issue. I suspect some dependencies (probably libvirt-devel) are not installed in CI environments. The following diff seems enough to fix the issue, can you double check? diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c index 97b8def7ca..5fef268662 100644 --- a/examples/vm_power_manager/channel_monitor.c +++ b/examples/vm_power_manager/channel_monitor.c @@ -2,6 +2,7 @@ * Copyright(c) 2010-2014 Intel Corporation */ +#include #include #include #include diff --git a/examples/vm_power_manager/guest_cli/parse.c b/examples/vm_power_manager/guest_cli/parse.c index 528df6d6f1..6ed2d5cb49 100644 --- a/examples/vm_power_manager/guest_cli/parse.c +++ b/examples/vm_power_manager/guest_cli/parse.c @@ -3,9 +3,13 @@ * Copyright(c) 2014 6WIND S.A. */ +#include +#include #include #include + #include + #include "parse.h" /* diff --git a/examples/vm_power_manager/parse.c b/examples/vm_power_manager/parse.c index 8a8dcf05fe..5467035994 100644 --- a/examples/vm_power_manager/parse.c +++ b/examples/vm_power_manager/parse.c @@ -3,8 +3,13 @@ * Copyright(c) 2014 6WIND S.A. */ +#include +#include +#include #include + #include + #include "parse.h" /* --=20 David Marchand