From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2C98A0543; Mon, 13 Jun 2022 16:20:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9841D40222; Mon, 13 Jun 2022 16:20:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 724A040150 for ; Mon, 13 Jun 2022 16:20:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655130019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i3JtCIy/c7VZetIgUvBZ6Ek+vX8pYVMmXJuXBbEajRQ=; b=JimmVvph75GqzFu23xAIAN8BXGId6a5zf8KVPx6qu+TlR/jEgkM3+7xEPYMmyqEmaJDofW SuaF4C8hmQR2r3u+xUa/WeVPUsLEJHZMaLm10EBPvFUqDQHY68HuFr23DM/Zay+RSWxVYE bprPESroeQEYAl5LqXtlVS8tGBWdhL4= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-371-k8jsvNvqNSmPqfEhcSkLkg-1; Mon, 13 Jun 2022 10:20:17 -0400 X-MC-Unique: k8jsvNvqNSmPqfEhcSkLkg-1 Received: by mail-lf1-f71.google.com with SMTP id g40-20020a0565123ba800b004791450e602so3110199lfv.17 for ; Mon, 13 Jun 2022 07:20:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i3JtCIy/c7VZetIgUvBZ6Ek+vX8pYVMmXJuXBbEajRQ=; b=LYDMGb7/wWYip7AcBeP33QnOJK1lVdfwEen6Z19jSaeB+OEKouzL6RUDLk67Y2KU5P kET4Se7tHazWeuyBdIDK21PocHyU2JnAnzBYFiFPdoP7V6zyLDq6htyRsdtJ4TeGzmj7 T+d76ocwNQ+KYPc5lHkygKGIKA9piTPS+zvWvY85HCpGJUpW2oY4MrbpBfEGttEbxH0U fibz8W7UvvZKQ2ej2BL5sAJv7R6BX3bmK0I2iRqsB8FZomEXBCEMnXlaFJkURhqLjewL EYigmHivht6A7xXeLUE1L4bA038ebq5ZvvOcrubBnbbvubBmtvmHhlVCac0ZIu3qTk7k SvWQ== X-Gm-Message-State: AJIora+PWt6nDHkj2SwnUOGKVx4WX6As3UWhtuARTzKtswAtF1t0+Jyi 7jDOijm4UspOBtDtp+DfqczIos6WzcIgaMmn78khpPvDzuTRZiODY0VG204SuMMxOx+gpzlPNhA RAW0Z9d2P5e4dKx2o/Hw= X-Received: by 2002:a05:6512:b8b:b0:479:3e3b:9699 with SMTP id b11-20020a0565120b8b00b004793e3b9699mr64212lfv.217.1655130015809; Mon, 13 Jun 2022 07:20:15 -0700 (PDT) X-Google-Smtp-Source: AGRyM1th+MHzbEyURFaPTltUDzlztBvFHDf03cCSi1uryXOCPhTuyUxle8Y1nbX5gqDRSK2DCt2Y3AtfjioltXn51d4= X-Received: by 2002:a05:6512:b8b:b0:479:3e3b:9699 with SMTP id b11-20020a0565120b8b00b004793e3b9699mr64201lfv.217.1655130015611; Mon, 13 Jun 2022 07:20:15 -0700 (PDT) MIME-Version: 1.0 References: <20211216111430.699717-1-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Mon, 13 Jun 2022 16:20:04 +0200 Message-ID: Subject: Re: [PATCH] config: remove explicit undef of unset values To: Bruce Richardson Cc: dev , "Dong, JunX" , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 13, 2022 at 2:37 PM Bruce Richardson wrote: > > I'd like a check like (below), to avoid new additions: > > > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > > index 34a2e43845..8dae47165e 100755 > > --- a/devtools/checkpatches.sh > > +++ b/devtools/checkpatches.sh > > @@ -158,6 +158,14 @@ check_forbidden_additions() { # > > -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > > "$1" || res=1 > > > > + # '// XXX is not set' must be preferred over '#undef XXX' > > + awk -v FOLDERS='config/rte_config.h' \ > > + -v EXPRESSIONS='#undef' \ > > + -v RET_ON_FAIL=1 \ > > + -v MESSAGE='Using "#undef XXX", prefer "// XXX is not set"' \ > > + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > > + "$1" || res=1 > > + > > return $res > > } > > > > Otherwise, the change lgtm. > > > Good idea. Do you want me to add your check above as a patch to this to > make a two-patch set for v2? If you are fine with the check, I don't mind it is part of this simple patch. I can do it when applying if you are okay with it. -- David Marchand