From: David Marchand <david.marchand@redhat.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal/freebsd: add support for base virtaddr option
Date: Fri, 25 Oct 2019 11:36:32 +0200 [thread overview]
Message-ID: <CAJFAV8zYgEA2m7jV+f=G5gpEaUxwNicHXO8+LWrkLggVRHsi4g@mail.gmail.com> (raw)
In-Reply-To: <dd2a2eae-50df-217f-6ea3-6ec0b923483f@intel.com>
On Fri, Oct 25, 2019 at 11:06 AM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
>
> On 24-Oct-19 7:56 PM, David Marchand wrote:
> > On Thu, Oct 24, 2019 at 5:18 PM Anatoly Burakov
> > <anatoly.burakov@intel.com> wrote:
> >>
> >> According to our docs, only Linuxapp supports base-virtaddr option.
> >> That is, strictly speaking, not true because most of the things
> >> that are attempting to respect base-virtaddr are in common files,
> >> so FreeBSD already *mostly* supports this option in practice.
> >>
> >> This commit fixes the remaining bits to explicitly support
> >> base-virtaddr option, and moves the arg parsing from EAL to common
> >> options parsing code. Documentation is also updated to reflect
> >> that all platforms now support base-virtaddr.
> >>
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >> Reviewed-by: David Marchand <david.marchand@redhat.com>
> >> ---
> >>
> >> Notes:
> >> v2:
> >> - Harmonize FreeBSD reattach implementation with Linux
> >>
> >> doc/guides/linux_gsg/eal_args.include.rst | 6 +++
> >> doc/guides/linux_gsg/linux_eal_parameters.rst | 6 ---
> >> doc/guides/rel_notes/release_19_11.rst | 5 +++
> >> lib/librte_eal/common/eal_common_options.c | 38 ++++++++++++++++++
> >
> > I was about to apply it, and I realised that the usage() in Linux
> > still references the --base-virtaddr option but it was not moved to
> > the common code.
> > What do you think of this hunk?
> >
> > diff --git a/lib/librte_eal/common/eal_common_options.c
> > b/lib/librte_eal/common/eal_common_options.c
> > index 1cdbd35..020f36e 100644
> > --- a/lib/librte_eal/common/eal_common_options.c
> > +++ b/lib/librte_eal/common/eal_common_options.c
> > @@ -1692,6 +1692,7 @@ static int xdigit2val(unsigned char c)
> > " --"OPT_NO_PCI" Disable PCI\n"
> > " --"OPT_NO_HPET" Disable HPET\n"
> > " --"OPT_NO_SHCONF" No shared config (mmap'd files)\n"
> > + " --"OPT_BASE_VIRTADDR" Base virtual address\n"
> > "\n", RTE_MAX_LCORE);
> > rte_option_usage();
> > }
> > diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
> > index ef5dafa..c0aac21 100644
> > --- a/lib/librte_eal/linux/eal/eal.c
> > +++ b/lib/librte_eal/linux/eal/eal.c
> > @@ -539,7 +539,6 @@ enum rte_proc_type_t
> > " --"OPT_SOCKET_LIMIT" Limit memory allocation on
> > sockets (comma separated values)\n"
> > " --"OPT_HUGE_DIR" Directory where hugetlbfs
> > is mounted\n"
> > " --"OPT_FILE_PREFIX" Prefix for hugepage filenames\n"
> > - " --"OPT_BASE_VIRTADDR" Base virtual address\n"
> > " --"OPT_CREATE_UIO_DEV" Create /dev/uioX (usually
> > done by hotplug)\n"
> > " --"OPT_VFIO_INTR" Interrupt mode for VFIO
> > (legacy|msi|msix)\n"
> > " --"OPT_LEGACY_MEM" Legacy memory mode (no
> > dynamic allocation, contiguous segments)\n"
> >
> >
>
> Should be OK, i think. The whitespace seems to be slightly off, but
> otherwise, looks good.
I suppose you mean the inline patch was whitespace damaged :-).
I moved this option a bit earlier in the list.
Please check and send a fix if you think it is wrong.
Applied, thanks.
--
David Marchand
next prev parent reply other threads:[~2019-10-25 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 11:25 [dpdk-dev] [PATCH] " Anatoly Burakov
2019-07-22 16:07 ` Thomas Monjalon
2019-08-12 10:19 ` David Marchand
2019-08-12 13:38 ` Burakov, Anatoly
2019-09-26 13:55 ` David Marchand
2019-10-24 15:17 ` [dpdk-dev] [PATCH v2 1/2] " Anatoly Burakov
2019-10-24 18:56 ` David Marchand
2019-10-25 9:05 ` Burakov, Anatoly
2019-10-25 9:36 ` David Marchand [this message]
2019-10-24 15:17 ` [dpdk-dev] [PATCH v2 2/2] eal: use define instead of raw flag name Anatoly Burakov
2019-10-24 18:59 ` David Marchand
2019-10-25 9:36 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zYgEA2m7jV+f=G5gpEaUxwNicHXO8+LWrkLggVRHsi4g@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).