DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Leyi Rong <leyi.rong@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
	 "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev <dev@dpdk.org>,
	 Bruce Richardson <bruce.richardson@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v4 1/3] net/ice: add AVX512 vector path
Date: Sun, 25 Oct 2020 17:23:53 +0100
Message-ID: <CAJFAV8zZ6StMasJBWJN-i4bnVo9kVDruki6LVxd_kHApw8twGQ@mail.gmail.com> (raw)
In-Reply-To: <20201023041407.20442-2-leyi.rong@intel.com>

Hello Leyi, Qi, Ferruh,

On Fri, Oct 23, 2020 at 6:37 AM Leyi Rong <leyi.rong@intel.com> wrote:
> diff --git a/drivers/net/ice/meson.build b/drivers/net/ice/meson.build
> index 254595af85..85e8baf912 100644
> --- a/drivers/net/ice/meson.build
> +++ b/drivers/net/ice/meson.build
> @@ -34,6 +34,17 @@ if arch_subdir == 'x86'
>                                 c_args: [cflags, '-mavx2'])
>                 objs += ice_avx2_lib.extract_objects('ice_rxtx_vec_avx2.c')
>         endif
> +
> +       if dpdk_conf.has('RTE_MACHINE_CPUFLAG_AVX512F') or (not machine_args.contains('-mno-avx512f') and cc.has_argument('-mavx512f'))
> +               cflags += ['-DCC_AVX512_SUPPORT']
> +               ice_avx512_lib = static_library('ice_avx512_lib',
> +                                     'ice_rxtx_vec_avx512.c',
> +                                     dependencies: [static_rte_ethdev,
> +                                       static_rte_kvargs, static_rte_hash],
> +                                     include_directories: includes,
> +                                     c_args: [cflags, '-march=skylake-avx512', '-mavx512f'])
> +               objs += ice_avx512_lib.extract_objects('ice_rxtx_vec_avx512.c')
> +       endif
>  endif
>
>  sources += files('ice_dcf.c',
> --
> 2.17.1
>

RTE_MACHINE_CPUFLAG_AVX512F can be removed.
Worth fixing before hitting the main tree.

Thanks.

-- 
David Marchand


  reply	other threads:[~2020-10-25 16:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  6:55 [dpdk-dev] [PATCH v1 0/2] AVX512 vPMD on ice Leyi Rong
2020-09-10  6:55 ` [dpdk-dev] [PATCH v1 1/2] net/ice: add AVX512 vector path Leyi Rong
2020-09-10  9:32   ` Bruce Richardson
2020-09-10  6:55 ` [dpdk-dev] [PATCH v1 2/2] net/ice: optimize Tx path on AVX512 vPMD Leyi Rong
2020-09-15  1:17   ` Wang, Haiyue
2020-09-18  3:35 ` [dpdk-dev] [PATCH v2 0/3] AVX512 vPMD on ice Leyi Rong
2020-09-18  3:35   ` [dpdk-dev] [PATCH v2 1/3] net/ice: add AVX512 vector path Leyi Rong
2020-09-18  3:35   ` [dpdk-dev] [PATCH v2 2/3] net/ice: add RSS hash parsing in AVX512 path Leyi Rong
2020-09-18  3:35   ` [dpdk-dev] [PATCH v2 3/3] net/ice: optimize Tx path on AVX512 vPMD Leyi Rong
2020-10-20 10:51 ` [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on ice Leyi Rong
2020-10-20 10:51   ` [dpdk-dev] [PATCH v3 1/3] net/ice: add AVX512 vector path Leyi Rong
2020-10-20 10:51   ` [dpdk-dev] [PATCH v3 2/3] net/ice: add RSS hash parsing in AVX512 path Leyi Rong
2020-10-20 10:51   ` [dpdk-dev] [PATCH v3 3/3] net/ice: optimize Tx path on AVX512 vPMD Leyi Rong
2020-10-23  4:14 ` [dpdk-dev] [PATCH v4 0/3] AVX512 vPMD on ice Leyi Rong
2020-10-23  4:14   ` [dpdk-dev] [PATCH v4 1/3] net/ice: add AVX512 vector path Leyi Rong
2020-10-25 16:23     ` David Marchand [this message]
2020-10-26  7:12       ` Rong, Leyi
2020-10-26  8:09         ` David Marchand
2020-10-27 10:19           ` Bruce Richardson
2020-10-27 10:22         ` Ferruh Yigit
2020-10-27  8:32     ` Ali Alnubani
2020-10-27  8:42       ` Ali Alnubani
2020-10-23  4:14   ` [dpdk-dev] [PATCH v4 2/3] net/ice: add RSS hash parsing in AVX512 path Leyi Rong
2020-10-23  4:14   ` [dpdk-dev] [PATCH v4 3/3] net/ice: optimize Tx path on AVX512 vPMD Leyi Rong
2020-10-23  9:39   ` [dpdk-dev] [PATCH v4 0/3] AVX512 vPMD on ice Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8zZ6StMasJBWJN-i4bnVo9kVDruki6LVxd_kHApw8twGQ@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=leyi.rong@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=thomas@monjalon.net \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git