From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 053E1A0471 for ; Mon, 17 Jun 2019 13:41:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 99C991BF0B; Mon, 17 Jun 2019 13:41:34 +0200 (CEST) Received: from mail-vk1-f195.google.com (mail-vk1-f195.google.com [209.85.221.195]) by dpdk.org (Postfix) with ESMTP id 448CF1BF09 for ; Mon, 17 Jun 2019 13:41:33 +0200 (CEST) Received: by mail-vk1-f195.google.com with SMTP id s16so1989379vke.7 for ; Mon, 17 Jun 2019 04:41:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eW3IO6WxEB8rrRmhzKjadWz9hKVj79caULd7rcNFbUE=; b=DxluX0tGUnBTQQJNGvtFGEAYx3a6thcUHPAQ4ipgf4GkNhAB2Gktc/jN2UgmDjPMbL XFfww9ppDZ97qbtRejnpj5r9E9Yn2wwMI8oViRTsjfznp/OyGUcClH1rJ+gqbuCm04ln VGZtOBNG4NUf6BEU1zVe9RcoqfXhD2bTX+w17aJBEULpfZJWmSLKRq4E3/jUSFozl+VY lhY4X7BunYL2KNZDJgq+Bj3BEtuOoVloSo6gN0qbPtE5KROfrUKW6BbnFHbMyiA4ykIw lHVc2odcKDzTJjfrfQQHWLutv0/EOrJyXbqWeKBnlr5fTMQ2eOBHa+v57GHZLb1R+xmW KOPA== X-Gm-Message-State: APjAAAW5+By6YBwevEjnA9Ve4RhuUi4khp5LVqFoQmlIkfmItS/IBNbm HwjZfD8ceqbzjt/g8Q6iecBQlQwIqgRLjgd+XbFCLQ== X-Google-Smtp-Source: APXvYqxyCXdTlNJurjei/Yw+quV/qugToRMCXLVgn+9OgRsEyN0mWeyPUSphLiHPYl656OVZrMT6+F8LDpDSftItvnQ= X-Received: by 2002:a1f:1185:: with SMTP id 127mr18356745vkr.85.1560771692508; Mon, 17 Jun 2019 04:41:32 -0700 (PDT) MIME-Version: 1.0 References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> <1560580950-16754-1-git-send-email-david.marchand@redhat.com> <20190617100027.GA527@bricha3-MOBL.ger.corp.intel.com> <20190617111713.GD527@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190617111713.GD527@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Mon, 17 Jun 2019 13:41:21 +0200 Message-ID: To: Bruce Richardson Cc: dev , Thomas Monjalon , Aaron Conole , Michael Santana Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 17, 2019 at 1:18 PM Bruce Richardson wrote: > On Mon, Jun 17, 2019 at 12:46:03PM +0200, David Marchand wrote: > > On Mon, Jun 17, 2019 at 12:02 PM Bruce Richardson > > <[1]bruce.richardson@intel.com> wrote: > > > > On Sat, Jun 15, 2019 at 08:42:15AM +0200, David Marchand wrote: > > > This is a joint effort to make the unit tests ready for CI. > > > The first patches are fixes that I had accumulated. > > > Then the second part of the series focuses on skipping tests when > > some > > > requirements are not fulfilled so that we can start them in a > > restrained > > > environment like Travis virtual machines that gives us two cores > > and does > > > not have specific hw devices. > > > > > > We are still not ready for enabling those tests in Travis. > > > At least, the following issues remain: > > > - some fixes on librte_acl have not been merged yet [1], > > > - the tests on --file-prefix are still ko, and have been isolated > > in a > > > test that we could disable while waiting for the fixes, > > > - rwlock_autotest and hash_readwrite_lf_autotest are taking a > > little more > > > than 10s, > > > - librte_table unit test crashes on ipv6 [2], > > > - the "perf" tests are taking way too long for my taste, > > > - the shared build unit tests all fail when depending on mempool > > since > > > the mempool drivers are not loaded, > > > > > For the autotest app shared builds, it is probably worthwhile > > linking in > > all drivers explicitly to avoid issues like this. > > > > Yes, I'll look into this. > > While at it, do you know why the i40e and ixgbe drivers are linked to > > app/test in meson? > > -- > > There are unit tests for the device-specific functions in those drivers, so > they need to be given at link time. > For testpmd, I can understand. But I can't see code for driver specific apis in app/test. It looks like a copy/paste error when adding meson support. -- David Marchand