From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E280AA0528; Thu, 9 Jul 2020 11:57:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D54341E551; Thu, 9 Jul 2020 11:57:55 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 340391DEA4 for ; Thu, 9 Jul 2020 11:57:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594288674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+DnFw9P06R5zUoPzU8oIrWiH84yo+jTNkckpfn4ClMU=; b=ZsPek1wCaMjuTLvAQhsOYBbpDCZTVbIFEEwCTnRXsQ2Rh2CipkgqYAkjRhy+pzDv2SW+r/ 5LlF799L9+DPO+OlBFI9cs5QSyrsZOAnQj+DWHE1kreiX6tw/iUPbWvMb6ilMHna3cWULv YuHr+jZrGbK47kkHJZ6x62ObN90FmNM= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-133-3JDm7baLNYWRDao1GMH7vw-1; Thu, 09 Jul 2020 05:57:50 -0400 X-MC-Unique: 3JDm7baLNYWRDao1GMH7vw-1 Received: by mail-ua1-f71.google.com with SMTP id o9so656993uar.22 for ; Thu, 09 Jul 2020 02:57:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+DnFw9P06R5zUoPzU8oIrWiH84yo+jTNkckpfn4ClMU=; b=IrumtyhGpLKT+Z7lG85Sr6lwHovktJKcWF2G5rvGF1raSVUQrSYuxfAQh0isQgSlqa oa/S37LvNqeeYT4HKGbCefypRfzXipizKfBAVbaoYfTyBRJ9b3m9jUOBlGZwc17jNVOz qvdW3tFVSavqkYAK7VtiCrWhtOoAcxX2yGx1U6Ixd9Zd9vczKBad/Td7yz3M3VGzqKlz OrftP2YYaGKi9Ver0Ry9WxywFGwfL0k6+TGHAosr2B5DKNlGtLnT1S7Ks75XTND6evPZ u8vadZtyEHw0tka45JLDBVSxLog2A9m1ioIet5eZVj0prBc7H3eqQvMVHXa8N0C0Q0kt iPOw== X-Gm-Message-State: AOAM533BycJiBsALWVf8Z0h302S7yYEXdYicX8WshRWADQnufqMWosqy znH4o/A07BAHXhz5BtfuMr0bY0fBRHCl1NONv1CEoSkKvDJgMd1ax5Ghhun9smhiHKK62l88Pf7 gUvyRLHFNUhWAsxTWPgQ= X-Received: by 2002:a67:c58c:: with SMTP id h12mr40476591vsk.141.1594288669787; Thu, 09 Jul 2020 02:57:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwC8WpTbD6cyCFMGfH34/jlsx9FlzbPD3YA8Py+g6fBZlvInfmejyjVXbw2Gb6BFvN4c9bcwk5ej+fbySijXSA= X-Received: by 2002:a67:c58c:: with SMTP id h12mr40476565vsk.141.1594288669536; Thu, 09 Jul 2020 02:57:49 -0700 (PDT) MIME-Version: 1.0 References: <20200611033248.39049-1-joyce.kong@arm.com> <20200706074930.54299-1-joyce.kong@arm.com> <20200706074930.54299-5-joyce.kong@arm.com> In-Reply-To: From: David Marchand Date: Thu, 9 Jul 2020 11:57:38 +0200 Message-ID: To: Joyce Kong Cc: Maxime Coquelin , "jerinj@marvell.com" , Zhihong Wang , Xiaolong Ye , Beilei Xing , Jeff Guo , "Mcnamara, John" , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Honnappa Nagarahalli , Phil Yang , Ruifeng Wang , dev , nd Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 4/6] net/i40e: replace restrict with rte restrict X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 8, 2020 at 5:21 AM Joyce Kong wrote: > > > -----Original Message----- > > From: David Marchand > > Sent: Tuesday, July 7, 2020 10:00 PM > > To: Joyce Kong > > Cc: Maxime Coquelin ; jerinj@marvell.com; > > Zhihong Wang ; Xiaolong Ye > > ; Beilei Xing ; Jeff Guo > > ; Mcnamara, John ; Matan > > Azrad ; Shahaf Shuler ; > > Viacheslav Ovsiienko ; Honnappa Nagarahalli > > ; Phil Yang ; > > Ruifeng Wang ; dev ; nd > > > > Subject: Re: [dpdk-dev] [PATCH v2 4/6] net/i40e: replace restrict with rte > > restrict > > > > On Mon, Jul 6, 2020 at 9:50 AM Joyce Kong wrote: > > > > > > '__rte_restrict' is a common wrapper for restricted pointers which can > > > be supported by all compilers. Use '__rte_restrict' instead of > > > '__restrict' for code consistency. > > > > This patch 4, 5 and 6 are simple replacements and can be squashed into the > > first patch. > > > > Thanks. > > > The first patch is to add a common definition for lib_eal, could we squash the 4,5 and 6 > into one replacement patch, while separate them from the first one? > This might be more convenient for review? A copy/paste commitlog hints that it did not deserve separate patches. About easing reviews, the changes are mechanical, there is no special case. I am not convinced but, go as you like. Can you provide a new revision wrt patch 1 problem? Thanks. -- David Marchand