From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D07EEA046B for ; Mon, 22 Jul 2019 21:27:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C04561BEF2; Mon, 22 Jul 2019 21:27:25 +0200 (CEST) Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com [209.85.217.65]) by dpdk.org (Postfix) with ESMTP id 57DAA1BEED for ; Mon, 22 Jul 2019 21:27:24 +0200 (CEST) Received: by mail-vs1-f65.google.com with SMTP id v129so27065087vsb.11 for ; Mon, 22 Jul 2019 12:27:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hP8kvLootLSQ2De1AsxMN1PE0F0yeUYvxfWBmTvbzcY=; b=rYsa2bGkxZ9HKCvMLupgqtpFTg+wcqQBxMMfevmq76UzT6b2al1LfPnw1MvQp8p0Qw ycql6Bdvi5qsEZ9QCiu0o1DC7TT/GXTx2lPwnlCV1nn/cX2+KdL2Io98hMsTsA8KnkEf +5X8lODcSzRk26iBC4WL9TLdNx5KxT2jUfan3tL6OMAZXOtMCAFkW+5szbfTWvIzIHCg dp+MNZwcpXYt8elI2Km27u80U0HVsxoE3ECc/I2DRjjQL59uktIaEnJ48R+Q5wdC3k0d gXL6Ukc/MbxsEcNJLx04aMEfpd8d0hyQBWHVfyQ8cTnM4fm4xN0rKIly3T6p1Krv4Gff d5Vw== X-Gm-Message-State: APjAAAVIVCrtEQTLxMT9H0wb5zi50SdrVGWhbu80FOG1Yq35yOj7uhkg SXgpKo0NvnmcI8g1uS8lX0O7yRvRIOwuTmgAIQur+g== X-Google-Smtp-Source: APXvYqxIX2gcaOOMb61BtLgKIfwTR1dr7uLUVVl2b9biRos96/Bynym0EJE5U0SGHEvHVXAEcba8NXQrzybdn+wsxY4= X-Received: by 2002:a67:f998:: with SMTP id b24mr44538070vsq.180.1563823643621; Mon, 22 Jul 2019 12:27:23 -0700 (PDT) MIME-Version: 1.0 References: <20190717115852.171416-1-ndabilpuram@marvell.com> <20190718143628.169623-1-ndabilpuram@marvell.com> <20190718143628.169623-2-ndabilpuram@marvell.com> In-Reply-To: <20190718143628.169623-2-ndabilpuram@marvell.com> From: David Marchand Date: Mon, 22 Jul 2019 21:27:12 +0200 Message-ID: To: Nithin Dabilpuram Cc: Hyong Youb Kim , Thomas Monjalon , Ferruh Yigit , Anatoly Burakov , Jerin Jacob Kollanukkaran , John Daley , Shahed Shaikh , dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 1/3] vfio: revert change that does intr eventfd setup at probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 18, 2019 at 4:36 PM Nithin Dabilpuram wrote: > > This reverts commit 89aac60e0be9ed95a87b16e3595f102f9faaffb4. > "vfio: fix interrupts race condition" > > The above mentioned commit moves the interrupt's eventfd setup > to probe time but only enables one interrupt for all types of > interrupt handles i.e VFIO_MSI, VFIO_LEGACY, VFIO_MSIX, UIO. > It works fine with default case but breaks below cases specifically > for MSIX based interrupt handles. > > * Applications like l3fwd-power that request rxq interrupts > while ethdev setup. > * Drivers that need > 1 MSIx interrupts to be configured for > functionality to work. > > VFIO PCI for MSIx expects all the possible vectors to be setup up > when using VFIO_IRQ_SET_ACTION_TRIGGER so that they can be > allocated from kernel pci subsystem. Only way to increase the number > of vectors later is first free all by using VFIO_IRQ_SET_DATA_NONE > with action trigger and then enable new vector count. Indeed, this is the part that I had missed. Ok for this revert. A bit sad to see the coding style issues back :-). -- David Marchand