From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2824A04DD; Thu, 26 Nov 2020 17:31:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 47409C9F4; Thu, 26 Nov 2020 17:31:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id EAFF9C9A8 for ; Thu, 26 Nov 2020 17:31:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606408261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=egBFgUWCF/+NOdoNQpYJEAt2M3hcH+NEzxvp8NDqSIo=; b=XDtKPM/LrfzgwRmg5XndnWIq6iDsIYCfsZJmes0IbLqJhCqGQ0aKyPNJ/cIXbsM8AwbOWH 5We1YMCUn0lZMOEMpTMZeavwX0i26aRB1FmDsPKn8vAj0eVB1rzeICkomEtoUpsQ+6RPL2 NQacCgAPLfbiaQ25TLERcngtvvWaZkg= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-eqAYNaq9P86kkN4Kz-n9oA-1; Thu, 26 Nov 2020 11:30:58 -0500 X-MC-Unique: eqAYNaq9P86kkN4Kz-n9oA-1 Received: by mail-vk1-f199.google.com with SMTP id p199so920857vkp.23 for ; Thu, 26 Nov 2020 08:30:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=egBFgUWCF/+NOdoNQpYJEAt2M3hcH+NEzxvp8NDqSIo=; b=EmNZ1RiauB3yxQ3jBdM8Zd/jIQYLnlwNF/e7W5ZtkoiohCy2fddiXSOjOHqe0OTiUk IFwpXqQXos8DMPxcuCsguryQHmbchhGGBnm19/gpEFtk+s6C40+wkv0ktCpvrHYY/anR QRp0F7JhvrBmvT0IUKWIqhIxBUU+12o8xDrMjYkrIk0oaeQ6i6qsaTduAxdL0Vy9g4Sa HdShDs5Z1kiS1W33j5Lp1ZqKIoqtmF9X5pDieqw9y0FkIPeC8Y1OdE8pHNdnaU8jQ98E 9Ps936hxCrexFb2OkLEOnldDY58ayMSwFItH59oztF9EYceuVxOfL+kS74rvTeDXSyAE j1jw== X-Gm-Message-State: AOAM531K22enSr9WOeDBQcIqK5FaAwQLliBiE1oTtgqVnDDgAqOdrtM6 IYIq18CwJRzcZ9MfAadH1w/wwblqCCb3PwwIFukxGTEoP97BXfOkRE0FKu2B3XpA4YFOkHLxjzO ciTH+VDqefWQ9aYCrAR0= X-Received: by 2002:a05:6102:2362:: with SMTP id o2mr2461383vsa.5.1606408258357; Thu, 26 Nov 2020 08:30:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJzlDJ71aDwjd+KEjOOaJrrSqocg/cLPSEzyWiDVd0iGcQF7G/mB1ogAq2/gq+rWkGYIQ83C66fOSgGZoSvG+v8= X-Received: by 2002:a05:6102:2362:: with SMTP id o2mr2461371vsa.5.1606408258133; Thu, 26 Nov 2020 08:30:58 -0800 (PST) MIME-Version: 1.0 References: <20201126141832.2277628-1-ferruh.yigit@intel.com> In-Reply-To: <20201126141832.2277628-1-ferruh.yigit@intel.com> From: David Marchand Date: Thu, 26 Nov 2020 17:30:46 +0100 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , dev , techboard@dpdk.org, Stephen Hemminger , Bruce Richardson , Conor Walsh Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 0/6] update dpdk-setup.sh X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 26, 2020 at 3:19 PM Ferruh Yigit wrote: > > This is an effort to update the dpdk-setup.sh script and keep it one > more year until whole functionality of it is replaced. > > Other option is to remove it completely, please comment. I would simply remove this script. Binding devices can be done with either driverctl (which is available in most distributions) and dpdk-devbind.py (which a Howto already in the doc). As for permissions, what this script is doing is scary. I would prefer users don't rely on this: usertools/dpdk-setup.sh: sudo chmod a+x /dev/vfio usertools/dpdk-setup.sh: sudo chmod 0666 /dev/vfio/* OVS uses a udev rule for non root support: https://github.com/openvswitch/ovs/blob/master/rhel/usr_lib_udev_rules.d_91-vfio.rules We could describe this in the DPDK documentation. -- David Marchand