[PATCH] version: 24.03-rc0

[PATCH] version: 24.03-rc0

[David Marchand]

Start a new release cycle with empty release notes.
Bump version and ABI minor.
Bump libabigail from 2.1 to 2.4 and enable ABI checks.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .ci/linux-build.sh                     |   7 +-
 .github/workflows/build.yml            |   6 +-
 ABI_VERSION                            |   2 +-
 VERSION                                |   2 +-
 doc/guides/rel_notes/index.rst         |   1 +
 doc/guides/rel_notes/release_24_03.rst | 138 +++++++++++++++++++++++++
 6 files changed, 148 insertions(+), 8 deletions(-)
 create mode 100644 doc/guides/rel_notes/release_24_03.rst

diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 4cdbe9b9e9..1edbf5afc2 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -12,15 +12,16 @@ fi
 install_libabigail() {
     version=$1
     instdir=$2
+    tarball=$version.tar.xz
 
-    wget -q "http://mirrors.kernel.org/sourceware/libabigail/${version}.tar.gz"
-    tar -xf ${version}.tar.gz
+    wget -q "http://mirrors.kernel.org/sourceware/libabigail/$tarball"
+    tar -xf $tarball
     cd $version && autoreconf -vfi && cd -
     mkdir $version/build
     cd $version/build && ../configure --prefix=$instdir && cd -
     make -C $version/build all install
     rm -rf $version
-    rm ${version}.tar.gz
+    rm $tarball
 }
 
 configure_coredump() {
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 272a6ffc7f..af514e9545 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -23,11 +23,11 @@ jobs:
       BUILD_EXAMPLES: ${{ contains(matrix.config.checks, 'examples') }}
       CC: ccache ${{ matrix.config.compiler }}
       DEF_LIB: ${{ matrix.config.library }}
-      LIBABIGAIL_VERSION: libabigail-2.1
+      LIBABIGAIL_VERSION: libabigail-2.4
       MINGW: ${{ matrix.config.cross == 'mingw' }}
       MINI: ${{ matrix.config.mini != '' }}
       PPC64LE: ${{ matrix.config.cross == 'ppc64le' }}
-      REF_GIT_TAG: none
+      REF_GIT_TAG: v23.11
       RISCV64: ${{ matrix.config.cross == 'riscv64' }}
       RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }}
       STDATOMIC: ${{ contains(matrix.config.checks, 'stdatomic') }}
@@ -47,7 +47,7 @@ jobs:
             checks: stdatomic
           - os: ubuntu-20.04
             compiler: gcc
-            checks: debug+doc+examples+tests
+            checks: abi+debug+doc+examples+tests
           - os: ubuntu-20.04
             compiler: clang
             checks: asan+doc+tests
diff --git a/ABI_VERSION b/ABI_VERSION
index d9133a54b6..0dad123924 100644
--- a/ABI_VERSION
+++ b/ABI_VERSION
@@ -1 +1 @@
-24.0
+24.1
diff --git a/VERSION b/VERSION
index 94c0153b26..04137136bd 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-23.11.0
+24.03.0-rc0
diff --git a/doc/guides/rel_notes/index.rst b/doc/guides/rel_notes/index.rst
index d072815279..88f2b30b03 100644
--- a/doc/guides/rel_notes/index.rst
+++ b/doc/guides/rel_notes/index.rst
@@ -8,6 +8,7 @@ Release Notes
     :maxdepth: 1
     :numbered:
 
+    release_24_03
     release_23_11
     release_23_07
     release_23_03
diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst
new file mode 100644
index 0000000000..e9c9717706
--- /dev/null
+++ b/doc/guides/rel_notes/release_24_03.rst
@@ -0,0 +1,138 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright 2023 The DPDK contributors
+
+.. include:: <isonum.txt>
+
+DPDK Release 24.03
+==================
+
+.. **Read this first.**
+
+   The text in the sections below explains how to update the release notes.
+
+   Use proper spelling, capitalization and punctuation in all sections.
+
+   Variable and config names should be quoted as fixed width text:
+   ``LIKE_THIS``.
+
+   Build the docs and view the output file to ensure the changes are correct::
+
+      ninja -C build doc
+      xdg-open build/doc/guides/html/rel_notes/release_24_03.html
+
+
+New Features
+------------
+
+.. This section should contain new features added in this release.
+   Sample format:
+
+   * **Add a title in the past tense with a full stop.**
+
+     Add a short 1-2 sentence description in the past tense.
+     The description should be enough to allow someone scanning
+     the release notes to understand the new feature.
+
+     If the feature adds a lot of sub-features you can use a bullet list
+     like this:
+
+     * Added feature foo to do something.
+     * Enhanced feature bar to do something else.
+
+     Refer to the previous release notes for examples.
+
+     Suggested order in release notes items:
+     * Core libs (EAL, mempool, ring, mbuf, buses)
+     * Device abstraction libs and PMDs (ordered alphabetically by vendor name)
+       - ethdev (lib, PMDs)
+       - cryptodev (lib, PMDs)
+       - eventdev (lib, PMDs)
+       - etc
+     * Other libs
+     * Apps, Examples, Tools (if significant)
+
+     This section is a comment. Do not overwrite or remove it.
+     Also, make sure to start the actual text at the margin.
+     =======================================================
+
+
+Removed Items
+-------------
+
+.. This section should contain removed items in this release. Sample format:
+
+   * Add a short 1-2 sentence description of the removed item
+     in the past tense.
+
+   This section is a comment. Do not overwrite or remove it.
+   Also, make sure to start the actual text at the margin.
+   =======================================================
+
+
+API Changes
+-----------
+
+.. This section should contain API changes. Sample format:
+
+   * sample: Add a short 1-2 sentence description of the API change
+     which was announced in the previous releases and made in this release.
+     Start with a scope label like "ethdev:".
+     Use fixed width quotes for ``function_names`` or ``struct_names``.
+     Use the past tense.
+
+   This section is a comment. Do not overwrite or remove it.
+   Also, make sure to start the actual text at the margin.
+   =======================================================
+
+
+ABI Changes
+-----------
+
+.. This section should contain ABI changes. Sample format:
+
+   * sample: Add a short 1-2 sentence description of the ABI change
+     which was announced in the previous releases and made in this release.
+     Start with a scope label like "ethdev:".
+     Use fixed width quotes for ``function_names`` or ``struct_names``.
+     Use the past tense.
+
+   This section is a comment. Do not overwrite or remove it.
+   Also, make sure to start the actual text at the margin.
+   =======================================================
+
+* No ABI change that would break compatibility with 23.11.
+
+
+Known Issues
+------------
+
+.. This section should contain new known issues in this release. Sample format:
+
+   * **Add title in present tense with full stop.**
+
+     Add a short 1-2 sentence description of the known issue
+     in the present tense. Add information on any known workarounds.
+
+   This section is a comment. Do not overwrite or remove it.
+   Also, make sure to start the actual text at the margin.
+   =======================================================
+
+
+Tested Platforms
+----------------
+
+.. This section should contain a list of platforms that were tested
+   with this release.
+
+   The format is:
+
+   * <vendor> platform with <vendor> <type of devices> combinations
+
+     * List of CPU
+     * List of OS
+     * List of devices
+     * Other relevant details...
+
+   This section is a comment. Do not overwrite or remove it.
+   Also, make sure to start the actual text at the margin.
+   =======================================================
-- 
2.42.0

Re: [PATCH] version: 24.03-rc0

[David Marchand]

On Wed, Nov 29, 2023 at 5:20 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> Start a new release cycle with empty release notes.
> Bump version and ABI minor.
> Bump libabigail from 2.1 to 2.4 and enable ABI checks.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.

Copying subtree maintainers, and ci@ mailing list.
As a result of the discussion on the ci ml
(http://inbox.dpdk.org/ci/CAJvnSUB2zXmHcdZC4rLruRm75MYOHJuWFUTtk8GNVRedfP_xXQ@mail.gmail.com/T/#t),
we worked on setting up some automatic mirroring of dpdk.org
repositories to the github DPDK repository.


What it means:
- for the https://dpdk.org/git/dpdk repository, all the branches and
tags are mirrored to https://github.com/DPDK/dpdk as it was done so
far,
- for the https://git.dpdk.org/next/dpdk-next-* repositories, only
branches named "main", "staging" or "for-*" are mirrored to
https://github.com/DPDK/dpdk with a prefix.
  One example: changes to the for-main branch of the dpdk-next-crypto
repo will be mirrored to a github branch next-crypto-for-main


For subtree maintainers.

It should change nothing to you guys.
Please rebase your trees on v24.03-rc0 and push it to dpdk.org.
And then double check that the mirror happened (looking at git push
output, and checking https://github.com/DPDK/dpdk/branches).
If you hit some issue, ping me.


For CI.

This is more a fyi, there will be some delay before all mirrors are
up, so for now, don't swap the next-* repositories in your script yet.
However, one action that can be taken as v24.03-rc0 is pushed is to
re-enable ABI checks against the v23.11 official tag.


Questions?


-- 
David Marchand

Re: [PATCH] version: 24.03-rc0

[Ferruh Yigit]

On 11/30/2023 9:23 AM, David Marchand wrote:
> On Wed, Nov 29, 2023 at 5:20 PM David Marchand
> <david.marchand@redhat.com> wrote:
>>
>> Start a new release cycle with empty release notes.
>> Bump version and ABI minor.
>> Bump libabigail from 2.1 to 2.4 and enable ABI checks.
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> Applied, thanks.
> 
> Copying subtree maintainers, and ci@ mailing list.
> As a result of the discussion on the ci ml
> (http://inbox.dpdk.org/ci/CAJvnSUB2zXmHcdZC4rLruRm75MYOHJuWFUTtk8GNVRedfP_xXQ@mail.gmail.com/T/#t),
> we worked on setting up some automatic mirroring of dpdk.org
> repositories to the github DPDK repository.
> 
> 
> What it means:
> - for the https://dpdk.org/git/dpdk repository, all the branches and
> tags are mirrored to https://github.com/DPDK/dpdk as it was done so
> far,
> - for the https://git.dpdk.org/next/dpdk-next-* repositories, only
> branches named "main", "staging" or "for-*" are mirrored to
> https://github.com/DPDK/dpdk with a prefix.
>   One example: changes to the for-main branch of the dpdk-next-crypto
> repo will be mirrored to a github branch next-crypto-for-main
> 
> 
> For subtree maintainers.
> 
> It should change nothing to you guys.
> Please rebase your trees on v24.03-rc0 and push it to dpdk.org.
> And then double check that the mirror happened (looking at git push
> output, and checking https://github.com/DPDK/dpdk/branches).
> If you hit some issue, ping me.
> 

I force push a lot, is mirroring configured to cope with this?


> 
> For CI.
> 
> This is more a fyi, there will be some delay before all mirrors are
> up, so for now, don't swap the next-* repositories in your script yet.
> However, one action that can be taken as v24.03-rc0 is pushed is to
> re-enable ABI checks against the v23.11 official tag.
> 
> 
> Questions?
> 
> 

Re: [PATCH] version: 24.03-rc0

[David Marchand]

On Thu, Nov 30, 2023 at 10:30 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
> On 11/30/2023 9:23 AM, David Marchand wrote:
> > On Wed, Nov 29, 2023 at 5:20 PM David Marchand
> > <david.marchand@redhat.com> wrote:
> >>
> >> Start a new release cycle with empty release notes.
> >> Bump version and ABI minor.
> >> Bump libabigail from 2.1 to 2.4 and enable ABI checks.
> >>
> >> Signed-off-by: David Marchand <david.marchand@redhat.com>
> >
> > Applied, thanks.
> >
> > Copying subtree maintainers, and ci@ mailing list.
> > As a result of the discussion on the ci ml
> > (http://inbox.dpdk.org/ci/CAJvnSUB2zXmHcdZC4rLruRm75MYOHJuWFUTtk8GNVRedfP_xXQ@mail.gmail.com/T/#t),
> > we worked on setting up some automatic mirroring of dpdk.org
> > repositories to the github DPDK repository.
> >
> >
> > What it means:
> > - for the https://dpdk.org/git/dpdk repository, all the branches and
> > tags are mirrored to https://github.com/DPDK/dpdk as it was done so
> > far,
> > - for the https://git.dpdk.org/next/dpdk-next-* repositories, only
> > branches named "main", "staging" or "for-*" are mirrored to
> > https://github.com/DPDK/dpdk with a prefix.
> >   One example: changes to the for-main branch of the dpdk-next-crypto
> > repo will be mirrored to a github branch next-crypto-for-main
> >
> >
> > For subtree maintainers.
> >
> > It should change nothing to you guys.
> > Please rebase your trees on v24.03-rc0 and push it to dpdk.org.
> > And then double check that the mirror happened (looking at git push
> > output, and checking https://github.com/DPDK/dpdk/branches).
> > If you hit some issue, ping me.
> >
>
> I force push a lot, is mirroring configured to cope with this?

It is supposed to be handled, yes.


-- 
David Marchand

Re: [PATCH] version: 24.03-rc0

[David Marchand]

On Thu, Nov 30, 2023 at 10:32 AM David Marchand
<david.marchand@redhat.com> wrote:
> > > For subtree maintainers.
> > >
> > > It should change nothing to you guys.
> > > Please rebase your trees on v24.03-rc0 and push it to dpdk.org.
> > > And then double check that the mirror happened (looking at git push
> > > output, and checking https://github.com/DPDK/dpdk/branches).
> > > If you hit some issue, ping me.
> > >
> >
> > I force push a lot, is mirroring configured to cope with this?
>
> It is supposed to be handled, yes.

Thanks to Akhil and Jerin, I can confirm mirroring and force push work ;-).


-- 
David Marchand

Re: [PATCH] version: 24.03-rc0

[Ferruh Yigit]

On 11/30/2023 9:53 AM, David Marchand wrote:
> On Thu, Nov 30, 2023 at 10:32 AM David Marchand
> <david.marchand@redhat.com> wrote:
>>>> For subtree maintainers.
>>>>
>>>> It should change nothing to you guys.
>>>> Please rebase your trees on v24.03-rc0 and push it to dpdk.org.
>>>> And then double check that the mirror happened (looking at git push
>>>> output, and checking https://github.com/DPDK/dpdk/branches).
>>>> If you hit some issue, ping me.
>>>>
>>>
>>> I force push a lot, is mirroring configured to cope with this?
>>
>> It is supposed to be handled, yes.
> 
> Thanks to Akhil and Jerin, I can confirm mirroring and force push work ;-).
> 

Cool, thanks.

Re: [PATCH] version: 24.03-rc0

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 1806 bytes --]

On Thu, Nov 30, 2023 at 4:24 AM David Marchand <david.marchand@redhat.com>
wrote:

>
> What it means:
> - for the https://dpdk.org/git/dpdk repository, all the branches and
> tags are mirrored to https://github.com/DPDK/dpdk as it was done so
> far,
> - for the https://git.dpdk.org/next/dpdk-next-* repositories, only
> branches named "main", "staging" or "for-*" are mirrored to
> https://github.com/DPDK/dpdk with a prefix.
>
Thank you David for clearing some of this up on the CI testing meeting. I
think the final loose end was you were wondering which branches within the
next-* repos we were running from. I'll paste that below:

dpdk-next-crypto: for-main
dpdk-next-eventdev: for-main
dpdk-next-net: main
dpdk-next-net-brcm: main
dpdk-next-net-intel: main
dpdk-next-net-mlx: main
dpdk-next-net-mrvl: for-next-net
dpdk-next-virtio: main
dpdk-next-baseband: for-main


>   One example: changes to the for-main branch of the dpdk-next-crypto
> repo will be mirrored to a github branch next-crypto-for-main
>
>
> For subtree maintainers.
>
> It should change nothing to you guys.
> Please rebase your trees on v24.03-rc0 and push it to dpdk.org.
> And then double check that the mirror happened (looking at git push
> output, and checking https://github.com/DPDK/dpdk/branches).
> If you hit some issue, ping me.
>
>
> For CI.
>
> This is more a fyi, there will be some delay before all mirrors are
> up, so for now, don't swap the next-* repositories in your script yet.
> However, one action that can be taken as v24.03-rc0 is pushed is to
> re-enable ABI checks against the v23.11 official tag.
>
> Okay, we will rebuild our container images to bake in new ABI references
this week. Thanks!


>
> Questions?
>
>
> --
> David Marchand
>
>

[-- Attachment #2: Type: text/html, Size: 3045 bytes --]

Re: [PATCH] version: 24.03-rc0

[Thomas Monjalon]

30/11/2023 19:33, Patrick Robb:
> On Thu, Nov 30, 2023 at 4:24 AM David Marchand <david.marchand@redhat.com>
> wrote:
> 
> > What it means:
> > - for the https://dpdk.org/git/dpdk repository, all the branches and
> > tags are mirrored to https://github.com/DPDK/dpdk as it was done so
> > far,
> > - for the https://git.dpdk.org/next/dpdk-next-* repositories, only
> > branches named "main", "staging" or "for-*" are mirrored to
> > https://github.com/DPDK/dpdk with a prefix.
> 
> Thank you David for clearing some of this up on the CI testing meeting. I
> think the final loose end was you were wondering which branches within the
> next-* repos we were running from. I'll paste that below:
> 
> dpdk-next-crypto: for-main
> dpdk-next-eventdev: for-main
> dpdk-next-net: main
> dpdk-next-net-brcm: main
> dpdk-next-net-intel: main
> dpdk-next-net-mlx: main
> dpdk-next-net-mrvl: for-next-net
> dpdk-next-virtio: main
> dpdk-next-baseband: for-main

We should test patches on top of the branch which is validated
by the tree maintainer and ready to pull.
This is the default branch (HEAD) of its repository on dpdk.org.
This is the list of equivalent GitHub branches to use for testing:

	main
	next-baseband-for-main
	next-crypto-for-main
	next-eventdev-for-main
	next-net-for-main-repo
	next-net-brcm-for-next-net
	next-net-intel-for-next-net
	next-net-mlx-for-next-net
	next-net-mrvl-for-main
	next-virtio-for-next-net

Re: [PATCH] version: 24.03-rc0

[David Marchand]

On Fri, Dec 1, 2023 at 9:04 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 30/11/2023 19:33, Patrick Robb:
> > On Thu, Nov 30, 2023 at 4:24 AM David Marchand <david.marchand@redhat.com>
> > wrote:
> >
> > > What it means:
> > > - for the https://dpdk.org/git/dpdk repository, all the branches and
> > > tags are mirrored to https://github.com/DPDK/dpdk as it was done so
> > > far,
> > > - for the https://git.dpdk.org/next/dpdk-next-* repositories, only
> > > branches named "main", "staging" or "for-*" are mirrored to
> > > https://github.com/DPDK/dpdk with a prefix.
> >
> > Thank you David for clearing some of this up on the CI testing meeting. I
> > think the final loose end was you were wondering which branches within the
> > next-* repos we were running from. I'll paste that below:
> >
> > dpdk-next-crypto: for-main
> > dpdk-next-eventdev: for-main
> > dpdk-next-net: main
> > dpdk-next-net-brcm: main
> > dpdk-next-net-intel: main
> > dpdk-next-net-mlx: main
> > dpdk-next-net-mrvl: for-next-net
> > dpdk-next-virtio: main
> > dpdk-next-baseband: for-main
>
> We should test patches on top of the branch which is validated
> by the tree maintainer and ready to pull.
> This is the default branch (HEAD) of its repository on dpdk.org.

This could be queried to avoid maintaining a map that may change in the future.

Some (pinpointed) query like below should not be that heavy to
dpdk.org git server:
$ git ls-remote --symref https://dpdk.org/git/next/dpdk-next-net HEAD
ref: refs/heads/for-main-repo    HEAD
afe986d15845e7a774ae3a4e23e03bb7d3bcba72    HEAD


This could be added as a new script in dpdk-ci.
Like tools/get_mirror.py which would parse MAINTAINERS and send this
query I mentionned above?

$ tools/pw_maintainers_cli.py --type series list-trees 30419
dpdk-next-net

$ tools/get_mirror.py dpdk-next-net
https://github.com/DPDK/dpdk next-net-for-main-repo

> This is the list of equivalent GitHub branches to use for testing:
>
>         main
>         next-baseband-for-main
>         next-crypto-for-main
>         next-eventdev-for-main
>         next-net-for-main-repo
>         next-net-brcm-for-next-net
>         next-net-intel-for-next-net
>         next-net-mlx-for-next-net
>         next-net-mrvl-for-main
>         next-virtio-for-next-net


-- 
David Marchand

Re: [PATCH] version: 24.03-rc0

[Thomas Monjalon]

01/12/2023 09:55, David Marchand:
> On Fri, Dec 1, 2023 at 9:04 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 30/11/2023 19:33, Patrick Robb:
> > > On Thu, Nov 30, 2023 at 4:24 AM David Marchand <david.marchand@redhat.com>
> > > wrote:
> > >
> > > > What it means:
> > > > - for the https://dpdk.org/git/dpdk repository, all the branches and
> > > > tags are mirrored to https://github.com/DPDK/dpdk as it was done so
> > > > far,
> > > > - for the https://git.dpdk.org/next/dpdk-next-* repositories, only
> > > > branches named "main", "staging" or "for-*" are mirrored to
> > > > https://github.com/DPDK/dpdk with a prefix.
> > >
> > > Thank you David for clearing some of this up on the CI testing meeting. I
> > > think the final loose end was you were wondering which branches within the
> > > next-* repos we were running from. I'll paste that below:
> > >
> > > dpdk-next-crypto: for-main
> > > dpdk-next-eventdev: for-main
> > > dpdk-next-net: main
> > > dpdk-next-net-brcm: main
> > > dpdk-next-net-intel: main
> > > dpdk-next-net-mlx: main
> > > dpdk-next-net-mrvl: for-next-net
> > > dpdk-next-virtio: main
> > > dpdk-next-baseband: for-main
> >
> > We should test patches on top of the branch which is validated
> > by the tree maintainer and ready to pull.
> > This is the default branch (HEAD) of its repository on dpdk.org.
> 
> This could be queried to avoid maintaining a map that may change in the future.
> 
> Some (pinpointed) query like below should not be that heavy to
> dpdk.org git server:
> $ git ls-remote --symref https://dpdk.org/git/next/dpdk-next-net HEAD
> ref: refs/heads/for-main-repo    HEAD
> afe986d15845e7a774ae3a4e23e03bb7d3bcba72    HEAD

Yes

> This could be added as a new script in dpdk-ci.
> Like tools/get_mirror.py which would parse MAINTAINERS and send this
> query I mentionned above?
> 
> $ tools/pw_maintainers_cli.py --type series list-trees 30419
> dpdk-next-net
> 
> $ tools/get_mirror.py dpdk-next-net
> https://github.com/DPDK/dpdk next-net-for-main-repo

Why not adding it to pw_maintainers_cli.py?
It could be an option to get the GitHub branch.


> > This is the list of equivalent GitHub branches to use for testing:
> >
> >         main
> >         next-baseband-for-main
> >         next-crypto-for-main
> >         next-eventdev-for-main
> >         next-net-for-main-repo
> >         next-net-brcm-for-next-net
> >         next-net-intel-for-next-net
> >         next-net-mlx-for-next-net
> >         next-net-mrvl-for-main
> >         next-virtio-for-next-net

Re: [PATCH] version: 24.03-rc0

[David Marchand]

On Fri, Dec 1, 2023 at 11:33 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > This could be added as a new script in dpdk-ci.
> > Like tools/get_mirror.py which would parse MAINTAINERS and send this
> > query I mentionned above?
> >
> > $ tools/pw_maintainers_cli.py --type series list-trees 30419
> > dpdk-next-net
> >
> > $ tools/get_mirror.py dpdk-next-net
> > https://github.com/DPDK/dpdk next-net-for-main-repo
>
> Why not adding it to pw_maintainers_cli.py?

I don't have a strong opinion against.
I liked the simple script that translates a repo name to a mirror url
+ branch info.

In pw_maintainers_cli.py, how would you express this?
As a new output option for the "list-trees" command? That's a bit weird to me.


-- 
David Marchand

Re: [PATCH] version: 24.03-rc0

[Bruce Richardson]

On Fri, Dec 01, 2023 at 09:04:10AM +0100, Thomas Monjalon wrote:
> 30/11/2023 19:33, Patrick Robb:
> > On Thu, Nov 30, 2023 at 4:24 AM David Marchand <david.marchand@redhat.com>
> > wrote:
> > 
> > > What it means:
> > > - for the https://dpdk.org/git/dpdk repository, all the branches and
> > > tags are mirrored to https://github.com/DPDK/dpdk as it was done so
> > > far,
> > > - for the https://git.dpdk.org/next/dpdk-next-* repositories, only
> > > branches named "main", "staging" or "for-*" are mirrored to
> > > https://github.com/DPDK/dpdk with a prefix.
> > 
> > Thank you David for clearing some of this up on the CI testing meeting. I
> > think the final loose end was you were wondering which branches within the
> > next-* repos we were running from. I'll paste that below:
> > 
> > dpdk-next-crypto: for-main
> > dpdk-next-eventdev: for-main
> > dpdk-next-net: main
> > dpdk-next-net-brcm: main
> > dpdk-next-net-intel: main
> > dpdk-next-net-mlx: main
> > dpdk-next-net-mrvl: for-next-net
> > dpdk-next-virtio: main
> > dpdk-next-baseband: for-main
> 
> We should test patches on top of the branch which is validated
> by the tree maintainer and ready to pull.
> This is the default branch (HEAD) of its repository on dpdk.org.
> This is the list of equivalent GitHub branches to use for testing:
> 
> 	main
> 	next-baseband-for-main
> 	next-crypto-for-main
> 	next-eventdev-for-main
> 	next-net-for-main-repo

The (slight) inconsistency here is curious. Is there a reason why this
branch has "repo" on the end and none of the others don't?

> 	next-net-brcm-for-next-net
> 	next-net-intel-for-next-net
> 	next-net-mlx-for-next-net
> 	next-net-mrvl-for-main
> 	next-virtio-for-next-net
> 

We can also use this to produce nice graphs showing the flow through trees
if we want. This works for me as basic graph, but can probably be cleaned
up more:

git branch -a | awk 'BEGIN {print "digraph {"} $1 ~ /-for-/ {sub(/remotes.origin./, "", $1); sub(/-repo/,"", $1); sub(/-for-/,"\" -> \"", $1); print "\""$1"\""} END {print "}"}' | dot -Tpng -o trees.png

/Bruce

Re: [PATCH] version: 24.03-rc0

[Ferruh Yigit]

On 12/1/2023 11:13 AM, Bruce Richardson wrote:
> On Fri, Dec 01, 2023 at 09:04:10AM +0100, Thomas Monjalon wrote:
>> 30/11/2023 19:33, Patrick Robb:
>>> On Thu, Nov 30, 2023 at 4:24 AM David Marchand <david.marchand@redhat.com>
>>> wrote:
>>>
>>>> What it means:
>>>> - for the https://dpdk.org/git/dpdk repository, all the branches and
>>>> tags are mirrored to https://github.com/DPDK/dpdk as it was done so
>>>> far,
>>>> - for the https://git.dpdk.org/next/dpdk-next-* repositories, only
>>>> branches named "main", "staging" or "for-*" are mirrored to
>>>> https://github.com/DPDK/dpdk with a prefix.
>>>
>>> Thank you David for clearing some of this up on the CI testing meeting. I
>>> think the final loose end was you were wondering which branches within the
>>> next-* repos we were running from. I'll paste that below:
>>>
>>> dpdk-next-crypto: for-main
>>> dpdk-next-eventdev: for-main
>>> dpdk-next-net: main
>>> dpdk-next-net-brcm: main
>>> dpdk-next-net-intel: main
>>> dpdk-next-net-mlx: main
>>> dpdk-next-net-mrvl: for-next-net
>>> dpdk-next-virtio: main
>>> dpdk-next-baseband: for-main
>>
>> We should test patches on top of the branch which is validated
>> by the tree maintainer and ready to pull.
>> This is the default branch (HEAD) of its repository on dpdk.org.
>> This is the list of equivalent GitHub branches to use for testing:
>>
>> 	main
>> 	next-baseband-for-main
>> 	next-crypto-for-main
>> 	next-eventdev-for-main
>> 	next-net-for-main-repo
> 
> The (slight) inconsistency here is curious. Is there a reason why this
> branch has "repo" on the end and none of the others don't?
> 

No specific reason, it started like that in the past. If the consensus
is to go with 'for-main', I can update it.

>> 	next-net-brcm-for-next-net
>> 	next-net-intel-for-next-net
>> 	next-net-mlx-for-next-net
>> 	next-net-mrvl-for-main
>> 	next-virtio-for-next-net
>>
> 
> We can also use this to produce nice graphs showing the flow through trees
> if we want. This works for me as basic graph, but can probably be cleaned
> up more:
> 
> git branch -a | awk 'BEGIN {print "digraph {"} $1 ~ /-for-/ {sub(/remotes.origin./, "", $1); sub(/-repo/,"", $1); sub(/-for-/,"\" -> \"", $1); print "\""$1"\""} END {print "}"}' | dot -Tpng -o trees.png
> 
> /Bruce

Re: [PATCH] version: 24.03-rc0

[Bruce Richardson]

On Fri, Dec 01, 2023 at 11:33:25AM +0000, Ferruh Yigit wrote:
> On 12/1/2023 11:13 AM, Bruce Richardson wrote:
> > On Fri, Dec 01, 2023 at 09:04:10AM +0100, Thomas Monjalon wrote:
> >> 30/11/2023 19:33, Patrick Robb:
> >>> On Thu, Nov 30, 2023 at 4:24 AM David Marchand <david.marchand@redhat.com>
> >>> wrote:
> >>>
> >>>> What it means:
> >>>> - for the https://dpdk.org/git/dpdk repository, all the branches and
> >>>> tags are mirrored to https://github.com/DPDK/dpdk as it was done so
> >>>> far,
> >>>> - for the https://git.dpdk.org/next/dpdk-next-* repositories, only
> >>>> branches named "main", "staging" or "for-*" are mirrored to
> >>>> https://github.com/DPDK/dpdk with a prefix.
> >>>
> >>> Thank you David for clearing some of this up on the CI testing meeting. I
> >>> think the final loose end was you were wondering which branches within the
> >>> next-* repos we were running from. I'll paste that below:
> >>>
> >>> dpdk-next-crypto: for-main
> >>> dpdk-next-eventdev: for-main
> >>> dpdk-next-net: main
> >>> dpdk-next-net-brcm: main
> >>> dpdk-next-net-intel: main
> >>> dpdk-next-net-mlx: main
> >>> dpdk-next-net-mrvl: for-next-net
> >>> dpdk-next-virtio: main
> >>> dpdk-next-baseband: for-main
> >>
> >> We should test patches on top of the branch which is validated
> >> by the tree maintainer and ready to pull.
> >> This is the default branch (HEAD) of its repository on dpdk.org.
> >> This is the list of equivalent GitHub branches to use for testing:
> >>
> >> 	main
> >> 	next-baseband-for-main
> >> 	next-crypto-for-main
> >> 	next-eventdev-for-main
> >> 	next-net-for-main-repo
> > 
> > The (slight) inconsistency here is curious. Is there a reason why this
> > branch has "repo" on the end and none of the others don't?
> > 
> 
> No specific reason, it started like that in the past. If the consensus
> is to go with 'for-main', I can update it.
> 
In all likelihood it's not a big deal.

I'm just thinking that for any future automation or tracking, having a very
consistent naming would be best. For example, in the one-liner I posted for
generating the graph showing the inter-tree flow, I needed a special regex
to strip off the "-repo", so that we didn't have a separate target called
"main-repo" and another called "main".

/Bruce

Re: [PATCH] version: 24.03-rc0

[Ferruh Yigit]

On 12/1/2023 2:30 PM, Bruce Richardson wrote:
> On Fri, Dec 01, 2023 at 11:33:25AM +0000, Ferruh Yigit wrote:
>> On 12/1/2023 11:13 AM, Bruce Richardson wrote:
>>> On Fri, Dec 01, 2023 at 09:04:10AM +0100, Thomas Monjalon wrote:
>>>> 30/11/2023 19:33, Patrick Robb:
>>>>> On Thu, Nov 30, 2023 at 4:24 AM David Marchand <david.marchand@redhat.com>
>>>>> wrote:
>>>>>
>>>>>> What it means:
>>>>>> - for the https://dpdk.org/git/dpdk repository, all the branches and
>>>>>> tags are mirrored to https://github.com/DPDK/dpdk as it was done so
>>>>>> far,
>>>>>> - for the https://git.dpdk.org/next/dpdk-next-* repositories, only
>>>>>> branches named "main", "staging" or "for-*" are mirrored to
>>>>>> https://github.com/DPDK/dpdk with a prefix.
>>>>>
>>>>> Thank you David for clearing some of this up on the CI testing meeting. I
>>>>> think the final loose end was you were wondering which branches within the
>>>>> next-* repos we were running from. I'll paste that below:
>>>>>
>>>>> dpdk-next-crypto: for-main
>>>>> dpdk-next-eventdev: for-main
>>>>> dpdk-next-net: main
>>>>> dpdk-next-net-brcm: main
>>>>> dpdk-next-net-intel: main
>>>>> dpdk-next-net-mlx: main
>>>>> dpdk-next-net-mrvl: for-next-net
>>>>> dpdk-next-virtio: main
>>>>> dpdk-next-baseband: for-main
>>>>
>>>> We should test patches on top of the branch which is validated
>>>> by the tree maintainer and ready to pull.
>>>> This is the default branch (HEAD) of its repository on dpdk.org.
>>>> This is the list of equivalent GitHub branches to use for testing:
>>>>
>>>> 	main
>>>> 	next-baseband-for-main
>>>> 	next-crypto-for-main
>>>> 	next-eventdev-for-main
>>>> 	next-net-for-main-repo
>>>
>>> The (slight) inconsistency here is curious. Is there a reason why this
>>> branch has "repo" on the end and none of the others don't?
>>>
>>
>> No specific reason, it started like that in the past. If the consensus
>> is to go with 'for-main', I can update it.
>>
> In all likelihood it's not a big deal.
> 
> I'm just thinking that for any future automation or tracking, having a very
> consistent naming would be best. For example, in the one-liner I posted for
> generating the graph showing the inter-tree flow, I needed a special regex
> to strip off the "-repo", so that we didn't have a separate target called
> "main-repo" and another called "main".
> 

Agree on above, created 'for-main' branch and will use it now.

But I need help from Thomas/David to delete remote 'for-main-repo' branch.

Re: [PATCH] version: 24.03-rc0

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 3189 bytes --]

On Fri, Dec 1, 2023 at 11:36 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 12/1/2023 2:30 PM, Bruce Richardson wrote:
> > On Fri, Dec 01, 2023 at 11:33:25AM +0000, Ferruh Yigit wrote:
> >> On 12/1/2023 11:13 AM, Bruce Richardson wrote:
> >>> On Fri, Dec 01, 2023 at 09:04:10AM +0100, Thomas Monjalon wrote:
> >>>> 30/11/2023 19:33, Patrick Robb:
> >>>>> On Thu, Nov 30, 2023 at 4:24 AM David Marchand <
> david.marchand@redhat.com>
> >>>>> wrote:
> >>>>>
> >>>>>> What it means:
> >>>>>> - for the https://dpdk.org/git/dpdk repository, all the branches
> and
> >>>>>> tags are mirrored to https://github.com/DPDK/dpdk as it was done so
> >>>>>> far,
> >>>>>> - for the https://git.dpdk.org/next/dpdk-next-* repositories, only
> >>>>>> branches named "main", "staging" or "for-*" are mirrored to
> >>>>>> https://github.com/DPDK/dpdk with a prefix.
> >>>>>
> >>>>> Thank you David for clearing some of this up on the CI testing
> meeting. I
> >>>>> think the final loose end was you were wondering which branches
> within the
> >>>>> next-* repos we were running from. I'll paste that below:
> >>>>>
> >>>>> dpdk-next-crypto: for-main
> >>>>> dpdk-next-eventdev: for-main
> >>>>> dpdk-next-net: main
> >>>>> dpdk-next-net-brcm: main
> >>>>> dpdk-next-net-intel: main
> >>>>> dpdk-next-net-mlx: main
> >>>>> dpdk-next-net-mrvl: for-next-net
> >>>>> dpdk-next-virtio: main
> >>>>> dpdk-next-baseband: for-main
> >>>>
> >>>> We should test patches on top of the branch which is validated
> >>>> by the tree maintainer and ready to pull.
> >>>> This is the default branch (HEAD) of its repository on dpdk.org.
> >>>> This is the list of equivalent GitHub branches to use for testing:
> >>>>
> >>>>    main
> >>>>    next-baseband-for-main
> >>>>    next-crypto-for-main
> >>>>    next-eventdev-for-main
> >>>>    next-net-for-main-repo
> >>>
> >>> The (slight) inconsistency here is curious. Is there a reason why this
> >>> branch has "repo" on the end and none of the others don't?
> >>>
> >>
> >> No specific reason, it started like that in the past. If the consensus
> >> is to go with 'for-main', I can update it.
> >>
> > In all likelihood it's not a big deal.
> >
> > I'm just thinking that for any future automation or tracking, having a
> very
> > consistent naming would be best. For example, in the one-liner I posted
> for
> > generating the graph showing the inter-tree flow, I needed a special
> regex
> > to strip off the "-repo", so that we didn't have a separate target called
> > "main-repo" and another called "main".
> >
>
> Agree on above, created 'for-main' branch and will use it now.
>
> But I need help from Thomas/David to delete remote 'for-main-repo' branch.
>
> Great. So for CI testing, we will use dpdk-*-for-main when possible.
next-virtio only has for-next-net and staging, so we will use for-next-net,
unless we want to rename that one too to have a true standard.

For staging branches, Based on TB voting I did add a work item to the 2024
lab SOW for "on-push" staging branch testing, which we will do via these
GitHub branches (so like, next-virtio-staging).

Thanks!

[-- Attachment #2: Type: text/html, Size: 4838 bytes --]

Re: [PATCH] version: 24.03-rc0

[Bruce Richardson]

On Fri, Dec 01, 2023 at 12:24:12PM -0500, Patrick Robb wrote:
>    On Fri, Dec 1, 2023 at 11:36 AM Ferruh Yigit <[1]ferruh.yigit@amd.com>
>    wrote:
> 
>      On 12/1/2023 2:30 PM, Bruce Richardson wrote:
>      > On Fri, Dec 01, 2023 at 11:33:25AM +0000, Ferruh Yigit wrote:
>      >> On 12/1/2023 11:13 AM, Bruce Richardson wrote:
>      >>> On Fri, Dec 01, 2023 at 09:04:10AM +0100, Thomas Monjalon wrote:
>      >>>> 30/11/2023 19:33, Patrick Robb:
>      >>>>> On Thu, Nov 30, 2023 at 4:24 AM David Marchand
>      <[2]david.marchand@redhat.com>
>      >>>>> wrote:
>      >>>>>
>      >>>>>> What it means:
>      >>>>>> - for the [3]https://dpdk.org/git/dpdk repository, all the
>      branches and
>      >>>>>> tags are mirrored to [4]https://github.com/DPDK/dpdk as it
>      was done so
>      >>>>>> far,
>      >>>>>> - for the [5]https://git.dpdk.org/next/dpdk-next-*
>      repositories, only
>      >>>>>> branches named "main", "staging" or "for-*" are mirrored to
>      >>>>>> [6]https://github.com/DPDK/dpdk with a prefix.
>      >>>>>
>      >>>>> Thank you David for clearing some of this up on the CI testing
>      meeting. I
>      >>>>> think the final loose end was you were wondering which
>      branches within the
>      >>>>> next-* repos we were running from. I'll paste that below:
>      >>>>>
>      >>>>> dpdk-next-crypto: for-main
>      >>>>> dpdk-next-eventdev: for-main
>      >>>>> dpdk-next-net: main
>      >>>>> dpdk-next-net-brcm: main
>      >>>>> dpdk-next-net-intel: main
>      >>>>> dpdk-next-net-mlx: main
>      >>>>> dpdk-next-net-mrvl: for-next-net
>      >>>>> dpdk-next-virtio: main
>      >>>>> dpdk-next-baseband: for-main
>      >>>>
>      >>>> We should test patches on top of the branch which is validated
>      >>>> by the tree maintainer and ready to pull.
>      >>>> This is the default branch (HEAD) of its repository on
>      [7]dpdk.org.
>      >>>> This is the list of equivalent GitHub branches to use for
>      testing:
>      >>>>
>      >>>>    main
>      >>>>    next-baseband-for-main
>      >>>>    next-crypto-for-main
>      >>>>    next-eventdev-for-main
>      >>>>    next-net-for-main-repo
>      >>>
>      >>> The (slight) inconsistency here is curious. Is there a reason
>      why this
>      >>> branch has "repo" on the end and none of the others don't?
>      >>>
>      >>
>      >> No specific reason, it started like that in the past. If the
>      consensus
>      >> is to go with 'for-main', I can update it.
>      >>
>      > In all likelihood it's not a big deal.
>      >
>      > I'm just thinking that for any future automation or tracking,
>      having a very
>      > consistent naming would be best. For example, in the one-liner I
>      posted for
>      > generating the graph showing the inter-tree flow, I needed a
>      special regex
>      > to strip off the "-repo", so that we didn't have a separate target
>      called
>      > "main-repo" and another called "main".
>      >
>      Agree on above, created 'for-main' branch and will use it now.
>      But I need help from Thomas/David to delete remote 'for-main-repo'
>      branch.
> 
>    Great. So for CI testing, we will use dpdk-*-for-main when possible.
>    next-virtio only has for-next-net and staging, so we will use
>    for-next-net, unless we want to rename that one too to have a true
>    standard.

That one is correct, because next-virtio doesn't go straight to main. There
will soon similarly be next-net-intel-for-next-net, for example, for the
other sub-trees that get pulled into next-net.

/Bruce

Re: [PATCH] version: 24.03-rc0

[Thomas Monjalon]

01/12/2023 18:24, Patrick Robb:
> For staging branches, Based on TB voting I did add a work item to the 2024
> lab SOW for "on-push" staging branch testing, which we will do via these
> GitHub branches (so like, next-virtio-staging).

Not sure about testing staging branches for next-*.
Each patch is already tested individually.
Then the ready branch for-* is tested again regularly.
I think the staging branch is more for manual testing.
There is also GitHub Actions doing an automatic test.
Instead of "on-push" testing, we could propose a manual trigger
if we want to avoid overloading the lab during critical release times.

Re: [PATCH] version: 24.03-rc0

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

On Fri, Dec 1, 2023 at 4:09 PM Thomas Monjalon <thomas@monjalon.net> wrote:

> 01/12/2023 18:24, Patrick Robb:
> > For staging branches, Based on TB voting I did add a work item to the
> 2024
> > lab SOW for "on-push" staging branch testing, which we will do via these
> > GitHub branches (so like, next-virtio-staging).
>
> Not sure about testing staging branches for next-*.
> Each patch is already tested individually.
> Then the ready branch for-* is tested again regularly.
> I think the staging branch is more for manual testing.
> There is also GitHub Actions doing an automatic test.
> Instead of "on-push" testing, we could propose a manual trigger
> if we want to avoid overloading the lab during critical release times.
>
>
> Okay. I will leave it until Monday for any sub-tree maintainers to chime
in if they disagree. Otherwise, I will remove the staging branch testing
work item, and add in a work item for adding a manual trigger. Thanks.

[-- Attachment #2: Type: text/html, Size: 1344 bytes --]

Re: [PATCH] version: 24.03-rc0

[David Marchand]

Hello maintainers,

On Thu, Nov 30, 2023 at 10:23 AM David Marchand
<david.marchand@redhat.com> wrote:
> For subtree maintainers.
>
> It should change nothing to you guys.
> Please rebase your trees on v24.03-rc0 and push it to dpdk.org.
> And then double check that the mirror happened (looking at git push
> output, and checking https://github.com/DPDK/dpdk/branches).
> If you hit some issue, ping me.

We are still missing the next-net-brcm mirror, but thanks to all for
rebasing your branches.

A special note: with this mirroring in place, you get automatic
testing in GHA when you push to your branches.
You won't get a notification when the tests are done though.
You will need to check manually by looking at
https://github.com/DPDK/dpdk/actions.


-- 
David Marchand