From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52569A0524; Thu, 4 Feb 2021 14:43:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD3622406FF; Thu, 4 Feb 2021 14:43:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id CBCEC2406EE for ; Thu, 4 Feb 2021 14:43:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612446196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2IuoaSTiDeo9Y7N/f6a93APluHG6lzCGuw7qGFSCuCg=; b=E3GmoFeFLF3hDJUs89LCRyy12VFGH2l6SyzpjFMmyGXmFztTGUVDrB9vfCgJV0TkDr7J2J zxrh8jXZW/i014sFvNGyr9g4C0wx1cTsPM9Dt2IdLtamTuGxJCArQqXflej6olfBWjhQza YgrYbAYaIA19SkpKAA34tAs08rZHU7k= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-362-N0i-Y2bUMrOBYBvjPKcN1w-1; Thu, 04 Feb 2021 08:43:15 -0500 X-MC-Unique: N0i-Y2bUMrOBYBvjPKcN1w-1 Received: by mail-vk1-f199.google.com with SMTP id y186so907523vkc.15 for ; Thu, 04 Feb 2021 05:43:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2IuoaSTiDeo9Y7N/f6a93APluHG6lzCGuw7qGFSCuCg=; b=klxpYJqr9jY+PyHAFedmoT5HxKJ8DO9IdG/bw1f0X1DIsugMGiojHLpbGSPJbdO+dz ILOEk+38aTvXMlaRlodePGeJg2L6xmlIlhOIT5U7Oa9L7sMR+PXlA4OmQknns6XzUSQ/ 5GJKLys5KLd79+TS56sdoqF82pw8Vyr0uZVQUYXsJD6/6nFDwEM1+/6fh3LME+8b5atq V7ikBhIT9aZyH/GNqzT9YNgO1DQID9xOJDog0jdbzZMv2gxfStnYxYjGSuAj1KjTPYax U4nExqFxA8trs7ey00+jOVvjFDZ4PFiVH39/bmGhjo1VIehfOqabFF/6b8bDwmvQwh6b 4jWA== X-Gm-Message-State: AOAM5300kgislN3di8P3sQnyPIxsH9MPw3nD8j50uwdjhJMstzKqtbuT BVapLiP3BTp4Gz8cYAUYa1xBokCkoMEIvhWcLAXSlQazC7w3xQzBIuhy7f0S6fSzb4EPmpymu0q H/fvcFrSZLKcLBcpXqb4= X-Received: by 2002:ab0:7087:: with SMTP id m7mr5242788ual.53.1612446194858; Thu, 04 Feb 2021 05:43:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJzdrwpZQTy8J50KFEukqzzS2ZgSrftPIuVriBokXClxH7WJjHFiH+YUY0Q4Yb3zJEAIcV5HhGKXpAa8KQ3COkA= X-Received: by 2002:ab0:7087:: with SMTP id m7mr5242776ual.53.1612446194677; Thu, 04 Feb 2021 05:43:14 -0800 (PST) MIME-Version: 1.0 References: <20210202090639.83164-1-leyi.rong@intel.com> <20210202143258.108477-1-leyi.rong@intel.com> <20210203020758.12cd8089@sovereign> <5ec7623cbb604753bb70fa9f4b0a7c3a@intel.com> In-Reply-To: From: David Marchand Date: Thu, 4 Feb 2021 14:43:03 +0100 Message-ID: To: Ferruh Yigit Cc: "Zhang, Qi Z" , Dmitry Kozlyuk , "Rong, Leyi" , "thomas@monjalon.net" , "Richardson, Bruce" , "talshn@nvidia.com" , "Kadam, Pallavi" , "Menon, Ranjit" , "Xing, Beilei" , "aconole@redhat.com" , "dev@dpdk.org" , "ci@dpdk.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 4, 2021 at 1:36 PM Ferruh Yigit wrote: > > On 2/4/2021 10:41 AM, Zhang, Qi Z wrote: > > > > > >> -----Original Message----- > >> From: Dmitry Kozlyuk > >> Sent: Wednesday, February 3, 2021 7:08 AM > >> To: Rong, Leyi > >> Cc: david.marchand@redhat.com; Zhang, Qi Z ; Yigit, > >> Ferruh ; thomas@monjalon.net; Richardson, Bruce > >> ; talshn@nvidia.com; Kadam, Pallavi > >> ; Menon, Ranjit ; Xing, > >> Beilei ; aconole@redhat.com; dev@dpdk.org; > >> ci@dpdk.org > >> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW > >> > >> On Tue, 2 Feb 2021 22:32:58 +0800, Leyi Rong wrote: > >>> Adds extra cflags '-fno-asynchronous-unwind-tables' > >>> to avoid the MinGW build error: > >>> Error: invalid register for .seh_savexmm > >>> > >>> Fixes: 5c38c33f7880 ("net/i40e: disable AVX512 with MinGW") > >>> > >>> Signed-off-by: Leyi Rong > >> > >> Tested-by: Dmitry Kozlyuk > >> > >> Re: -fno-asynchronous-unwind-tables, when cross-compiling from Linux, I > >> observe bit-to-bit identical i40e_rxtx_vec_avx512.c.obj. My guess it that this > >> option somehow affects GCC inlining heuristics. Similar issue existed in > >> librte_acl (at least a year ago win GCC 6, I believe), where GCC generated > >> incorrect code unless certain functions had been inlined (caught by test app). > >> No an AVX expert, just my 2c. > > > > Applied to dpdk-next-net-intel. > > > > Hi Thomas, David, > > Do you prefer to get this directly to the main repo, since it is fixing the > windows build? I have no issue with the main branch for mingw. The windows builds at UNH seem unavailable, so we can wait for the next-net merge. -- David Marchand