From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DBCDBA0542;
	Mon, 29 Aug 2022 10:12:37 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A3D964069D;
	Mon, 29 Aug 2022 10:12:36 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mails.dpdk.org (Postfix) with ESMTP id 6A5E940694
 for <dev@dpdk.org>; Mon, 29 Aug 2022 10:12:34 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1661760753;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=gri1TUSQV3Wv7znzG8PrryfyzZ/cwFwxAMcm10+BalU=;
 b=Fxt9VxmfwzPAn7fZbq/+KJ71sTAmt1JjK3LEl+Sw4tnR9Z9cmdgXvvBooZJnxWUemR2KkB
 yTTBUlrCAp9RCmXhq8IZCxdjc0huEa5PLM1oz7NTUACi5jdscWeFVVjMqYr5zd25WpxEEo
 /TxIVxjypfITxCDHEFjYXqQdpmevTCE=
Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com
 [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-98-UvnWxLkvMCi3CrsAv4edMA-1; Mon, 29 Aug 2022 04:12:32 -0400
X-MC-Unique: UvnWxLkvMCi3CrsAv4edMA-1
Received: by mail-lj1-f199.google.com with SMTP id
 e1-20020a2e9841000000b002602ebb584fso1685197ljj.14
 for <dev@dpdk.org>; Mon, 29 Aug 2022 01:12:31 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc;
 bh=gri1TUSQV3Wv7znzG8PrryfyzZ/cwFwxAMcm10+BalU=;
 b=Ay4QzkY51ZndmA3dpXmNLBmvPRT4Ma13EXNJABcMGyS70iXZEcpqyYxF13QanJT/Mp
 yIUPHFzayUfu2sz3F4luPyb2DOvnBVfIt7t7kzNo1Tx4Yf+m81IPzCCMrLrrIRtMKFMs
 vAp8HZrzorcEn3fa8ep7ndTk5kg6bq6W5oPb5NURqX9J9/ImRXiq4yG/QTnLPuEUeq4N
 uvwoqiuVU7ZzsQ6xi6Lu31FVKEk/y2fC1sWOfAkU8P9BifIyvSczq3kgasT53sX/zMIk
 fTCdLb/Cfcjh0GFjYZuKxNhsBO2Q0qKGLTNZpxkyggEzRQEZ75LGsEsAkhJ0HzW1cjLY
 wXKA==
X-Gm-Message-State: ACgBeo0ZW1BZDp4SdJZ0k3Wr/fqrJLxnVKb+Lj6L0f/OT4Lk6MDW7tdT
 x43/gjVLyLcz+x4DfLet6TckZ4o+dhQi+nJk9IEr6e9IFLDdwZBaQRbunI9cmbS+t15/HeaPzqH
 U8Zb0kEBQWVq0Rm5+IQc=
X-Received: by 2002:a05:651c:19a8:b0:261:e043:3960 with SMTP id
 bx40-20020a05651c19a800b00261e0433960mr5596638ljb.81.1661760750730; 
 Mon, 29 Aug 2022 01:12:30 -0700 (PDT)
X-Google-Smtp-Source: AA6agR75OLxP++xYx6XYF/r8kSE54oF4gWVpOrLpvnuub8sdMIoLjVx0z0F5Gg0mCjLOD2YqgZ5lyOudOKEFTBKKrGI=
X-Received: by 2002:a05:651c:19a8:b0:261:e043:3960 with SMTP id
 bx40-20020a05651c19a800b00261e0433960mr5596618ljb.81.1661760750483; Mon, 29
 Aug 2022 01:12:30 -0700 (PDT)
MIME-Version: 1.0
References: <20220628144643.1213026-1-david.marchand@redhat.com>
 <20220826124208.671400-1-david.marchand@redhat.com>
 <20220826124208.671400-18-david.marchand@redhat.com>
 <AS8PR08MB70801639FD5A68BDC7B808959E769@AS8PR08MB7080.eurprd08.prod.outlook.com>
In-Reply-To: <AS8PR08MB70801639FD5A68BDC7B808959E769@AS8PR08MB7080.eurprd08.prod.outlook.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 29 Aug 2022 10:12:18 +0200
Message-ID: <CAJFAV8zaJY8gndhEVGREXZ+0x54NmfpEiv6u+d=nOi9ZT84DvQ@mail.gmail.com>
Subject: Re: [PATCH v4 17/27] bus/vdev: make driver-only headers private
To: Ruifeng Wang <Ruifeng.Wang@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 Rosen Xu <rosen.xu@intel.com>, Gagandeep Singh <g.singh@nxp.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, 
 Nicolas Chautru <nicolas.chautru@intel.com>, Ray Kinsella <mdr@ashroe.eu>,
 Lee Daly <lee.daly@intel.com>, 
 Fan Zhang <roy.fan.zhang@intel.com>, Ashish Gupta <ashish.gupta@marvell.com>, 
 Sunila Sahu <ssahu@marvell.com>, 
 "Ajit Khaparde (ajit.khaparde@broadcom.com)" <ajit.khaparde@broadcom.com>, 
 Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,
 Vikas Gupta <vikas.gupta@broadcom.com>, 
 Chandubabu Namburu <chandu@amd.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>, 
 Michael Shamis <michaelsh@marvell.com>, Liron Himi <lironh@marvell.com>, 
 Chengwen Feng <fengchengwen@huawei.com>, Kevin Laatz <kevin.laatz@intel.com>, 
 Sachin Saxena <sachin.saxena@oss.nxp.com>,
 "jerinj@marvell.com" <jerinj@marvell.com>, 
 Liang Ma <liangma@liangbit.com>, Peter Mccarthy <peter.mccarthy@intel.com>, 
 Harry van Haaren <harry.van.haaren@intel.com>,
 "John W. Linville" <linville@tuxdriver.com>, 
 Ciara Loftus <ciara.loftus@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, 
 Chas Williams <chas3@att.com>, "Min Hu (Connor)" <humin29@huawei.com>,
 Gaetan Rivet <grive@u256.net>, 
 Jakub Grajciar <jgrajcia@cisco.com>, Zyta Szpak <zr@semihalf.com>, 
 Tetsuya Mukawa <mtetsuyah@gmail.com>, Harman Kalra <hkalra@marvell.com>, 
 Jasvinder Singh <jasvinder.singh@intel.com>, 
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Matan Azrad <matan@nvidia.com>, 
 Maxime Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com>,
 Jakub Palider <jpalider@marvell.com>, Tomasz Duszynski <tduszynski@marvell.com>,
 Tianfei zhang <tianfei.zhang@intel.com>, Ferruh Yigit <ferruh.yigit@xilinx.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, nd <nd@arm.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Aug 29, 2022 at 9:18 AM Ruifeng Wang <Ruifeng.Wang@arm.com> wrote:
> > diff --git a/app/test/test_vdev.c b/app/test/test_vdev.c index 5eeff3106d..3cc3abe70b
> > 100644
> > --- a/app/test/test_vdev.c
> > +++ b/app/test/test_vdev.c
> > @@ -9,7 +9,7 @@
> >  #include <rte_common.h>
> >  #include <rte_kvargs.h>
> >  #include <rte_bus.h>
> > -#include <rte_bus_vdev.h>
> > +#include <bus_vdev_driver.h>
> This line of change is unnecessary? Application uses rte header.

This unit test looks into rte_bus objects (you'll notice a change
later in the series for including bus_driver.h) but, here, it only
uses "standard" API for the rest.
I'll fix this include, in next revision.


> The rest looks good to me.
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Thanks Ruifeng.


-- 
David Marchand