* [dpdk-dev] [PATCH] config/ppc: fix meson build failure with gcc 4.8.5 on RHEL/CENTOS7
@ 2021-11-03 20:01 David Christensen
2021-11-04 8:10 ` David Marchand
0 siblings, 1 reply; 2+ messages in thread
From: David Christensen @ 2021-11-03 20:01 UTC (permalink / raw)
To: dev; +Cc: thinhtr, David Christensen
The POWER meson.build file incorrectly checks if the detected CPU is
"greater than" POWER8 when it should actually test for "greater than or
equal to" POWER8. Fixed the comparison operator.
Bugzilla ID: 875
Fixes: 750196880843 ("config/ppc: select instruction set for IBM Power10")
Cc: thinhtr@linux.vnet.ibm.com
Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
---
config/ppc/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/ppc/meson.build b/config/ppc/meson.build
index cba8222163..1cba44011f 100644
--- a/config/ppc/meson.build
+++ b/config/ppc/meson.build
@@ -89,7 +89,7 @@ int main() {
else
error('Compiler does not support POWER@0@ platform'.format(cpu))
endif
- if cpu > 8
+ if cpu >= 8
cpu_instruction_set = 'power'+cpu.to_string()
else
error('Compiler does not support POWER@0@ platform'.format(cpu))
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] config/ppc: fix meson build failure with gcc 4.8.5 on RHEL/CENTOS7
2021-11-03 20:01 [dpdk-dev] [PATCH] config/ppc: fix meson build failure with gcc 4.8.5 on RHEL/CENTOS7 David Christensen
@ 2021-11-04 8:10 ` David Marchand
0 siblings, 0 replies; 2+ messages in thread
From: David Marchand @ 2021-11-04 8:10 UTC (permalink / raw)
To: David Christensen; +Cc: dev, Thinh Tran
On Wed, Nov 3, 2021 at 9:01 PM David Christensen <drc@linux.vnet.ibm.com> wrote:
>
> The POWER meson.build file incorrectly checks if the detected CPU is
> "greater than" POWER8 when it should actually test for "greater than or
> equal to" POWER8. Fixed the comparison operator.
>
> Bugzilla ID: 875
> Fixes: 750196880843 ("config/ppc: select instruction set for IBM Power10")
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-04 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03 20:01 [dpdk-dev] [PATCH] config/ppc: fix meson build failure with gcc 4.8.5 on RHEL/CENTOS7 David Christensen
2021-11-04 8:10 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).