From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] checkpatch: suppress fallthrough warning
Date: Fri, 25 Sep 2020 18:41:40 +0200 [thread overview]
Message-ID: <CAJFAV8za_UsQFsuAfPPO7E0nGURqnMH_QKrpbG-=hYJjLW4VSA@mail.gmail.com> (raw)
In-Reply-To: <20200925161345.23209-1-stephen@networkplumber.org>
On Fri, Sep 25, 2020 at 6:14 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The DPDK does not have (or want to use) the same fallthrough
> wrapper as the Linux kernel. Therefore silence the warning.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> devtools/checkpatches.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index 78a408ef9823..923ff6f7d9ee 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
> PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\
^^
This token is already set here.
Is there an issue with this?
> SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
> LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> -NEW_TYPEDEFS,COMPARISON_TO_NULL"
> +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH"
> options="$options $DPDK_CHECKPATCH_OPTIONS"
>
> print_usage () {
> --
> 2.27.0
>
--
David Marchand
next prev parent reply other threads:[~2020-09-25 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 16:13 Stephen Hemminger
2020-09-25 16:41 ` David Marchand [this message]
2020-09-25 17:13 ` Stephen Hemminger
2020-09-26 8:47 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8za_UsQFsuAfPPO7E0nGURqnMH_QKrpbG-=hYJjLW4VSA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).