Re: [dpdk-dev] [PATCH 1/6] baseband: introduce NXP LA12xx driver

[David Marchand <david.marchand@redhat.com>]

On Thu, Mar 18, 2021 at 7:38 AM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> This patch introduce the baseband device drivers for NXP's
> LA1200 series software defined baseband modem.

Such a series deserves a cover letter.
You should copy bbdev maintainer and cryptodev subtree maintainer.

Quickly looked at the series, I see no change on the bbdev unit test code.
Are those tests running fine with no modification (I sure hope so, but
I want a confirmation).


>
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  drivers/baseband/la12xx/bbdev_la12xx.c        | 110 ++++++++++++++++++
>  .../baseband/la12xx/bbdev_la12xx_pmd_logs.h   |  38 ++++++
>  drivers/baseband/la12xx/meson.build           |   6 +
>  drivers/baseband/la12xx/version.map           |   3 +
>  drivers/baseband/meson.build                  |   2 +-
>  5 files changed, 158 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/baseband/la12xx/bbdev_la12xx.c
>  create mode 100644 drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h
>  create mode 100644 drivers/baseband/la12xx/meson.build
>  create mode 100644 drivers/baseband/la12xx/version.map
>

[snip]

> +};
> +
> +RTE_PMD_REGISTER_VDEV(DRIVER_NAME, bbdev_la12xx_pmd_drv);
> +RTE_PMD_REGISTER_ALIAS(DRIVER_NAME, bbdev_la12xx);

Quick glance at this patch, no need for an alias.
Alias are for maintaining compatibility when drivers are renamed but
this is a new driver.


-- 
David Marchand