From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 047F8A0561; Thu, 18 Mar 2021 15:53:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A9A5406B4; Thu, 18 Mar 2021 15:53:40 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 8073940698 for ; Thu, 18 Mar 2021 15:53:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616079218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2UouAizb8rhQWdz1wVA1ylDGsRZNf0VRfRQrwcOVs/Y=; b=OK9I0EnGOCvSCpfMtMFJcFLP7AEPCOL0tnNFDR/SFh53M14EHp8zrNYELvATzdc/MbYuIw NuWDTdpFMianF5t5TIeXIjE6vph+5PsGw8zBWIP/cUN3+tQj+Ue5khkUNcVLW1rsW4gkYg aDubnY4M7CBGyW94A/quvLD62FzVzCg= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-309-PVHOaW8wP4mLwTwzC7_UpQ-1; Thu, 18 Mar 2021 10:53:36 -0400 X-MC-Unique: PVHOaW8wP4mLwTwzC7_UpQ-1 Received: by mail-vs1-f70.google.com with SMTP id q1so5212785vsa.6 for ; Thu, 18 Mar 2021 07:53:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2UouAizb8rhQWdz1wVA1ylDGsRZNf0VRfRQrwcOVs/Y=; b=q7KFN3SFa4AZiblZzGwJTOkXfHjU8N4isnmoipZxmjziPuYAf8vPT1wmKAUpS5azhS F2ACSQQj0zgnBEbXC5N6MceUQdQyvhhPUtOWDex2yBnT/YShBg5jtlqNo/bFDuYpIXSa mYJLHMdxVlLn5rOSfN/lD3V3c8gPCRrRWwAycKYrBQXhzidk4A/pLb1brPekdppSTZsz BtekkphRDHbt3sXNhEyn2cJZ6rBXcnKxQZ9X2h11ozD/61urCApdG54OadNzSh8M4wEA 86fGhyjB4YhT4Q0vFLBPz6AlFunCxU+JI07SsVn9SC43SFkGtqk+Qxmz3RyZ2aOprJ7B biSw== X-Gm-Message-State: AOAM532fFdzhBRrOttDjZvCfG+k9kq07gZgWrCmzn5vY3lDwkyxg+z4G NNbD46EKfUKQnmtdedOX+hz/aNJeOICPfdCUDuFNk2yqa+1PxPZELsflSxf5GSlUB7fZ+oxaZ0A xOUXEjz0zeSpsGxeeDuY= X-Received: by 2002:a1f:9895:: with SMTP id a143mr6280704vke.20.1616079216052; Thu, 18 Mar 2021 07:53:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCQItCWRzGTh1l+lYkVIVQnSNpqzg3LCC0bDTV32/JH3RoqZfyvOI/hN3RMsAAllTQkoQZsVigOYJIKLaywyk= X-Received: by 2002:a1f:9895:: with SMTP id a143mr6280687vke.20.1616079215777; Thu, 18 Mar 2021 07:53:35 -0700 (PDT) MIME-Version: 1.0 References: <20210318063421.14895-1-hemant.agrawal@nxp.com> In-Reply-To: <20210318063421.14895-1-hemant.agrawal@nxp.com> From: David Marchand Date: Thu, 18 Mar 2021 15:53:24 +0100 Message-ID: To: Hemant Agrawal Cc: dev , Nipun Gupta , Nicolas Chautru , Akhil Goyal Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/6] baseband: introduce NXP LA12xx driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 18, 2021 at 7:38 AM Hemant Agrawal wrote: > > This patch introduce the baseband device drivers for NXP's > LA1200 series software defined baseband modem. Such a series deserves a cover letter. You should copy bbdev maintainer and cryptodev subtree maintainer. Quickly looked at the series, I see no change on the bbdev unit test code. Are those tests running fine with no modification (I sure hope so, but I want a confirmation). > > Signed-off-by: Nipun Gupta > Signed-off-by: Hemant Agrawal > --- > drivers/baseband/la12xx/bbdev_la12xx.c | 110 ++++++++++++++++++ > .../baseband/la12xx/bbdev_la12xx_pmd_logs.h | 38 ++++++ > drivers/baseband/la12xx/meson.build | 6 + > drivers/baseband/la12xx/version.map | 3 + > drivers/baseband/meson.build | 2 +- > 5 files changed, 158 insertions(+), 1 deletion(-) > create mode 100644 drivers/baseband/la12xx/bbdev_la12xx.c > create mode 100644 drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h > create mode 100644 drivers/baseband/la12xx/meson.build > create mode 100644 drivers/baseband/la12xx/version.map > [snip] > +}; > + > +RTE_PMD_REGISTER_VDEV(DRIVER_NAME, bbdev_la12xx_pmd_drv); > +RTE_PMD_REGISTER_ALIAS(DRIVER_NAME, bbdev_la12xx); Quick glance at this patch, no need for an alias. Alias are for maintaining compatibility when drivers are renamed but this is a new driver. -- David Marchand