From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C06742FA8; Mon, 31 Jul 2023 18:22:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0259D4161A; Mon, 31 Jul 2023 18:22:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 882B94067B for ; Mon, 31 Jul 2023 18:22:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690820574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TBlegUCpiAA5H9+IAEBaSDP7SCs/fBdf8Ei6pjnEkaA=; b=E/YQx2yG4xDLTkGIWJDADlQd7nh372tvslm6LLZYVY7HremXvSumINulOS7GhMdzGGZh5g n26HxNDnyseDawtxqJgYWzbcRiY3V2z6TpRNqmxGhc+64ggcX+Ty2GWweXFM/rst3EXm8g E1Fn7/tn319WCOeMTlOphxZRjfb9Qnc= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-e8g9-yKjOu6lj_h8pswm2g-1; Mon, 31 Jul 2023 12:22:52 -0400 X-MC-Unique: e8g9-yKjOu6lj_h8pswm2g-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-267f18688efso4647450a91.1 for ; Mon, 31 Jul 2023 09:22:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690820571; x=1691425371; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TBlegUCpiAA5H9+IAEBaSDP7SCs/fBdf8Ei6pjnEkaA=; b=izBHkoqDY1/5xgb0Js4keGVipw6zprZMoLdwpJN+4/hbydV3zQH9zuZ2jwS6qrdmk1 xWn+OG53W/ZBCOPP4nqFM3aiPH/Tj1yqGX2bJskXFRTMBLnm2Zf/AbeVkumgBhCIZxDV qGvhLdNlDG+D2lUyQ1BpzLw55vK90WbVez4ZNumHs6H4AF4MJVVKria56QLVyimXdUxI zDI2S68qqAcr+65dgOUbpc6Uh7/K3Ga1oK02f8XloOfVqeOpgnF/QmyRvt4jL/u1OKRf KaxS8xApctlrrn+qZI328/QI+7rEE08s+kyJKdoMbTExjSLytAFb+NRW8QDLeHZsHxKG HqQA== X-Gm-Message-State: ABy/qLZNjevjKMhAQ5c1PzYHbWSh46Oos6M8faOQdMNqhR7hPDhIW9Au 7lITLDsP/BPuaQh2B4l/6UmuwKotaT76zuLw69bSovx4e2fhYNC7R9BM1a18AZxJIfc8Fr6QGzA RlrcefiTK8KCtuh/0DzE= X-Received: by 2002:a17:90a:c392:b0:262:fb5d:147b with SMTP id h18-20020a17090ac39200b00262fb5d147bmr9599211pjt.19.1690820571726; Mon, 31 Jul 2023 09:22:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlGpSaAhGlAaqHqyK8lv9L4CWGlYp+ArPwHcJKrLpjs0mmmSqTjP7FT8Abu8fqAHsFHfTNSQ3wRbUEz3tcPEQYI= X-Received: by 2002:a17:90a:c392:b0:262:fb5d:147b with SMTP id h18-20020a17090ac39200b00262fb5d147bmr9599193pjt.19.1690820571416; Mon, 31 Jul 2023 09:22:51 -0700 (PDT) MIME-Version: 1.0 References: <20220829151901.376754-1-bruce.richardson@intel.com> <20230731153902.2350026-1-bruce.richardson@intel.com> <20230731153902.2350026-3-bruce.richardson@intel.com> In-Reply-To: <20230731153902.2350026-3-bruce.richardson@intel.com> From: David Marchand Date: Mon, 31 Jul 2023 18:22:40 +0200 Message-ID: Subject: Re: [PATCH v7 2/3] log: separate logging functions out of EAL To: Bruce Richardson Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Tyler Retzlaff , ci@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 31, 2023 at 5:39=E2=80=AFPM Bruce Richardson wrote: > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in > index 1a4210b948..40f7dd2877 100644 > --- a/doc/api/doxy-api.conf.in > +++ b/doc/api/doxy-api.conf.in > @@ -52,6 +52,7 @@ INPUT =3D @TOPDIR@/doc/api/doxy-api-i= ndex.md \ > @TOPDIR@/lib/kni \ > @TOPDIR@/lib/kvargs \ > @TOPDIR@/lib/latencystats \ > + @TOPDIR@/lib/log \ > @TOPDIR@/lib/lpm \ > @TOPDIR@/lib/mbuf \ > @TOPDIR@/lib/member \ In case you are wondering about the reason.. the Intel CI reports an error on building the documentation: *Build Failed #1: OS: UB2204-64 Target: x86_64-native-linuxapp-doc FAILED: doc/api/html /usr/bin/python3 ../doc/api/generate_doxygen.py doc/api/html /usr/bin/doxygen doc/api/doxy-api.conf /root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/doc= /api/doxy-api-index.md:230: error: unable to resolve reference to 'rte_log.h' for \ref command (warning treated as error, aborting now) Traceback (most recent call last): File "/root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/= dpdk/x86_64-native-linuxapp-doc/../doc/api/generate_doxygen.py", line 13, in subprocess.run(doxygen_command, check=3DTrue, stdout=3Dout) File "/usr/lib/python3.10/subprocess.py", line 524, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['/usr/bin/doxygen', 'doc/api/doxy-api.conf']' returned non-zero exit status 1. [2772/2774] Compiling C object app/test/dpdk-test.p/test_ring.c.o [2773/2774] Generating doc/guides/html_guides with a custom command ninja: build stopped IIRC Intel CI excludes changes on the doc/ directory when applying patches. http://inbox.dpdk.org/dev/CY5PR11MB618735108D3E9D90C67EEF96F5DA9@CY5PR11MB6= 187.namprd11.prod.outlook.com/ .. which seems to match the failure reported here, as doxygen would fail to find rte_log.h. --=20 David Marchand