From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73CAEA09E0; Fri, 13 Nov 2020 15:15:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 52933C882; Fri, 13 Nov 2020 15:15:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id B1783C87C for ; Fri, 13 Nov 2020 15:15:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605276922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zee8GuvTVxBIqj0QtxsMN4dnzxijIGRLxS0jKdd62+4=; b=BogEhP5sz9cgHyR9uAhSY6bTxuhpetThrJh4CEHmQdsCo0KDR8LvV96KIqy+Fk/nUdM8do bATkGmCMdYX0TwQae0OqC3Q9HXCF5sQAsS02rODyJlYYi4Adep3U2hv1LYYr8FYRnu9+Cy KBJsw1aEoUX18YrTOXPjU90S+klOFS4= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-Is43CW1uOTaKgYmJDHY1Ag-1; Fri, 13 Nov 2020 09:15:20 -0500 X-MC-Unique: Is43CW1uOTaKgYmJDHY1Ag-1 Received: by mail-vs1-f71.google.com with SMTP id s6so2807751vsl.5 for ; Fri, 13 Nov 2020 06:15:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zee8GuvTVxBIqj0QtxsMN4dnzxijIGRLxS0jKdd62+4=; b=Swk1ObojUPEQreNn7AJUq0v3xnAWk3zFlkse+oH2ZwYQe1TJwdLxVtMbL0gMd8mCgU xBodQkgf3+Vo66fz1dL0fFF5sq2n+nLbPPegCWvHDy5UtvYnZiGktpCEXh9UQdYMtMZP GSIjuDQJfk1iz9ifX4ZQeL5p2hSgiFQGT+IDf7zz1KXZaPtC5lWiPk56FVGfY9Nq09gl 6oT/BU9VMoNzp/LXH13DSIRVIadtVy/z+exNedV2AT3nrWBcmTOvsLMEr4iTuRGamjCU DKYEc9t6ZQLm8ZGe58uLL1hR+8OBl14JqGu98YF0SLfet72ILyCadiwgE4sv13S9NFrE J7Cg== X-Gm-Message-State: AOAM531VHjMNO3Jl5982jol2zn8JGH/36FGmAVQ+jzDtr+QVzVJiZ+ke Ahr3EMJ7WpSJmh3iorOxkitJdf5ETke+IHDDcv3Yt9xM3HEfF9T9yABNq3olYZqbMWR4ORbv3/2 0yLMXuu4cQL59PMal378= X-Received: by 2002:a05:6102:2362:: with SMTP id o2mr1274157vsa.5.1605276920085; Fri, 13 Nov 2020 06:15:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0okUSK84+UFu7KlygpmZpHgM6DkmkxA+LOaMLKAqgxiI6vDa0bN50eNqt89Tjm6olEGTfhba4mbODr/RLIQE= X-Received: by 2002:a05:6102:2362:: with SMTP id o2mr1274127vsa.5.1605276919879; Fri, 13 Nov 2020 06:15:19 -0800 (PST) MIME-Version: 1.0 References: <20201110151219.4893-1-david.marchand@redhat.com> <20201113122430.25354-1-david.marchand@redhat.com> <20201113122430.25354-5-david.marchand@redhat.com> <20201113135314.GB53@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201113135314.GB53@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Fri, 13 Nov 2020 15:15:08 +0100 Message-ID: To: Bruce Richardson Cc: dev , Thomas Monjalon , Declan Doherty , Pablo de Lara , Akhil Goyal , Fiona Trahe , Fan Zhang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 04/11] examples/l2fwd-crypto: fix build with pkg-config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 13, 2020 at 2:53 PM Bruce Richardson wrote: > > +NEED_CRYPTO_SCHEDULER = $(shell echo RTE_CRYPTO_SCHEDULER | $(CPP) $(CFLAGS) -P - | tail -1) > > +ifeq ($(NEED_CRYPTO_SCHEDULER), 1) > > Sorry for the last-minute comment, but I wonder for this check if we can do > better by adding into each makefile something like: > > CONFIG_DEFINES=$(shell $(CC) $(CFLAGS) -dM -E - < /dev/null) > > Then we can easily do multiple checks for vars as needed using findstring, > e.g. > > ifeq ($(findstring RTE_CRYPTO_SCHEDULER,$(CONFIG_DEFINES),) > $(info No crypto scheduler found) > else > ... > endif > > Whatever approach we use here, I'd like applicable across all makefiles for > consistency, and shelling out per-value seems wasteful. Pulling all macro > values also allows checks for architecture and instruction set levels too, > if so desired. I'll have a try.. -- David Marchand