From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49A2EA0C41; Thu, 30 Sep 2021 10:25:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1681410EA; Thu, 30 Sep 2021 10:25:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 5E5074067E for ; Thu, 30 Sep 2021 10:25:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632990311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TWK2KMj1+K6SSsd8gH9nWapcVe1ZhAbI3HQGWiwvvxc=; b=YsdzFXGuqIYKu7GzuAY96II23xGSLzDtI3/4cpiv5rw5E24DrtT6Q6XAm3mB8YRrajxnMo e2l5N3kH51quQR5UxPz//mki6y8oUoB7cLsz1CwE2qEhlCDbGaUli09RV5v9GY8N+xv6Sf 4ayrWaSubbOnh85sXd/oPWY3M0zP+Ck= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-515-q9tkYcIJOhOByNvDfQ9CGQ-1; Thu, 30 Sep 2021 04:25:10 -0400 X-MC-Unique: q9tkYcIJOhOByNvDfQ9CGQ-1 Received: by mail-lf1-f69.google.com with SMTP id i40-20020a0565123e2800b003f53da59009so4885843lfv.16 for ; Thu, 30 Sep 2021 01:25:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TWK2KMj1+K6SSsd8gH9nWapcVe1ZhAbI3HQGWiwvvxc=; b=1WZuci2QVLcmi6T9ObZoWfaVnEhJhmyRuiy3qatGogV2gtgCiWTLmVrkOUuLEuLT58 pQaEJg4JCTHWJUzHbVOGkIGCJXoFKlwq0MUe30/Ml2zCO4xXZBcIJx0DHX0ttKRRJhTb yC+c6rcT3ogjVILxC+gZQ3HG/zQnLMVZQBbO0XvUe6qOy3L9c7l/bCD/01olG7VBZqT4 1EUamfG6SxfnIYXAr/c26sRUUTXPA38hpgo8oWU0H3F48ZSU7ptOtvda9LYgyCwfqOcr AdH4FicNjdouaZL6jLJEJn1havWKI0LoPTFz1zq3ive7pmKpfCK3zvy1vRIK14mCoJOb NTWw== X-Gm-Message-State: AOAM533aV2dVAjHcn41fmeFJCETdgqM4t9y10PZTj4CPgw44+M5v4P+s ctqWIqhDBkkfWI9eHTSO7PrLswDoRuxWf0MjoxXXpO3shsih6/e5Ehkz+EKDZuxZ8oKds0XvbXK n3o2tOvwLsyFJTCSDiYY= X-Received: by 2002:a2e:b707:: with SMTP id j7mr4326623ljo.297.1632990308912; Thu, 30 Sep 2021 01:25:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw610lGgaXAr6JCzY39CXyezbDJA7+C636/yTwm6gydt8HLxcBjSgHYWsPja39WmJhqYS6AYWgG/kLkfsM/tGo= X-Received: by 2002:a2e:b707:: with SMTP id j7mr4326606ljo.297.1632990308708; Thu, 30 Sep 2021 01:25:08 -0700 (PDT) MIME-Version: 1.0 References: <20210930081259.232706-1-maxime.coquelin@redhat.com> In-Reply-To: <20210930081259.232706-1-maxime.coquelin@redhat.com> From: David Marchand Date: Thu, 30 Sep 2021 10:24:56 +0200 Message-ID: To: Maxime Coquelin Cc: Olivier Matz , "Xia, Chenbo" , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: revert forcing IOVA as VA mode for virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 30, 2021 at 10:13 AM Maxime Coquelin wrote: > > This patch removes the simplification in Virtio descriptors > handling, where their buffer addresses are IOVAs for Virtio > PCI devices, and VA-only for Virtio-user devices, which > added a requirement on Virtio-user that it only supported > IOVA as VA. > > This change introduced a regression for applications using > Virtio-user and other physical PMDs that require IOVA as PA > because they don't use an IOMMU. > > This patch reverts to the old behaviour, but needed to be > reworked because of the refactoring that happened in v21.02. > > Fixes: 17043a2909bb ("net/virtio: force IOVA as VA mode for virtio-user") > Cc: stable@dpdk.org > > Reported-by: Olivier Matz > Signed-off-by: Maxime Coquelin I think you can keep: Tested-by: Olivier Matz Reviewed-by: David Marchand Thanks. -- David Marchand