From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F38F1A04C7; Fri, 18 Sep 2020 09:31:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D54261C294; Fri, 18 Sep 2020 09:31:37 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 0CEB51C21F for ; Fri, 18 Sep 2020 09:31:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600414295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WHXkDA3EIyK/YaFBL1SBh7JxVlQBS1eRY5xcJHWc/KI=; b=OCfb+CBOaaqw38940h+WDRxM7q90hjTJ7sSvYj5QfQbD2GLITPbd2M/RHg7hF7t4+hXkjF t2AmGkQ0UlkRpMxVRy8RAy7UuISPiMaPQwjdBqkBKyqiZKoUQipvtd8jJOjDDlmTgV/IGr CQAUQTggEDFfaYafTJARC3HoJ+yha1Q= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-466-7_13CPmfNBmccU2LgntkTg-1; Fri, 18 Sep 2020 03:31:31 -0400 X-MC-Unique: 7_13CPmfNBmccU2LgntkTg-1 Received: by mail-vs1-f71.google.com with SMTP id q5so1363466vsq.6 for ; Fri, 18 Sep 2020 00:31:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WHXkDA3EIyK/YaFBL1SBh7JxVlQBS1eRY5xcJHWc/KI=; b=IyInoliRI9Mh+jMiVRS3OdoWsy5Ddd2Kwd0esYaWvt/0njzU4Uxd9joP6PkJvw/zXZ R3QmQCWRBVMXp7jD/RnaiSvXcnTlGbH5vuhsp+qyQtme91mwAwzjuHSQOHThwLQdpXXI klvanEHIbQU9Fh1JtRtTlnCq1HQE5bakdtyvg16NXJqAN1WOpWPEZrg7ib+YQE0fCBAA Snmmbk4FqKCQvYXo14VBIY2d+sII/vzhv12eE1Q886db0P4/r6MW8Wx2q5juM/6k7QsL Bb/8F1YIHRalpM+wJKXiwSDu8KoulInHlp93xZo7yv3/GbneWiu+/X6M1xN4DNlZDt+r TGZA== X-Gm-Message-State: AOAM533mWhC/HZVLRNKCn7QR6Ld9gfzmG0QmpySUNh7tBE8s1aM2RDJD OCXHu6BUic9Pvdorea93+ay+94ROJKbcIAkRpkp8at2Ud2/IXtX3+VLCHNh0FhbFBa1dYgXnxlX OFzpfcqCP8XL8TdmF37o= X-Received: by 2002:a67:e2c2:: with SMTP id i2mr20337071vsm.27.1600414291246; Fri, 18 Sep 2020 00:31:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAX/hQ62PJLYOI/N1zNhAxE8aEGVV0HxLJPaZdKDTwwroKQi+W4pFz5vTovjfwlKwLW2eTX4Kn68zXJcSweOY= X-Received: by 2002:a67:e2c2:: with SMTP id i2mr20337061vsm.27.1600414290904; Fri, 18 Sep 2020 00:31:30 -0700 (PDT) MIME-Version: 1.0 References: <20200918070155.31789-1-thierry.herbelot@6wind.com> In-Reply-To: From: David Marchand Date: Fri, 18 Sep 2020 09:31:20 +0200 Message-ID: To: Somnath Kotur , Thierry Herbelot , Ajit Khaparde , "Xia, Chenbo" Cc: dev , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 18, 2020 at 9:12 AM Somnath Kotur wrote: > > On Fri, Sep 18, 2020 at 12:32 PM Thierry Herbelot > wrote: > > > > .../drivers/net/bnxt/tf_ulp/ulp_def_rules.c: In function =E2=80=98bnx= t_ulp_destroy_df_rules=E2=80=99: > > .../dpdk/drivers/net/bnxt/tf_ulp/ulp_def_rules.c:425:28: error: > > comparison is always true due to limited range of data type [-Werro= r=3Dtype-limits] > > for (port_id =3D 0; port_id < RTE_MAX_ETHPORTS; port_id++) { > > ^ > > > > Fixes: 769de16872ab9 ('net/bnxt: fix port default rule create/destroy') > > Cc: Ajit Khaparde > > Cc: Somnath Kotur > > > > Signed-off-by: Thierry Herbelot > > --- > > drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt= /tf_ulp/ulp_def_rules.c > > index 9fb1a028ff66..ff5aed3d74c4 100644 > > --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c > > +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c > > @@ -397,7 +397,7 @@ void > > bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global) > > { > > struct bnxt_ulp_df_rule_info *info; > > - uint8_t port_id; > > + uint16_t port_id; > > > > if (!BNXT_TRUFLOW_EN(bp) || > > BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev)) > > -- > > 2.27.0 > > > Acked-by: Somnath Kotur > This patch rang a bell. There is the exact same patch proposed by Xia with a comment, so I guess Xia is still working on it? https://patchwork.dpdk.org/patch/75177/#117201 --=20 David Marchand