From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com
 [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 5BC381B39D
 for <dev@dpdk.org>; Wed,  9 Jan 2019 14:47:07 +0100 (CET)
Received: by mail-ua1-f67.google.com with SMTP id d21so2415295uap.9
 for <dev@dpdk.org>; Wed, 09 Jan 2019 05:47:07 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=JsIRis8cNRcLbuAAESewoyu6O8jO6jgQsNfk1vtlWHk=;
 b=fhoy5pqbzUFf0coGeFidTKUBzUGyzqJdRtCZ9CfiVzOhEuRZsqLZxLG6N3qiONE20W
 pCQxr8+pTKf4h58vYqKe83PMZBgxeIYkfTerez2Mv98zxIo9FBwQZiywHsy0Bsvo3zk+
 TqTZxEtV2pl0Q3Z07sGl0fviMQ/Q4k/WJHeoVUOGnj5RtAw8HkivToelXM3vv1OUFAxb
 VCStTxIDBtROddJXJc1gNv5UN808yjUx5CtwCn00wGuwe9K8eYM0bzs8x5drKzV2As97
 OzeF1+G8sEGf1NPIzpwR5USOMaVjnPy9GVns4gKSyS1QsvyNTpi6cwTV5RwZqw0P6HOg
 q8xw==
X-Gm-Message-State: AJcUukdlvy4MmkVvvijlpsLjOMFb+bbf1qGQJEjnvDp+4+BplK/s2AP9
 8pO1lbtOe23UhmluOXZ1E3LafQZFBsNtpa/VLOJ0LQ==
X-Google-Smtp-Source: ALg8bN5AjWjlIs5f8zOCprUXDaK2pKQENNnFO6fUiq3eVwNCtGiukq/tIZUQFWJ0V0ECr/BTSmG/8R7buDwJAVwKFWQ=
X-Received: by 2002:ab0:3484:: with SMTP id c4mr2184088uar.39.1547041626720;
 Wed, 09 Jan 2019 05:47:06 -0800 (PST)
MIME-Version: 1.0
References: <20190109085426.39965-1-yskoh@mellanox.com>
 <20190109131908.4949-1-yskoh@mellanox.com>
In-Reply-To: <20190109131908.4949-1-yskoh@mellanox.com>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 9 Jan 2019 14:46:55 +0100
Message-ID: <CAJFAV8ze4K90-snGs0Ddj7Ff6sejgd7KY-Zw=3wHST=gcqLOVw@mail.gmail.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: Olivier Matz <olivier.matz@6wind.com>, Shahaf Shuler <shahafs@mellanox.com>,
 dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default
	buffer address
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 13:47:07 -0000

On Wed, Jan 9, 2019 at 2:19 PM Yongseok Koh <yskoh@mellanox.com> wrote:

> This patch introduces two new functions - rte_mbuf_buf_addr_default() and
> rte_mbuf_data_baddr_default().
>
> rte_mbuf_buf_addr_default() reutrns the default buffer address of given
> mbuf which comes after mbuf structure and private data.
>

The buffer address should always be the same for a given mbuf, there is no
"default" value for it, there is only one value.
So for me s/rte_mbuf_buf_addr_default/rte_mbuf_buf_addr/g.


> rte_mbuf_data_baddr_default() returns the default address of mbuf data
> taking the headroom into account.
>

Or just rte_mbuf_data_addr_default() ?


> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>

Those are new functions, they should go through the EXPERIMENTAL api
marking process.


-- 
David Marchand