From: David Marchand <david.marchand@redhat.com>
To: Gaurav Singh <gaurav1086@gmail.com>,
"Power, Ciara" <ciara.power@intel.com>
Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] lib/metrics: fix memory leak
Date: Tue, 3 Nov 2020 22:36:58 +0100 [thread overview]
Message-ID: <CAJFAV8zeCDC8j07ULQPqtYAHnOdhEFV6bV+ygJD6MuFfOR3=Bw@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8xTA4-c2oePmybfjOMwYDSy2jUZkUabW4w0+Fk3auxN5w@mail.gmail.com>
On Fri, Oct 30, 2020 at 3:59 PM David Marchand
<david.marchand@redhat.com> wrote:
> > This does fix the resource leak, but I do think it can be done in a
> > simpler way, as shown in the patch I sent to fix the logged coverity issue
> > for this: https://patchwork.dpdk.org/patch/78052/
> > I will remove my patch seeing as this patch is fixing the same thing.
>
> I agree with Ciara.
> Could you respin?
I went with Ciara patch as it is minimal and ready to be merged.
Thanks.
--
David Marchand
prev parent reply other threads:[~2020-11-03 21:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 3:45 [dpdk-dev] [PATCH] librte_metrics: " Gaurav Singh
2020-07-31 4:54 ` Honnappa Nagarahalli
2020-08-01 1:46 ` Gaurav Singh
2020-08-01 6:08 ` Gaurav Singh
2020-08-01 23:34 ` Honnappa Nagarahalli
2020-08-08 16:39 ` [dpdk-dev] [PATCH] lib/metrics: " Gaurav Singh
2020-08-11 21:01 ` Honnappa Nagarahalli
2020-09-22 10:26 ` Power, Ciara
2020-10-30 14:59 ` David Marchand
2020-11-03 21:36 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zeCDC8j07ULQPqtYAHnOdhEFV6bV+ygJD6MuFfOR3=Bw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=gaurav1086@gmail.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).