From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66AE2A0547; Thu, 24 Jun 2021 15:23:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 493A240040; Thu, 24 Jun 2021 15:23:39 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7142F4003C for ; Thu, 24 Jun 2021 15:23:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624541017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=it6sw9kRJz2W9Kbtpa7HQpDNPkj80NHQnOqC2uTRmjg=; b=SS5bgfzrfDZL4xvzIR5EjwBFntS9jWZxSr305ndAMEtiHh28oFUaSQsWOLSINeADLQy3fx wK0FEs2lBYxs1EhI/RT6iIe4cyuCUuwBJC27mWmfi3vG4LL1VJN8J448gntA4MscCAAxAV BwD9kPw7XPXt6M/Uv+FxD46KUjgBZz4= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-454-UyxsCZICMc-in9eHi-XDxQ-1; Thu, 24 Jun 2021 09:23:36 -0400 X-MC-Unique: UyxsCZICMc-in9eHi-XDxQ-1 Received: by mail-vs1-f71.google.com with SMTP id y129-20020a677d870000b029026b5893c4aaso1192828vsc.4 for ; Thu, 24 Jun 2021 06:23:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=it6sw9kRJz2W9Kbtpa7HQpDNPkj80NHQnOqC2uTRmjg=; b=Q97Hy+9i6HzV3ZbzOUxHMARyh7DpOhQUHZhGjbWPuw2eHmhXQYKeeeD2i9q+X8z4zK ZL4WjoRKK8IFyW+/gMpNB2w3PNpNtAYDDzOocme1AJ5WMwVHm5ox8ZdE7+198Zcvh6OJ G86W7b5eimGb3kHVPJfX7bw6ny32ncpld6kGdxuW2JYBwU3Dd0t6hMddK7sU2XTQ7igt GN1EiCbPU1o+O1PyVngG9kkZomgGuFfCy4z9oxipt7VRgNnO7Nq5n06SALH7XIOVv4PU Xv4tJvg9ZQ9H25f5UeY35yQKdxrXmKKVH9gW0LJtM5a7tFf+7wsxnv0S3fnolvwMcxX9 D9pg== X-Gm-Message-State: AOAM533t2keDeIENhADhNju4zuyfW6r8B7rlwZsuVZOO5d3dUc61LtAj iXhlx7JQ6Cy/swozGjT1tmTL8vKlgTHXWfi0olzUdghhjXfYjC8N5de8uDBCUsR7vAe6TDVQfyz dCpZr5WbR69xC8IHj484= X-Received: by 2002:a67:df85:: with SMTP id x5mr2738590vsk.17.1624541015674; Thu, 24 Jun 2021 06:23:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/8S/+o/kRvKJUj52vwYF6bFFwwUgGMvXSN6DbJSGaQaLRvxuj7sUtxRkp4uohEa+16kE9Lg7SAmf0fOlWTuo= X-Received: by 2002:a67:df85:: with SMTP id x5mr2738573vsk.17.1624541015515; Thu, 24 Jun 2021 06:23:35 -0700 (PDT) MIME-Version: 1.0 References: <20210621132834.21673-1-ohilyard@iol.unh.edu> <20210623151730.35276-1-ohilyard@iol.unh.edu> In-Reply-To: <20210623151730.35276-1-ohilyard@iol.unh.edu> From: David Marchand Date: Thu, 24 Jun 2021 15:23:24 +0200 Message-ID: To: Owen Hilyard Cc: Vladimir Medvedkin , dev , dpdk stable , Stephen Hemminger Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4] rib: fix max depth IPv6 lookup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 23, 2021 at 5:17 PM wrote: > > From: Owen Hilyard > > ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. > The fix for the stack buffer overflow was to make sure depth > was always < 128, since when depth = 128 it caused the index > into the ip address to be 16, which read off the end of the array. > > While trying to solve the buffer overflow, I noticed that a few > changes could be made to remove the for loop entirely. > > Fixes: f7e861e21c ("rib: support IPv6") Updated sha1. Cc: stable@dpdk.org > > Signed-off-by: Owen Hilyard Acked-by: Vladimir Medvedkin Applied, thanks. -- David Marchand