From: David Marchand <david.marchand@redhat.com>
To: "Wangyu (Eric)" <seven.wangyu@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
Linuxarm <linuxarm@huawei.com>, "humin (Q)" <humin29@huawei.com>,
"Liyuan (Larry)" <Larry.T@huawei.com>,
dengxiaofeng <dengxiaofeng@huawei.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] bus/pci: align next mapping address on page boundary
Date: Thu, 14 Nov 2019 14:14:34 +0100 [thread overview]
Message-ID: <CAJFAV8zfEGgHmR6B8aW6B8LTEdWTBB_=NXnOZ75NPmFAK48tDg@mail.gmail.com> (raw)
In-Reply-To: <78A93308629D474AA53B84C5879E84D24B10A29B@DGGEMM533-MBX.china.huawei.com>
On Wed, Nov 13, 2019 at 8:17 AM Wangyu (Eric) <seven.wangyu@huawei.com> wrote:
>
> Currently, the next address picked by PCI mapping infrastructure
> may be page-unaligned due to BAR length being smaller than page size.
> This leads to a situation where the requested map address is invalid,
> resulting in mmap() call returning an arbitrary address,
> which will later interfere with device BAR mapping in secondary processes.
>
> Fix it by always aligning the next requested address on page boundary.
>
> Signed-off-by: Xiaofeng Deng <dengxiaofeng@huawei.com>
> Signed-off-by: Wangyu (Eric) <seven.wangyu@huawei.com>
> Acked-by: Wei Hu <xavier.huwei@huawei.com>
> Acked-by: Min Hu <humin29@huawei.com>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Acked-by: Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>
>
> Fixes: c752998b5e2e ("pci: introduce library and driver")
> Cc: stable@dpdk.org
Cc'd stable.
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2019-11-14 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1573628749-5572-1-git-send-email-dengxiaofeng@huawei.com>
2019-11-13 7:17 ` Wangyu (Eric)
2019-11-14 13:14 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zfEGgHmR6B8aW6B8LTEdWTBB_=NXnOZ75NPmFAK48tDg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=Larry.T@huawei.com \
--cc=dengxiaofeng@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=linuxarm@huawei.com \
--cc=seven.wangyu@huawei.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).