From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2618BA055B; Thu, 20 Oct 2022 13:31:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5B8042C5C; Thu, 20 Oct 2022 13:31:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id ED29A42BF1 for ; Thu, 20 Oct 2022 13:31:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666265475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NF8AB/Tut+fgp0Tz01Ey3a2CPBD/ulggx+zOjTpxn4Y=; b=eKW1zxVmbdR2j2OolCWfdymHxFTWUGg9Uu77mfBie/SjMCUzzd8+ghbjJJ/XfYhtp+Xwpa 2YSytNp488Z890v7qU5FtxrbDQzljQyOxVQ5qheXMZKYwiB8YEUVwfVVyBZBlR04ddtUbZ WitlRvNtG+VUyG83wpfnuB2ZeTHFVJA= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-623-3SHje6IpO5uAyl9dQfaVwQ-1; Thu, 20 Oct 2022 07:31:13 -0400 X-MC-Unique: 3SHje6IpO5uAyl9dQfaVwQ-1 Received: by mail-pl1-f200.google.com with SMTP id i17-20020a170902cf1100b00183e2a963f5so13608758plg.5 for ; Thu, 20 Oct 2022 04:31:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NF8AB/Tut+fgp0Tz01Ey3a2CPBD/ulggx+zOjTpxn4Y=; b=7J0E2jToAw/wCEqjL6pU8qtDQKc4seI1muDVtbj4FjxkLJJfSx0fnrFKJmoc8ECyH7 Gk4J1NIVztUd3j/DuzEleNUez/xvrmPJg1V1nazk2Eeoma/OsiGLY76FsB9VRC/ALdeF gF1VFykLEFC0eNtD+QNjc/janw5mP/u9KWp67Wh7W6UrKFW7wpbelKV7YiL/8cbdLtwX 3hQeZWNGM6xnfXKTjNZ0yREtlOWs4/zZVQb2XAf0qG0fsr8gHl9/quXKfYfC1O6WPFlS 4kNraLRP5jQShAPgrv7yWOyzWLMV8k6I0XhRRz7Oek11KIKZoCuCNAA96yerK5VIDQVr DtRg== X-Gm-Message-State: ACrzQf04XJOOckqIBK41YHvXixFzZnbo7dq0pn8o6rauUUNNliAeepTx jkcdLO62779JSsnYYTuvzPSt+h0M/WLwstcaLMq/hreNZpi2fxyPargOZpyB3IR7OsWUD7MsY2s OwrtpuXXqr6hU4JRLtnE= X-Received: by 2002:a17:902:bf46:b0:179:eba5:90ba with SMTP id u6-20020a170902bf4600b00179eba590bamr13524271pls.16.1666265472852; Thu, 20 Oct 2022 04:31:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4R75+9fqaSnonrNUEt8I2WXdu86rlV6/t6mgcbmL1P0MlPzQDyrArZqyfOtXnOBsP2KvW7XGMBEW8/8U1tmt0= X-Received: by 2002:a17:902:bf46:b0:179:eba5:90ba with SMTP id u6-20020a170902bf4600b00179eba590bamr13524251pls.16.1666265472554; Thu, 20 Oct 2022 04:31:12 -0700 (PDT) MIME-Version: 1.0 References: <20221019104923.1240394-1-kevin.laatz@intel.com> <20221019123743.1282969-1-kevin.laatz@intel.com> In-Reply-To: From: David Marchand Date: Thu, 20 Oct 2022 13:31:00 +0200 Message-ID: Subject: Re: [PATCH v2] bus: fix memleak during pci device cleanup To: Kevin Laatz Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Bruce Richardson , weiyuanx.li@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 20, 2022 at 11:19 AM David Marchand wrote: > On Wed, Oct 19, 2022 at 2:35 PM Kevin Laatz wrote: > > > > During PCI bus device cleanup some interrupt handle pointers and the > > bus_info pointer are not being free'd, leading to memory leaks. > > This patch fixes the memory leaks by ensuring they are free'd during > > device cleanup on exit. > > > > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") > > > > Signed-off-by: Kevin Laatz Tested-by: Weiyuan Li > Reviewed-by: David Marchand Applied with suggested update, thanks. -- David Marchand