DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	Sarosh Arif <sarosh.arif@emumba.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] timer: add limitation note for sync stop and reset
Date: Thu, 8 Oct 2020 12:28:29 +0200
Message-ID: <CAJFAV8zgLs+WHEbSjAii84eFa-9zLDj2LMO1jgjYF07nypfyRg@mail.gmail.com> (raw)
In-Reply-To: <DBAPR08MB5814D9E2263BC281C0480E0598270@DBAPR08MB5814.eurprd08.prod.outlook.com>

On Thu, Sep 10, 2020 at 3:23 AM Honnappa Nagarahalli
<Honnappa.Nagarahalli@arm.com> wrote:
> > If a timer's callback function calls rte_timer_reset_sync() or
> > rte_timer_stop_sync() on another timer that is in the RUNNING state and
> > owned by the current lcore, the *_sync() calls will loop indefinitely.
> >
> > Relatedly, if a timer's callback function calls *_sync() on another timer that is
> > in the RUNNING state and is owned by a different lcore, but a timer callback
> > function runs on that different lcore and calls
> > *_sync() on a timer that is in the RUNNING state and owned by the current
> > lcore, the two lcores will loop indefinitely.
> >
> > Add a note in the rte_timer_stop_sync and rte_timer_reset_sync
> > documentation that indicates that these APIs should not be used inside
> > timer callback functions in order to avoid the hangs described above, and
> > suggests an alternative.
> >
> > Bugzilla ID: 491
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Applied, thanks.

Since we go with documenting a limitation, should we mark the original
patches [1] and [2] as rejected instead of deferred?

1: https://patches.dpdk.org/patch/75156/
2: https://patches.dpdk.org/patch/73683/

David Marchand

  reply	other threads:[~2020-10-08 10:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 14:41 [dpdk-dev] [PATCH 0/1] " Erik Gabriel Carrillo
2020-09-09 14:41 ` [dpdk-dev] [PATCH 1/1] " Erik Gabriel Carrillo
2020-09-10  1:22   ` Honnappa Nagarahalli
2020-10-08 10:28     ` David Marchand [this message]
2020-10-08 13:58       ` Carrillo, Erik G
2020-10-08 14:11         ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8zgLs+WHEbSjAii84eFa-9zLDj2LMO1jgjYF07nypfyRg@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=nd@arm.com \
    --cc=sarosh.arif@emumba.com \
    --cc=stable@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git