From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D65C445A9A; Thu, 3 Oct 2024 11:14:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6873D40289; Thu, 3 Oct 2024 11:14:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 65033400D7 for ; Thu, 3 Oct 2024 11:14:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727946848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h7IrDJMwbnMl5OtTp2kuvjQ70AHSedaocsc/FFVqVY8=; b=XME7AWq/ZE9QfQqKaYRVSUvaAYuc4t+lXyzjGY0qNgBkyhyPJsVqXqpJxprnBD4B7HBszS cB1xumVpypTWJGvo8hFwv5f6/q36fSYoJgTUOztQqFAR3s7PywbzlS7dDku7L5qeO98SFe UptCDTjDSmZITEpUQKyT8U6ZwATt2jI= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-pPTRrZ5SN6KQhdtJpV0ieA-1; Thu, 03 Oct 2024 05:14:07 -0400 X-MC-Unique: pPTRrZ5SN6KQhdtJpV0ieA-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-53994612aa6so635682e87.1 for ; Thu, 03 Oct 2024 02:14:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727946845; x=1728551645; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h7IrDJMwbnMl5OtTp2kuvjQ70AHSedaocsc/FFVqVY8=; b=pcDY3BQCI3iBcQRPWr8FaT90tnAg5dTzmqny9C37XRaa1DFPwjItRHsbgbogHmUeTD 5UrdKongHSGr/g0uwnmECmhyhNyPaP4w6XzqO4YgcJMlOWVgSj3lzM8KnoC/iZgQkeeN 8LcpnhxKWPvtvqIGAwZR3m58iiuRLUJoL+C7Kw055rtlVFURNP8j3v3uCPfw8bDLG+RW C8nM1X6xe7TYkeOh7Gad/Wf45puU8sCZc4i1Rx4AewtY06D8f7Vlm6eU5n8F9jBPTsEY E94xagKiazqdZu+Ds3dKJ2q+NFcNYn52CFztpgxMGRWMvcMaZ6gSPrQAF4a1SlN0FEGy RcEw== X-Gm-Message-State: AOJu0Yz9AjgGgz4wSfQWFOaUwErrACZFaWw8DKFmTn+nTDOYllCoogiR rCovgvUCHTNtTH94W8zICZyr8FLcTsHA4BCffu+DRayHuR6MBEqy4RcWuX3fo8BcHjQDyWqQB/j Fo6rYE6klm7TYvKGFMO0xRdFHuFCsj6sWTB3yBfsNQVHhm3BHvJHAnAutR1wcsXifJ1u1Ezeszl caCo7ESlq5EaXcTlE= X-Received: by 2002:a05:6512:159b:b0:539:905c:15c5 with SMTP id 2adb3069b0e04-539a067c06fmr5470525e87.35.1727946845526; Thu, 03 Oct 2024 02:14:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFRlEMOrkwF1DTd3i+ECO2gcj9G1OUtbUZFFERtM3fRU+m+w+eumjRvmTE893iqNOwRsopT9lJLal7jCm/3UUk= X-Received: by 2002:a05:6512:159b:b0:539:905c:15c5 with SMTP id 2adb3069b0e04-539a067c06fmr5470492e87.35.1727946845094; Thu, 03 Oct 2024 02:14:05 -0700 (PDT) MIME-Version: 1.0 References: <20241001162603.793853-1-mattias.ronnblom@ericsson.com> <20241003065702.3051158-1-david.marchand@redhat.com> In-Reply-To: <20241003065702.3051158-1-david.marchand@redhat.com> From: David Marchand Date: Thu, 3 Oct 2024 11:13:53 +0200 Message-ID: Subject: Re: [PATCH v2] service: fix deadlock on worker lcore exit To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Harry van Haaren Cc: dev@dpdk.org, stephen@networkplumber.org, suanmingm@nvidia.com, thomas@monjalon.net, stable@dpdk.org, Tyler Retzlaff , Aaron Conole X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 3, 2024 at 8:57=E2=80=AFAM David Marchand wrote: > > From: Mattias R=C3=B6nnblom > > Calling rte_exit() from a worker lcore thread causes a deadlock in > rte_service_finalize(). > > This patch makes rte_service_finalize() deadlock-free by avoiding the > need to synchronize with service lcore threads, which in turn is > achieved by moving service and per-lcore state from the heap to being > statically allocated. > > The BSS segment increases with ~156 kB (on x86_64 with default > RTE_MAX_LCORE and RTE_SERVICE_NUM_MAX). > > According to the service perf autotest, this change also results in a > slight reduction of service framework overhead. > > Fixes: 33666b448f15 ("service: fix crash on exit") > Cc: stable@dpdk.org > > Signed-off-by: Mattias R=C3=B6nnblom > Acked-by: Tyler Retzlaff > --- > Changes since v1: > - rebased, I can't merge this patch in its current state. At the moment, two CI report a problem with the eal_flags_file_prefix_autotest unit test. -------------------------------------stdout--------------------------------= ----- RTE>>eal_flags_file_prefix_autotest Running binary with argv[]:'/home/zhoumin/gh_dpdk/build/app/dpdk-test' '--proc-type=3Dsecondary' '-m' '18' '--file-prefix=3Dmemtest' Running binary with argv[]:'/home/zhoumin/gh_dpdk/build/app/dpdk-test' '-m' '18' '--file-prefix=3Dmemtest1' Error - hugepage files for memtest1 were not deleted! Test Failed RTE>> Can you have a look? Thanks. --=20 David marchand