From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75F6EA0524; Fri, 19 Mar 2021 21:39:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53884140FDA; Fri, 19 Mar 2021 21:39:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 62BA840143 for ; Fri, 19 Mar 2021 21:38:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616186338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XRwW7nBb7iJ4FY9baDEUOn0WNEfwNoDGHEC18NrYEuY=; b=aNpXfmAys6rAsnN4P03lUxIFCMPRgdX5VxgNNs7vAu9SL61Hacqx8vi2yAn/aLTLIZMqdd oPY/DI4EcFxgmPUQvHwoPQ22Pm+KP1J+iCdrHsJ/yU4F775xB6WxwcYzVK9ZjWDi1cbtUM ji7nEU1myjNLi8YVnWtZlX7cx0h7/8A= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-342-PZgx9ENuOmW6V4Qwz5nNNw-1; Fri, 19 Mar 2021 16:38:56 -0400 X-MC-Unique: PZgx9ENuOmW6V4Qwz5nNNw-1 Received: by mail-ua1-f72.google.com with SMTP id r20so705093ual.23 for ; Fri, 19 Mar 2021 13:38:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XRwW7nBb7iJ4FY9baDEUOn0WNEfwNoDGHEC18NrYEuY=; b=B6UeoGYgBResK3WFNT9HVWQNEK/BuQnrMUHMA/dK9FJdF38tAsgZmZWsRGIOYooPDP +0f7IVWuXdG0dKVvVdQ8/kE9RFiIXKXkFRSKYCagXl973fA7Y6Kvu2f6qMEVmu10iJ+H LNhLfn28CoHqgq/WOmqKNUmRaYXUBKylYLZJMKDteSiLw8eNghrs1wRUYiuKeBVWRM3h jlGSN+jbBLPrSnMxshytLV+sSDBrZI+XxDWRrFsoPNTXBki52cRvzi6v/ZzU0oQmH71Z McSAwUY3/t6MmGvPM970n8apxgzY3u+1rfMedQqCk6bHXI8mI9yAsipQM0xGYiegsThM Mbbg== X-Gm-Message-State: AOAM533zLkUH8HwpdxwT/ENIUWK3gZ1w9vqLDDyMkq36Fdud3IK8V7bP sgbfHO+YSkgUrIQJPuhQ6q/vVLzX6U8XAwjTpVeLqc9OIguTFI5UoZrrVnXs+/t50fx3paqFOWb YUfMTl7Y6D2qqQyIRvfY= X-Received: by 2002:a05:6102:ed4:: with SMTP id m20mr4036508vst.27.1616186336077; Fri, 19 Mar 2021 13:38:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxH8qiQ8egNgANalMzjYi6XB2/YdnlIfJ/Dm3i8Nmcu8wvAUUhEhtHvhB2jvXq7x4pv37k24tWkkvPwg5wft90= X-Received: by 2002:a05:6102:ed4:: with SMTP id m20mr4036489vst.27.1616186335857; Fri, 19 Mar 2021 13:38:55 -0700 (PDT) MIME-Version: 1.0 References: <20210310140107.2730088-1-thomas@monjalon.net> <20210310140107.2730088-4-thomas@monjalon.net> <5273226.FjvTQ7qL0s@thomas> In-Reply-To: <5273226.FjvTQ7qL0s@thomas> From: David Marchand Date: Fri, 19 Mar 2021 21:38:44 +0100 Message-ID: To: Thomas Monjalon Cc: dev , John Griffin , Fiona Trahe , Deepak Kumar Jain , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta , Rosen Xu , Tianfei zhang , Bruce Richardson , Nipun Gupta , Hemant Agrawal , Xiao Wang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 3/3] drivers: align log names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 19, 2021 at 6:15 PM Thomas Monjalon wrote: > > 19/03/2021 17:29, David Marchand: > > On Wed, Mar 10, 2021 at 3:02 PM Thomas Monjalon wrote: > > > > > > The log levels are configured by using the name of the logs. > > > Some drivers are aligned to follow a common log name standard: > > > pmd.class.driver[.sub] > > > Some "common" drivers skip the "class" part: > > > pmd.driver.sub > > > > Without a check, this is likely to happen again. > > I cooked this: > [...] > > +RTE_LOG_REGISTER(ixgbe_logtype_init, pmd.net.ixgb.init, NOTICE); > > Added logtype does not comply with pattern: pmd.net.ixgbe > > +RTE_LOG_REGISTER(compressdev_logtype, lib.compressde, NOTICE); > > Added logtype does not comply with pattern: lib.compressdev > > > > WDYT? > > I cannot parse awk but it looks nice. > And in general, have more tools is a good thing. > Would you submit this tool as a patch? http://inbox.dpdk.org/dev/20210319203737.13526-1-david.marchand@redhat.com/T/#u -- David Marchand