From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D68F5A034C; Fri, 30 Sep 2022 09:18:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F379640FAE; Fri, 30 Sep 2022 09:18:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E77A640E5A for ; Fri, 30 Sep 2022 09:18:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664522288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jUqTjSA+ePIu2aldTheP2qvnaU/pnMleK1nWQ2gK/1c=; b=CYOPaavsVDLNvmkR40svYE6nz8eisEZI7jy/KUyilFYQ6qKl1CH1HCHMPvDEk+qlJ1m5yK cHB2/vb7B9ajKPLDTX2G+kVPvMkdCHbKIs1iEQ0vfFex/+c8fe6Cvn/gym3jKZP3qyqPWA XBjajV/I43/hWZpfMAPHGO7GPy3ze1c= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-460-fYzPsbxGPYCJjgL7_2KmxQ-1; Fri, 30 Sep 2022 03:18:04 -0400 X-MC-Unique: fYzPsbxGPYCJjgL7_2KmxQ-1 Received: by mail-pf1-f200.google.com with SMTP id k11-20020aa792cb000000b00558674e8e7fso2327829pfa.6 for ; Fri, 30 Sep 2022 00:18:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=jUqTjSA+ePIu2aldTheP2qvnaU/pnMleK1nWQ2gK/1c=; b=NC1h/RkUsj39ft2/f1cpuWk3TWDinLkmgB57U5NHFfkCB3NApmu6M3u1J8uPlH0OrV dM8Z7inIOgBKiV+/oG28rJGnTwsT+VlJWqNqOUgAoSwTGyLi9uF+HAUvkU0pmmAFnw+g a5uh2xPn4HmFOwugniUsZyPMAxo3fOpu2LnMBJTT3vdCF8ED0zdz4MIcXnRPinpVDB8P PsO5XOwOIrrYVeLrLF82GtBYpta2RPgKIRAXySnpailR3P+Il7H4jaX51b4+raX0ljLc 5BlLMwHD76TaSBOrhj4Yl5UU/pbNBqDyw638G1YboS4+/9Iy7bwFjy/KoUtuaUFPsgVg 1XFg== X-Gm-Message-State: ACrzQf3IpYQqgHFQgNPTwshaovq7Q5NKvMLKXq9OIghYK7y+1KxHRtK7 QQkh4upYLQHwIkCcQE//qqITsGGRK/a39geO6rw8UuZQgkqYa+JW2+zTzOj/y5Dr5fts/USQTwD o3g+LbiSmuVA3QXlR7eE= X-Received: by 2002:a62:4e4c:0:b0:53e:22b6:6869 with SMTP id c73-20020a624e4c000000b0053e22b66869mr7313630pfb.29.1664522283851; Fri, 30 Sep 2022 00:18:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Z8k5O3lGHTI5q4yISRLLi+wlXJ4++ongMdGqp6LZwTJDxhT94iXdXdpWsbcMdfZZOG3VoV8jiD1w6oW7fojU= X-Received: by 2002:a62:4e4c:0:b0:53e:22b6:6869 with SMTP id c73-20020a624e4c000000b0053e22b66869mr7313603pfb.29.1664522283582; Fri, 30 Sep 2022 00:18:03 -0700 (PDT) MIME-Version: 1.0 References: <20220929105101.406724-1-bruce.richardson@intel.com> In-Reply-To: <20220929105101.406724-1-bruce.richardson@intel.com> From: David Marchand Date: Fri, 30 Sep 2022 09:17:52 +0200 Message-ID: Subject: Re: [PATCH] eal: remove panic on remote launch failure To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, Ray Kinsella , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 29, 2022 at 12:51 PM Bruce Richardson wrote: > > Library functions should not cause the app to exit or panic. Replace the > existing panic call in the EAL remote launch functions with an error > code return instead. > > Signed-off-by: Bruce Richardson LGTM with an update of the release notes (that I will add when merging if there is no futher comment/objection). Reviewed-by: David Marchand -- David Marchand