From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>, dev <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Xueming Zhang <xuemingx.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: drop inline from non-static functions
Date: Wed, 20 May 2020 17:16:14 +0200 [thread overview]
Message-ID: <CAJFAV8zi94boDx6W4ap9wO+ZBR5Kk3FYgTmcg6uG=E+QpPa0iw@mail.gmail.com> (raw)
In-Reply-To: <20200520102222.2241689-1-ferruh.yigit@intel.com>
On Wed, May 20, 2020 at 12:22 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> There is no point in having non-static (and non-extern) inline
> functions.
>
> Also this breaks the build for the ICC [1] because of the 'internal'
> symbol check.
>
> When function is 'inline' ICC is ignoring 'section' attribute and not
> putting function to 'internal' section which breaks 'check-symbols.sh'
> script with below error.
>
> [1]
> qbman_swp_dqrr_next is not flagged as internal
> but is listed in version map
> Please add __rte_internal to the definition of qbman_swp_dqrr_next
> qbman_swp_enqueue_multiple is not flagged as internal
> but is listed in version map
> Please add __rte_internal to the definition of qbman_swp_enqueue_multiple
> qbman_swp_enqueue_multiple_desc is not flagged as internal
> but is listed in version map
> Please add __rte_internal to the definition of qbman_swp_enqueue_multiple_desc
> qbman_swp_enqueue_multiple_fd is not flagged as internal
> but is listed in version map
> Please add __rte_internal to the definition of qbman_swp_enqueue_multiple_fd
> qbman_swp_pull is not flagged as internal
> but is listed in version map
> Please add __rte_internal to the definition of qbman_swp_pull
> qbman_swp_release is not flagged as internal
> but is listed in version map
> Please add __rte_internal to the definition of qbman_swp_release
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Applied, thanks Ferruh.
--
David Marchand
prev parent reply other threads:[~2020-05-20 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 10:22 Ferruh Yigit
2020-05-20 11:41 ` Hemant Agrawal
2020-05-20 15:16 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zi94boDx6W4ap9wO+ZBR5Kk3FYgTmcg6uG=E+QpPa0iw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=thomas@monjalon.net \
--cc=xuemingx.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).