From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, chenbo.xia@intel.com, mb@smartsharesystems.com,
stable@dpdk.org, Li Feng <fengli@smartx.com>
Subject: Re: [PATCH 1/7] vhost: fix missing vring call check on virtqueue access
Date: Thu, 19 Oct 2023 09:24:03 +0200 [thread overview]
Message-ID: <CAJFAV8ziT6ot8gWDyBtdc3x83UAn8sT7Gmxr_U6Ognu=J-y69Q@mail.gmail.com> (raw)
In-Reply-To: <20230925163610.3307750-2-maxime.coquelin@redhat.com>
On Mon, Sep 25, 2023 at 6:36 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> Acquiring the access lock is not enough to ensure
> virtqueue's metadata such as vring pointers are valid.
>
> The access status must also be checked.
Even if adding the lock was not enough, I would flag Fixes:
6c299bb7322f ("vhost: introduce vring call API")
>
> Fixes: c5736998305d ("vhost: fix missing virtqueue lock protection")
> Fixes: 830f7e790732 ("vhost: add non-blocking API for posting interrupt")
> Cc: stable@dpdk.org
>
> Reported-by: Li Feng <fengli@smartx.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2023-10-19 7:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 16:36 [PATCH 0/7] vhost: ensure vitqueue access status is checked Maxime Coquelin
2023-09-25 16:36 ` [PATCH 1/7] vhost: fix missing vring call check on virtqueue access Maxime Coquelin
2023-10-19 7:24 ` David Marchand [this message]
2023-10-20 8:40 ` Maxime Coquelin
2023-09-25 16:36 ` [PATCH 2/7] vhost: fix missing " Maxime Coquelin
2023-09-25 16:36 ` [PATCH 3/7] vhost: fix checking virtqueue access when notifying guest Maxime Coquelin
2023-09-25 16:36 ` [PATCH 4/7] vhost: fix check on virtqueue access in async registration Maxime Coquelin
2023-09-25 16:36 ` [PATCH 5/7] vhost: Fix check on virtqueue access in in-flight getter Maxime Coquelin
2023-09-25 16:36 ` [PATCH 6/7] vhost: fix missing lock protection in power monitor API Maxime Coquelin
2023-09-25 16:36 ` [PATCH 7/7] vhost: fix checking virtqueue access ins stats API Maxime Coquelin
2023-10-19 9:49 ` [PATCH 0/7] vhost: ensure vitqueue access status is checked David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8ziT6ot8gWDyBtdc3x83UAn8sT7Gmxr_U6Ognu=J-y69Q@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=fengli@smartx.com \
--cc=maxime.coquelin@redhat.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).