From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A712A431A6; Thu, 19 Oct 2023 09:24:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 953D240263; Thu, 19 Oct 2023 09:24:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7A7414021F for ; Thu, 19 Oct 2023 09:24:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697700258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PPSXinha02H3WixS4BX/SJY1AkoZcLQAW2eKHdGHvZ8=; b=U61PQVIuZG8Ocu70Bhcx6ftdb0nI801IOwCFg7z9FrulpHd4CUn111nMiJSv8ZG9kR1hZW l5a6/3DHbIIkuW7cSFeAJFRNiscs4goYhxZK+6TqPxHZ7z0RbzJl1zx0khJHaQvM6dmkoc 6716uqgj7zqaxYQgLbbo2+nMmEYTdtU= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-92-PH_w0pqAOmexdGbWL7XY1Q-1; Thu, 19 Oct 2023 03:24:16 -0400 X-MC-Unique: PH_w0pqAOmexdGbWL7XY1Q-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2c5032ab59eso62794041fa.3 for ; Thu, 19 Oct 2023 00:24:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697700255; x=1698305055; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PPSXinha02H3WixS4BX/SJY1AkoZcLQAW2eKHdGHvZ8=; b=Iq436ReCubcnXgzziSGybVwXs6B55H+mK+xQlWZQjFybROOjiPxr33umuopA7nWjG6 4u+ptsV0p/bnKGCyYFCeFYAJlT2Wumxiwiece9L51qq/OWpai/EDJ5QRjpYcXZVzkO4G mmyTN9sPfChXrjtQqGDsO9P1+ksIFH9wnTKnFXeMsBCIsO+aOjq7OqOc5mHAzl1FgzAq yeFlB4CTCEQzmg//gG5dThtjyhJPYJvEvXhQ4J898NZXs7jtIZa6PNvIv5hy6NiKrqlt pfN2MgdKzXG6zS+Sor2cZbwqDINtuQoq6hD5z8qbw4oeCliNGvUkBIAevf3ZX5nvh0MK avCg== X-Gm-Message-State: AOJu0YxucNMWzQSvGGlIV4Bdk5b1R9MmHcNWTE28gY0dmPgz2eTpia5p TuhEeYWHU+bS7/+kB9+6A15GY0LCdb+Fba1WrvMtDrQPRogWFA+Va0KiqLQmUlCRXbszoTG7+EI 4kv3u12Xr2JLWmI9++7g= X-Received: by 2002:a2e:7401:0:b0:2be:3ca8:bdc9 with SMTP id p1-20020a2e7401000000b002be3ca8bdc9mr741530ljc.49.1697700254977; Thu, 19 Oct 2023 00:24:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEARH3XCE+kj5pmImug+H/oRW06xL/0Y+8sS+upKa5o0L++5IppaqKsqSifzUiN8K+TSbcG3V9IwdU23S0EtcI= X-Received: by 2002:a2e:7401:0:b0:2be:3ca8:bdc9 with SMTP id p1-20020a2e7401000000b002be3ca8bdc9mr741523ljc.49.1697700254664; Thu, 19 Oct 2023 00:24:14 -0700 (PDT) MIME-Version: 1.0 References: <20230925163610.3307750-1-maxime.coquelin@redhat.com> <20230925163610.3307750-2-maxime.coquelin@redhat.com> In-Reply-To: <20230925163610.3307750-2-maxime.coquelin@redhat.com> From: David Marchand Date: Thu, 19 Oct 2023 09:24:03 +0200 Message-ID: Subject: Re: [PATCH 1/7] vhost: fix missing vring call check on virtqueue access To: Maxime Coquelin Cc: dev@dpdk.org, chenbo.xia@intel.com, mb@smartsharesystems.com, stable@dpdk.org, Li Feng X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 25, 2023 at 6:36=E2=80=AFPM Maxime Coquelin wrote: > > Acquiring the access lock is not enough to ensure > virtqueue's metadata such as vring pointers are valid. > > The access status must also be checked. Even if adding the lock was not enough, I would flag Fixes: 6c299bb7322f ("vhost: introduce vring call API") > > Fixes: c5736998305d ("vhost: fix missing virtqueue lock protection") > Fixes: 830f7e790732 ("vhost: add non-blocking API for posting interrupt") > Cc: stable@dpdk.org > > Reported-by: Li Feng > Signed-off-by: Maxime Coquelin --=20 David Marchand