From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CFB242383; Wed, 11 Jan 2023 17:09:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23DF740E25; Wed, 11 Jan 2023 17:09:43 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9342B40A7D for ; Wed, 11 Jan 2023 17:09:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673453381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=phtUNWnHUxqQxfW8L83I0i48p8WljawfFKJzndCThXw=; b=eRv4j4fzjjL8eyaKGEpucaCWqkAPK+zFO2TLv3M5BpRL/HOiUkxIPKqqtb30kpCAfP5R8I dkiqX0RUXMmFwdcLaJbYx32b8YpdgXVdjp19aSzyjcLntBdO8MbVeMNYSQmTb5uVkSSzsd NbonhSEqL3FTNyd2HFQRwZ7HYwcsAlI= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-443-uQRgXpj8O7Wi3DrUy31oug-1; Wed, 11 Jan 2023 11:09:37 -0500 X-MC-Unique: uQRgXpj8O7Wi3DrUy31oug-1 Received: by mail-pl1-f199.google.com with SMTP id z3-20020a170903018300b0018fb8ca1688so10782793plg.5 for ; Wed, 11 Jan 2023 08:09:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=phtUNWnHUxqQxfW8L83I0i48p8WljawfFKJzndCThXw=; b=x/7oMBxXa/+s2FOc1aciSz5LgXiS42Fa9Oy8y1xg3Num08ecAVFH109r1gBBe6V/Nb 1lRu3q24UQWuw+S5yyEqFmMGUCLjupsu0S6tRIJX6I2OHqh/CgswYUGgO6JHXGIS/w+7 8fgzmdm7MG4uVoiR9ybBMZB4urcGgl/8ycuz45q0sKy3QnLS3pEmOYn7ERYkbn1ixD3D qJGSd5HIork/6SVIUXdYDw4KD4gYOG1rlfavPmqbzTUpiSVBrCccJQM3WFxFAs11/40s 1l9z4o6XQQPLXB27dRlKbAwR/MhWVNGXlRSJp11ETCdR0m8fQ/syuc6LIOFQtZpq5XCY Ap3w== X-Gm-Message-State: AFqh2krZIJ60jl4WjokKDclrvT1iWmkV3ispHMpndSPmCOZzViaI2y/n e2hphwp+OnRvLbX5hTvb1ZI94PsTgJKfJYT2tiQXgPlJuTq8CgYvCwZDiJB9oComvKBMra9WM+G E7ZSMrMQhTngMmmkQ6wg= X-Received: by 2002:a17:902:7681:b0:192:b5b1:eb25 with SMTP id m1-20020a170902768100b00192b5b1eb25mr3554117pll.161.1673453376662; Wed, 11 Jan 2023 08:09:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXtZoVQ4lZzBdMVSUArAFXfbsPnCduk/4V5Hw2fDKEJqi7ImSWOACgnhE/jD4cx2epMh8pYEhX5feyiM0qDtjP0= X-Received: by 2002:a17:902:7681:b0:192:b5b1:eb25 with SMTP id m1-20020a170902768100b00192b5b1eb25mr3554114pll.161.1673453376367; Wed, 11 Jan 2023 08:09:36 -0800 (PST) MIME-Version: 1.0 References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com> <1671036441-10234-1-git-send-email-roretzla@linux.microsoft.com> <1671036441-10234-2-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1671036441-10234-2-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Wed, 11 Jan 2023 17:09:25 +0100 Message-ID: Subject: Re: [PATCH v2 1/4] eal: add thread set name API operating on rte thread To: Tyler Retzlaff , Jerin Jacob Kollanukkaran , Sunil Kumar Kori Cc: dev@dpdk.org, thomas@monjalon.net, olivier.matz@6wind.com, stephen@networkplumber.org, mb@smartsharesystems.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 14, 2022 at 5:47 PM Tyler Retzlaff wrote: > diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c > index 5caaac8..89522dc 100644 > --- a/lib/eal/common/eal_common_trace.c > +++ b/lib/eal/common/eal_common_trace.c > @@ -356,8 +356,6 @@ rte_trace_mode rte_trace_mode_get(void) > /* Store the thread name */ > char *name = header->stream_header.thread_name; > memset(name, 0, __RTE_TRACE_EMIT_STRING_LEN_MAX); > - rte_thread_getname(pthread_self(), name, > - __RTE_TRACE_EMIT_STRING_LEN_MAX); > > trace->lcore_meta[count].mem = header; > trace->nb_trace_mem_list++; Note, this belongs to patch 2. I understand we can drop the thread name retrieval helper from public API, but at least for the trace framework it added some info in the traces. Jerin, Sunil, what do you think? Should we keep this helper internally? -- David Marchand