From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0D0842609; Tue, 19 Sep 2023 17:20:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75E2F4067A; Tue, 19 Sep 2023 17:20:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 29F93402E8 for ; Tue, 19 Sep 2023 17:20:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695136824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ybZX80qyQPNe6hBZwjwewXa2Dqu7HBqcNFSIF7uo4tM=; b=QqnNnhyi7TTeuHktxJTk1VvRxSwOMKr/h6JyigPTd/BwWxVu2wztj8X6qoMfkvRgef/wX3 Ma0wP5qxO5K+NYMS8d4oAd45A69uPCZFsrdXZDry1EI8xnYdGNgxvYj6ASU+qmjwTTK9E7 tng7KqSPdnfJuqKAlhLNTvVqXH6nBU4= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-AsVOx2D5MyWCOvJgPR3KaQ-1; Tue, 19 Sep 2023 11:20:23 -0400 X-MC-Unique: AsVOx2D5MyWCOvJgPR3KaQ-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2b710c5677eso69497381fa.0 for ; Tue, 19 Sep 2023 08:20:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695136821; x=1695741621; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ybZX80qyQPNe6hBZwjwewXa2Dqu7HBqcNFSIF7uo4tM=; b=TyaPT7SoqvUvpJ1PocLxuWLGbCv6mhTD2jxU/XLkONb8Aw8HZhREElmNrtMncpRgtt ya7/c/AmC0pjP/0XVZQPwbXaeukk+KnAi2Ryrm7OVUJeUJImyiMxLKNlbrnknydAUVB3 LS9rqCigI4cAo17HzaeovfCzxv1df+Z8s+kYnuvr/FgdRW+q0YToAv90oKk2vOasSz8A VHyuBJxo1eSShaFXE2LquWj4+HwkbrryX3wcrMqWbrPBLBcrPJPGd5m6E+plksToOvy4 LGLbDmDb//kFY6eU3TaXPusgo5XmT8SPt6avDxtowFRkiOakudUfcJC0rOSyyyhQV8m5 ku2w== X-Gm-Message-State: AOJu0YxgdHH+ZiTXYlXcIm+0zTKXTc9JG3ZF7cDPvKVeRL2VbUnCXqq3 KXMnVCuey85IZt4M6dNyC09Wa3UNoBCu6PKuoqij5PD0NQZdy472NX6Il6bH9vfK+hGX5qERn/G AFkVFJAvJqbnYFq9rrNA= X-Received: by 2002:a2e:3818:0:b0:2bb:bfa5:b72c with SMTP id f24-20020a2e3818000000b002bbbfa5b72cmr10514090lja.15.1695136821823; Tue, 19 Sep 2023 08:20:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE3tQNsX82NBzwjt1SaSxiylRLlzd5tEbwR/sAc8Z+o8SjKwtCl7jLJqEnGtw0t8OXLKynzf2C02J694hRYGU4= X-Received: by 2002:a2e:3818:0:b0:2bb:bfa5:b72c with SMTP id f24-20020a2e3818000000b002bbbfa5b72cmr10514076lja.15.1695136821499; Tue, 19 Sep 2023 08:20:21 -0700 (PDT) MIME-Version: 1.0 References: <20230919012136.2818396-1-nicolas.chautru@intel.com> <20230919012136.2818396-4-nicolas.chautru@intel.com> In-Reply-To: <20230919012136.2818396-4-nicolas.chautru@intel.com> From: David Marchand Date: Tue, 19 Sep 2023 17:20:10 +0200 Message-ID: Subject: Re: [PATCH v1 3/7] baseband/acc: remove the 4G SO capability for VRB1 To: Nicolas Chautru Cc: dev@dpdk.org, maxime.coquelin@redhat.com, hemant.agrawal@nxp.com, hernan.vargas@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 19, 2023 at 3:25=E2=80=AFAM Nicolas Chautru wrote: > > This removes the specific capability and support of LTE Decoder > Soft Output option on the VRB1 PMD. Please explain why such support is removed for this hw. > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc/rte_vrb_pmd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rt= e_vrb_pmd.c > index 3c8f3409ed..e0f50460bd 100644 > --- a/drivers/baseband/acc/rte_vrb_pmd.c > +++ b/drivers/baseband/acc/rte_vrb_pmd.c > @@ -1019,14 +1019,11 @@ vrb_dev_info_get(struct rte_bbdev *dev, struct rt= e_bbdev_driver_info *dev_info) > RTE_BBDEV_TURBO_CRC_TYPE_24B | > RTE_BBDEV_TURBO_DEC_CRC_24B_DROP = | > RTE_BBDEV_TURBO_EQUALIZER | > - RTE_BBDEV_TURBO_SOFT_OUT_SATURATE= | > RTE_BBDEV_TURBO_HALF_ITERATION_EV= EN | > RTE_BBDEV_TURBO_CONTINUE_CRC_MATC= H | > - RTE_BBDEV_TURBO_SOFT_OUTPUT | > RTE_BBDEV_TURBO_EARLY_TERMINATION= | > RTE_BBDEV_TURBO_DEC_INTERRUPTS | > RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN = | > - RTE_BBDEV_TURBO_NEG_LLR_1_BIT_SOF= T_OUT | > RTE_BBDEV_TURBO_MAP_DEC | > RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KE= EP | > RTE_BBDEV_TURBO_DEC_SCATTER_GATHE= R, > @@ -1975,6 +1972,9 @@ enqueue_dec_one_op_cb(struct acc_queue *q, struct r= te_bbdev_dec_op *op, > struct rte_mbuf *input, *h_output_head, *h_output, > *s_output_head, *s_output; > > + /* Disable explictly SO for VRB 1. */ > + op->turbo_dec.op_flags &=3D ~RTE_BBDEV_TURBO_SOFT_OUTPUT; Can you explain why it is needed to filter this out? I did not find a clear description in the bbdev API. It would help if there were explicits references in doxygen of which capability is necessary for using flags/API. I was expecting that asking for RTE_BBDEV_TURBO_SOFT_OUTPUT to a driver is only allowed if rte_bbdev_op_cap contains it. With this assumption, it would be invalid for an application to request RTE_BBDEV_TURBO_SOFT_OUTPUT through rte_bbdev_enqueue_dec_ops. > + > desc =3D acc_desc(q, total_enqueued_cbs); > vrb_fcw_td_fill(op, &desc->req.fcw_td); > > -- > 2.34.1 > At this point of the series, the documentation still references RTE_BBDEV_TURBO_SOFT_OUTPUT as something supported by the vrb1 driver. --=20 David Marchand