From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id 5892C1B607 for ; Thu, 10 Jan 2019 13:29:07 +0100 (CET) Received: by mail-vk1-f194.google.com with SMTP id 197so2434701vkf.4 for ; Thu, 10 Jan 2019 04:29:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2zxUQWTUMA/WtYGGSBDTeSWfBs9ig/xYSlW5aGa6Cng=; b=Hjf/GVycjPjyWJGElx+ngVXPMa19369TcyfTZr5F4cVW+iXkCvILOdtKZigVMNBYC0 2Lz02F31ydxrW3otkrCe8XrQ9iyLW3V81aoE2wmsTRO946Hn8S222nkU8Kd+TMvsBMqT 0eXh62/NYfGFe314Vc6pmpSE+iyXLtjrDppOkI3ltmet38E5NH+oUMPKh7kviZ5QoBaq jlWO7GiPBQV+aWcbmLJbE8Bk5mR6EF1MmJ0kSyQmKbl6KkWHMO0fLWRVPPL8Jqt7bz7H xCiZzNjagzoeAJ2sh4XhhSFIKbcpMhBuwshNtq1YetAuPw1ikOLUJINHdoX2TKkFEh+F TUSQ== X-Gm-Message-State: AJcUukeRLjJwGdCsvJ9B/l8wLM91P3SNHmeOdfFvN+XtrA5Jx7axrNNH a1MByetawi7xuFMxS4M2IscORNVFCtPBSosFjuP4ZA== X-Google-Smtp-Source: ALg8bN4ibOymuuRBm3D86IZVuAM2FFbH6EzXsvK98+N7BUbSu8HDkf4WuJcRkMYaSeshsnqWYDfOc487iMnQZpWw1Fg= X-Received: by 2002:a1f:b58d:: with SMTP id e135mr3849625vkf.86.1547123346586; Thu, 10 Jan 2019 04:29:06 -0800 (PST) MIME-Version: 1.0 References: <20190110111104.56464-1-bruce.richardson@intel.com> In-Reply-To: <20190110111104.56464-1-bruce.richardson@intel.com> From: David Marchand Date: Thu, 10 Jan 2019 13:28:54 +0100 Message-ID: To: Bruce Richardson Cc: dev@dpdk.org, Thomas Monjalon , "Burakov, Anatoly" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] compat: merge compat library into EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 12:29:07 -0000 On Thu, Jan 10, 2019 at 12:12 PM Bruce Richardson < bruce.richardson@intel.com> wrote: > Since compat library is only a single header, we can easily move it into > the EAL common headers instead of tracking it separately. The downside of > this is that it becomes a little more difficult to have any libs that are > built before EAL depend on it. Thankfully, this is not the case, so there > are no big complications to the move. > > However, to ensure that we don't later hit problems later with this, we can > add EAL common headers folder to the global include list in the meson build > which means that all common headers can be safely used by all libraries, no > matter what their build order. > > Signed-off-by: Bruce Richardson > Currently testing this patch, I just noticed some remaining traces of librte_compat: [dmarchan@dmarchan dpdk]$ git grep librte_compat MAINTAINERS:F: lib/librte_compat/ doc/api/doxy-api.conf.in: @TOPDIR@/lib/librte_compat \ doc/guides/contributing/documentation.rst: |-- librte_compat doc/guides/contributing/versioning.rst:To support backward compatibility the ``lib/librte_compat/rte_compat.h`` and librte_compat_netmap does not exist: examples/netmap_compat/bridge/bridge.c: "Couldn't initialize librte_compat_netmap\n"); examples/netmap_compat/bridge/bridge.c: printf("librte_compat_netmap initialized\n"); -- David Marchand