From: David Marchand <david.marchand@redhat.com>
To: Stanislaw Kardach <kda@semihalf.com>
Cc: dev <dev@dpdk.org>, Frank Zhao <Frank.Zhao@starfivetech.com>,
Sam Grove <sam.grove@sifive.com>,
Marcin Wojtas <mw@semihalf.com>,
upstream@semihalf.com, Pavan Nikhilesh <pbhagavatula@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH v2 1/1] examples/l3fwd: fix scalar LPM compilation
Date: Mon, 23 May 2022 15:29:09 +0200 [thread overview]
Message-ID: <CAJFAV8zk3HxbOQ8KJOKyCy30e3w1sE2FWo2WY-3g4b+=QziBfA@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8xnvTjBV3NX=AZ74Xpp7wPJL8x-2+CEWBXvpU+Ckdfr0g@mail.gmail.com>
On Thu, May 19, 2022 at 4:53 PM David Marchand
<david.marchand@redhat.com> wrote:
> On Wed, May 11, 2022 at 4:57 PM Stanislaw Kardach <kda@semihalf.com> wrote:
> >
> > The lpm_process_event_pkt() can either process a packet using an
> > architecture specific (defined for X86/SSE, ARM/Neon and PPC64/Altivec)
> > path or a scalar one. The choice is however done using an ifdef
> > pre-processor macro. Because of that the scalar version was apparently
> > not widely excersized/compiled.
> > Due to some copy/paste errors, the scalar logic in
> > lpm_process_event_pkt() retained a "continue" statement where it should
> > utilize rfc1812_process() and return the port/BAD_PORT.
> >
> > Fixes: 99fc91d18082 ("examples/l3fwd: add event lpm main loop")
Cc: stable@dpdk.org
> >
> > Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2022-05-23 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 11:58 [PATCH " Stanislaw Kardach
2022-05-11 11:38 ` David Marchand
2022-05-11 14:18 ` Stanisław Kardach
2022-05-11 14:56 ` [PATCH v2 " Stanislaw Kardach
2022-05-19 14:53 ` David Marchand
2022-05-23 13:29 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zk3HxbOQ8KJOKyCy30e3w1sE2FWo2WY-3g4b+=QziBfA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=Frank.Zhao@starfivetech.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kda@semihalf.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mw@semihalf.com \
--cc=pbhagavatula@marvell.com \
--cc=sam.grove@sifive.com \
--cc=upstream@semihalf.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).