From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F03DA00C2; Mon, 23 May 2022 15:29:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F1374014F; Mon, 23 May 2022 15:29:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6D5A540141 for ; Mon, 23 May 2022 15:29:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653312563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=htWcH5OitAJe/Nn9EbfOzDaBMK+QLBFpFGTxOvgjfC0=; b=XKL1oagPs1IPPlBbLIGopa8tzXCXVfiWhhWRJhnN9YF2vAtqBP7a1SV11gg+u33kUu+0k+ 2zQdQIgd8X+llxgU7Auxa2decAyb1q1M4xNhpoGNzrgUpAxhTk8U1A9xZYnTPJJnjHrGTr mqjuvz2wrkP4E1RJ4BPRRv6VqX7DI9E= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-8XSEh8VMPP2CWqJe2CB6Uw-1; Mon, 23 May 2022 09:29:22 -0400 X-MC-Unique: 8XSEh8VMPP2CWqJe2CB6Uw-1 Received: by mail-lj1-f198.google.com with SMTP id o23-20020a2e9b57000000b00253e47e6e97so815568ljj.15 for ; Mon, 23 May 2022 06:29:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=htWcH5OitAJe/Nn9EbfOzDaBMK+QLBFpFGTxOvgjfC0=; b=lxhvPJzo83L8jL2K08lQ9TxMKkmDImBRyYwGZhhJQMPjnAuKVmJBjJ63DT7RgGJ0ph VGtMTJFWkI+judZNzdVU1rNzJPI0ar0nmSk2sz+pK2CYXm55ztzyn4X1QO7saq4kBxAE FMebIYVpmo+JFE0dG0vKg4TJGvr5Q1HT36PludRMmqlWwOQOaCgHHA8gnV/VY2cLTXJw cCATMxRzlUXRaG93z9u1XBDlmnfC9oKYQofwFUZfmSaYroBnKhoVvokaKk1N4uIw6vlI 8e5+KC6xJDdteHuxHhnUS610QQUi1Vy82TaWcVVKToY4xLEqxDfc7BH/UvH/vJKcISPb KOfg== X-Gm-Message-State: AOAM531g8Op2Hxvxw+b4CCSGrMnryOqE6zuIU1HenCoJsBQnNTTJ3bZS WjHgLFj3FW1o/gmNtN/vNs4ZFBTNgDg1xWp3j7yFLWLvJ0U9w3ewNHCkklQiJeRU9CLl58qpz3K 32ZOvC+tjfvZktgbeIyQ= X-Received: by 2002:a2e:a36f:0:b0:253:d948:731c with SMTP id i15-20020a2ea36f000000b00253d948731cmr11113300ljn.159.1653312560963; Mon, 23 May 2022 06:29:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygX25yK8+wE3AXG8jUhGcWW6O/vLnWBsiPQU7/uluTtfANaZ7lrYkl2URxLMbxs1PYTpAzBgT0ccS7YIJrX5E= X-Received: by 2002:a2e:a36f:0:b0:253:d948:731c with SMTP id i15-20020a2ea36f000000b00253d948731cmr11113288ljn.159.1653312560773; Mon, 23 May 2022 06:29:20 -0700 (PDT) MIME-Version: 1.0 References: <20220510115844.458009-1-kda@semihalf.com> <20220511145650.742535-1-kda@semihalf.com> In-Reply-To: From: David Marchand Date: Mon, 23 May 2022 15:29:09 +0200 Message-ID: Subject: Re: [PATCH v2 1/1] examples/l3fwd: fix scalar LPM compilation To: Stanislaw Kardach Cc: dev , Frank Zhao , Sam Grove , Marcin Wojtas , upstream@semihalf.com, Pavan Nikhilesh , Jerin Jacob Kollanukkaran , Konstantin Ananyev , Vladimir Medvedkin Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 19, 2022 at 4:53 PM David Marchand wrote: > On Wed, May 11, 2022 at 4:57 PM Stanislaw Kardach wrote: > > > > The lpm_process_event_pkt() can either process a packet using an > > architecture specific (defined for X86/SSE, ARM/Neon and PPC64/Altivec) > > path or a scalar one. The choice is however done using an ifdef > > pre-processor macro. Because of that the scalar version was apparently > > not widely excersized/compiled. > > Due to some copy/paste errors, the scalar logic in > > lpm_process_event_pkt() retained a "continue" statement where it should > > utilize rfc1812_process() and return the port/BAD_PORT. > > > > Fixes: 99fc91d18082 ("examples/l3fwd: add event lpm main loop") Cc: stable@dpdk.org > > > > Signed-off-by: Stanislaw Kardach > Reviewed-by: David Marchand Applied, thanks. -- David Marchand