From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11FEB45561; Wed, 3 Jul 2024 14:11:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1E4E40E7C; Wed, 3 Jul 2024 14:11:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 012D44029E for ; Wed, 3 Jul 2024 14:11:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720008699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nxO3K1epMuIoantuvEIvKrjqoxb4RnyCw0JI6hmI08Y=; b=S7VETOmTPr18diMq0kE2qSNFSLtekW3oiSgAMGuAaQXTWjKcRqOGxHwrStoURD2Xd8sKFC 0XAP0Qur3Z79RDdPrPPGUQRk2IzW2ME+NjGW1MnvvrGdhtE5TVJtjPqJDg6a6FYgIt4wq1 T9Uzv8mF4OeYwvHMkiDf8AjsX7fk2e4= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-32-gyes48CbPKaXvDjgprOHCg-1; Wed, 03 Jul 2024 08:11:38 -0400 X-MC-Unique: gyes48CbPKaXvDjgprOHCg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ee864483c2so5712111fa.2 for ; Wed, 03 Jul 2024 05:11:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720008697; x=1720613497; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nxO3K1epMuIoantuvEIvKrjqoxb4RnyCw0JI6hmI08Y=; b=t9r/MJV37qhrpWADlaVPrvyuSygnHmPoABBICSNi5+TnGG2U3HoSI9ULEdKMYnDX2L aR+f54n4YXCxG9HMZXhMaEKkqk9seI+lrKrPO8uhBqKbGlpg/tTJ+TPrHsxKOriNw6C3 uPJr4bn+wtI3mMlCJz6SLwXH3iJOXY3hg1FuEkAz4TFXz9VeJFaxBJhDjHndAp8kSRV5 bafzsD0aMr5AUoLuVQREMtvXaZGrtScm99dNXGzVEMeT6balKQEpT64gvWxkOY74iq51 zOJVElEdJqOdNoQ2mafQA8GB9Iqn0TgXrkJbdYzwkPQnnmCrBcbpFWdw+OLvGXgkbu2C 0BaQ== X-Forwarded-Encrypted: i=1; AJvYcCXYi5G1JNSFwNC7hJOVO4WX0fjbETP9/RpR9bYcD8MaS2ugUWzdrvkcaNeGfRJx3e5uJTOwZMwkQTxwkmA= X-Gm-Message-State: AOJu0YzXrACv60MCLNxej3gUtsIbgo/r7RRx825UouhLQTBfyQ2CvXDp T8xc/vZsaY+g/kcIcABIS9xQmsBe1oLsgwWqpGwv8mw8ZTtlBiOpbtSxjwkKpq4Fl7pPKOc+ElG jpEEU2G9xR7VIV/ayo+ippx+/J+P8go0E37p2gNPm6oBdzS2lILzYPSk8R+DJ40E4s0NbaSI+9m dC2wk7sMuZUobo16w= X-Received: by 2002:a2e:a98d:0:b0:2ec:5621:b9f2 with SMTP id 38308e7fff4ca-2ee5e6f26b4mr88298571fa.41.1720008696836; Wed, 03 Jul 2024 05:11:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyzktaSmCvX5/RyRKhm6vY2VIRgZfViEBl0xrKp8K1L9nM+O3zchWFFSSFTB26HgAokOXMNtH5pZU6ER+JMPo= X-Received: by 2002:a2e:a98d:0:b0:2ec:5621:b9f2 with SMTP id 38308e7fff4ca-2ee5e6f26b4mr88298411fa.41.1720008696471; Wed, 03 Jul 2024 05:11:36 -0700 (PDT) MIME-Version: 1.0 References: <20240702104013.3813272-1-hemant.agrawal@nxp.com> <20240702130856.3927348-1-hemant.agrawal@nxp.com> In-Reply-To: From: David Marchand Date: Wed, 3 Jul 2024 14:11:24 +0200 Message-ID: Subject: Re: [PATCH v3 1/3] drivers: replace printf with log macros To: Hemant Agrawal Cc: Hemant Agrawal , dev@dpdk.org, thomas@monjalon.net, stephen@networkplumber.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jul 3, 2024 at 2:03=E2=80=AFPM Hemant Agrawal wrote: > >> diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_et= hdev.c > >> index 935a4f2ada..bcd19f31fb 100644 > >> --- a/drivers/net/dpaa/dpaa_ethdev.c > >> +++ b/drivers/net/dpaa/dpaa_ethdev.c > >> @@ -282,9 +282,9 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev) > >> dpaa_interrupt_handler, > >> (void *)dev); > >> if (ret =3D=3D EINVAL) > >> - printf("Failed to enable inter= rupt: Not Supported\n"); > >> + DPAA_PMD_ERR("Failed to enable= interrupt: Not Supported\n"); > >> else > >> - printf("Failed to enable inter= rupt\n"); > >> + DPAA_PMD_ERR("Failed to enable= interrupt\n"); > > DPAA_PMD_ERR appends a \n, so \n should be removed here. > > > > There are double \n in this driver prior to this patch, can you fix the= m too? > > It is probably worth checking other NXP drivers on this topic. > will fix this in v4 and for the time being I am fixing it for dpaa set > of drivers in 2nd patch of this series. Rest will follow as a separate > patch. Ok, thanks. --=20 David Marchand