From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com
 [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id E8C2D1B63D
 for <dev@dpdk.org>; Thu, 10 Jan 2019 13:53:31 +0100 (CET)
Received: by mail-vs1-f66.google.com with SMTP id n10so6890331vso.13
 for <dev@dpdk.org>; Thu, 10 Jan 2019 04:53:31 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=FubQmrthuEy4dw69/OZY0669UuYDV0OgWwBhMiHeSs4=;
 b=haEogOKk/GDYnVw9+LQEAqYqD8R9TXPp9mFznd8SVYWVsu+Z3/LkUyH7sYCQeuhtQ7
 /7kPZpNqAwakNFJWYmfyy7h21c1gdR4LZBTvXicGOraskInW9FOrmrm3hzoB9VbPqnR2
 eNU6weQV1d64amBrCLOZ9BnwQGnUvY3PW7vi5TTItuVtwRjnuXO+A/yORNQx6CffoPd3
 9TkMAA5kRjf0EM5u4uN+KpcwbGo9eUeQenz1qpp9hBbcVq5DphRAAMSys9i5WVSxsI8A
 WbP1FChrbgk5IUip3qbwJwPPqkWrle8RSWVS3j7wUC8hs27g2WFXvn0+rCfQ2NNjsBtJ
 xtSA==
X-Gm-Message-State: AJcUukd43Q7nVB7WMr316dkCT5pudWfsFmoib7MKAo4+f6RAMOVCj84c
 VgefVw30897AiCDzXR3rqpo6VAXLA214pF/nr+9jRg==
X-Google-Smtp-Source: ALg8bN7Il8N4JiZzk7sNFB1clfxXmzTofhFql8KB09y5qCQYhZ91dxZ0MG1CGy0RdHOkRP6PlX2jsbgJWnBwWqrR1ro=
X-Received: by 2002:a67:f085:: with SMTP id i5mr4138638vsl.198.1547124811374; 
 Thu, 10 Jan 2019 04:53:31 -0800 (PST)
MIME-Version: 1.0
References: <20190110111104.56464-1-bruce.richardson@intel.com>
 <CAJFAV8zjbxyKWpNGdd7c3w4cAwdDPPxwXa5u-Dchz_NnsJ+5-w@mail.gmail.com>
In-Reply-To: <CAJFAV8zjbxyKWpNGdd7c3w4cAwdDPPxwXa5u-Dchz_NnsJ+5-w@mail.gmail.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 10 Jan 2019 13:53:20 +0100
Message-ID: <CAJFAV8zkA5e8GqjyZdfBpMvaT8QHSOkj4e+hHUMCsAcPoOc4Ug@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>, 
 "Burakov, Anatoly" <anatoly.burakov@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] compat: merge compat library into EAL
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jan 2019 12:53:32 -0000

On Thu, Jan 10, 2019 at 1:28 PM David Marchand <david.marchand@redhat.com>
wrote:

>
>
> On Thu, Jan 10, 2019 at 12:12 PM Bruce Richardson <
> bruce.richardson@intel.com> wrote:
>
>> Since compat library is only a single header, we can easily move it into
>> the EAL common headers instead of tracking it separately. The downside of
>> this is that it becomes a little more difficult to have any libs that are
>> built before EAL depend on it. Thankfully, this is not the case, so there
>> are no big complications to the move.
>>
>> However, to ensure that we don't later hit problems later with this, we
>> can
>> add EAL common headers folder to the global include list in the meson
>> build
>> which means that all common headers can be safely used by all libraries,
>> no
>> matter what their build order.
>>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>
>
> Currently testing this patch, I just noticed some remaining traces of
> librte_compat:
>

Checked build with make and meson on rhel7.

-- 
David Marchand