From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) by dpdk.org (Postfix) with ESMTP id 5D2C32BD3 for ; Fri, 15 Mar 2019 14:30:17 +0100 (CET) Received: by mail-ua1-f41.google.com with SMTP id s26so3087892uao.9 for ; Fri, 15 Mar 2019 06:30:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sB+6zhUZve5oCpTmAoGBd1j0uxfIIumtMafeOaBSt+M=; b=ChT4WZ+SdNA55JRnwS/X6QSp++O8ySP8+0I/0KxoJv7BDRclZg4eLhiuHs4je/pBgE 0unPzkyo/yRSU1PETgL/KP4qytu7wSdOkk/1Hw9gA5Pnw/2TypMVKkhIkp+R28ntqy7B iz5PmMRnfSRsKpHSEtVcKfjx3tvh3mP49iwHAmHQdjUhZAD4YRON1HzOWbVX4Has85EP IcMMNAUWKkH69jj07wqgJFHqQxEnJV7RNsSQaHcHi3bQkk+ohT/0YvGdWUJerwD0gKS4 dLY7xzs739nKjnloI1iBgpLj0oY6XRMi4TZXnep/9vvTVSWfUVh0HWhXgQMVKG624MeR Vh0w== X-Gm-Message-State: APjAAAVLsnb/b9ZTPEoWQ0EtbxAI65QHpL23CL+k+kybO+0KlRYgwyoj TBEmqa53tKoegxdMr9Uq/V+TLOTk+hHilgqrBhX5H7WD X-Google-Smtp-Source: APXvYqwDRbrU2+8dmKU6ClRQNFKuumfOrKitDYRfUcfFNe/xLLSmf/pHyEg6EwCjv4GOT2h12Fkw68XuSbgby0HA52U= X-Received: by 2002:ab0:3445:: with SMTP id a5mr27733132uaq.130.1552656616553; Fri, 15 Mar 2019 06:30:16 -0700 (PDT) MIME-Version: 1.0 References: <1552576396-19906-1-git-send-email-david.marchand@redhat.com> In-Reply-To: <1552576396-19906-1-git-send-email-david.marchand@redhat.com> From: David Marchand Date: Fri, 15 Mar 2019 14:30:05 +0100 Message-ID: To: dev Cc: "Yigit, Ferruh" , Thomas Monjalon , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 13:30:17 -0000 On Thu, Mar 14, 2019 at 4:13 PM David Marchand wrote: > Introduce a new api to retrieve per queue statistics from the drivers. > The api objectives: > - easily add some common per queue statistics and have it exposed > through the user xstats api while the user stats api is left untouched > - remove the limitations on the per queue statistics count (inherited > from ixgbe) and avoid recurrent bugs on stats array overflow > I have looked at more drivers. I will try to handle the case where drivers are only keeping tracks of per q stats and aggregate then when called by .stats_get. The drivers with hw counters would need both .stats_get and per q functions, so I need to accomodate with this. v2 rfc for next week unless someone totally disagrees with the approach before :-) -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 719CDA0096 for ; Fri, 15 Mar 2019 14:30:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 63C3C2C17; Fri, 15 Mar 2019 14:30:19 +0100 (CET) Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) by dpdk.org (Postfix) with ESMTP id 5D2C32BD3 for ; Fri, 15 Mar 2019 14:30:17 +0100 (CET) Received: by mail-ua1-f41.google.com with SMTP id s26so3087892uao.9 for ; Fri, 15 Mar 2019 06:30:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sB+6zhUZve5oCpTmAoGBd1j0uxfIIumtMafeOaBSt+M=; b=ChT4WZ+SdNA55JRnwS/X6QSp++O8ySP8+0I/0KxoJv7BDRclZg4eLhiuHs4je/pBgE 0unPzkyo/yRSU1PETgL/KP4qytu7wSdOkk/1Hw9gA5Pnw/2TypMVKkhIkp+R28ntqy7B iz5PmMRnfSRsKpHSEtVcKfjx3tvh3mP49iwHAmHQdjUhZAD4YRON1HzOWbVX4Has85EP IcMMNAUWKkH69jj07wqgJFHqQxEnJV7RNsSQaHcHi3bQkk+ohT/0YvGdWUJerwD0gKS4 dLY7xzs739nKjnloI1iBgpLj0oY6XRMi4TZXnep/9vvTVSWfUVh0HWhXgQMVKG624MeR Vh0w== X-Gm-Message-State: APjAAAVLsnb/b9ZTPEoWQ0EtbxAI65QHpL23CL+k+kybO+0KlRYgwyoj TBEmqa53tKoegxdMr9Uq/V+TLOTk+hHilgqrBhX5H7WD X-Google-Smtp-Source: APXvYqwDRbrU2+8dmKU6ClRQNFKuumfOrKitDYRfUcfFNe/xLLSmf/pHyEg6EwCjv4GOT2h12Fkw68XuSbgby0HA52U= X-Received: by 2002:ab0:3445:: with SMTP id a5mr27733132uaq.130.1552656616553; Fri, 15 Mar 2019 06:30:16 -0700 (PDT) MIME-Version: 1.0 References: <1552576396-19906-1-git-send-email-david.marchand@redhat.com> In-Reply-To: <1552576396-19906-1-git-send-email-david.marchand@redhat.com> From: David Marchand Date: Fri, 15 Mar 2019 14:30:05 +0100 Message-ID: To: dev Cc: "Yigit, Ferruh" , Thomas Monjalon , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190315133005.-3xtsLQuGMOcJYj1qkGfmZ4wgvh056iwWhwi1zL67bc@z> On Thu, Mar 14, 2019 at 4:13 PM David Marchand wrote: > Introduce a new api to retrieve per queue statistics from the drivers. > The api objectives: > - easily add some common per queue statistics and have it exposed > through the user xstats api while the user stats api is left untouched > - remove the limitations on the per queue statistics count (inherited > from ixgbe) and avoid recurrent bugs on stats array overflow > I have looked at more drivers. I will try to handle the case where drivers are only keeping tracks of per q stats and aggregate then when called by .stats_get. The drivers with hw counters would need both .stats_get and per q functions, so I need to accomodate with this. v2 rfc for next week unless someone totally disagrees with the approach before :-) -- David Marchand