From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C82AA055D; Wed, 3 Mar 2021 09:18:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A44140696; Wed, 3 Mar 2021 09:18:09 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 7956440693 for ; Wed, 3 Mar 2021 09:18:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614759486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HwH6OuxPeneHraAVAa2ZOGfVNrO32wQZ75KbaKy5nOE=; b=MqTmDDoMwIyadZpw3e6vgukk4ZBqLLp7W15KjyJ0fkWa6XfcLKVf5Zo84Nv/m6YH33Yr6V pS3KA8V/KfEhRT4umH07RaX6KqffoD2LJn+YzihccDB9K4ViLSsyC8qNlKoxyj75DBhgfH z2nQ/LFGEFSmJNNjlETwpYOlPUw//rM= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-592-UWvB0qn4N76h_K4sO0N1Qg-1; Wed, 03 Mar 2021 03:18:04 -0500 X-MC-Unique: UWvB0qn4N76h_K4sO0N1Qg-1 Received: by mail-vs1-f72.google.com with SMTP id v133so2516311vsv.22 for ; Wed, 03 Mar 2021 00:18:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HwH6OuxPeneHraAVAa2ZOGfVNrO32wQZ75KbaKy5nOE=; b=Y35OF9f+/drgye8s2PDbfDzZZ6VD3gXYHWwrQQt3EamXEa9yWtZzwdVNY+2DfQr738 OuTJQ2yDWnm65IBga1NlWW0oBrsfceKl6mbHWMfZe1hk6YvJmcnYwKTVTXiuTjPKG1n2 v+mUPf6VhSShKbZtQTy/YWI8ASI3YoV9kma45FAe0K5R0Uni+W8C2gatCgbr+z2X8dFw ZnWAz6yNFrB7y9y24mc6w/2sGoM6m7sxVr8xFzClecyGPkkR/3Vq5f4z2qMzyMQ9wKef PDtwuQMNsFXFc5ZThYhCEzQ0Q9ii7JB2a1PxV5dPLTMfSCNWYCCa8mplWJ6F5h4+OM/P 9FHQ== X-Gm-Message-State: AOAM5301k/SluXRVWBYSbL2IPEbq3WLXm+REa/gae84AISspvvmFFH2Y HAtff4kvkVSmkqmwYecz+loIACZApwrfSVsVz9f8yadWp8bvm/OqQtel7fUJKBUbqml6kK7Xo41 OoDv7ycVVOEjE5Ba8MHw= X-Received: by 2002:ac5:ccc4:: with SMTP id j4mr1088005vkn.18.1614759484001; Wed, 03 Mar 2021 00:18:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxuqxE7HBQPvXezQk8ta+KazIrzzV0ZKKKOR/EjaCLKBCy8f4vVebhC+L5MsZvSJrWu6XuZpA/IAJdbb3lfSdE= X-Received: by 2002:ac5:ccc4:: with SMTP id j4mr1088000vkn.18.1614759483715; Wed, 03 Mar 2021 00:18:03 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 3 Mar 2021 09:17:52 +0100 Message-ID: To: Anatoly Burakov , Andrew Rybchenko Cc: dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov wrote: > > When file truncation fails, the log message attempts to print a path of > file we failed to truncate, but this path was never set to anything and, > what's worse, was uninitialized. Fix it by passing path from the caller. > > Fixes: c44d09811b40 ("eal: add shared indexed file-backed array") > Cc: stable@dpdk.org > Coverity ID: 366122 > > Signed-off-by: Anatoly Burakov Andrew had reported it too, and proposed something close: http://patchwork.dpdk.org/project/dpdk/patch/20201211170615.32827-1-aboyer@pensando.io/ I prefer Anatoly's version. If no one objects, I'll proceed with this one. -- David Marchand