From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4379BA04B5; Sun, 1 Nov 2020 10:16:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2933E9AFD; Sun, 1 Nov 2020 10:16:37 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 31FC07CAE for ; Sun, 1 Nov 2020 10:16:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604222192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iW7eD7rDQIY9xV2EDq6kFi0FLOsfauVwgQHxv8ZGnqM=; b=KlqhoXjYivDdiSoNxATjBuWmvRq+vbirOSD/949UF6n3mzCwj4pbHAH1y8M6dP5x57vue5 DqnI7YVAR6XKdcPGjO8qaEvhj3CtvhWjxiUDKseLH9aw+cHZw/08jRs+KRw/x13ufVFoka xWZyNJkbHUv5ODIZIbDfH/KWP9p3Fcg= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-130-6SDD9ipSOeK51rpYGQhuVA-1; Sun, 01 Nov 2020 04:16:30 -0500 X-MC-Unique: 6SDD9ipSOeK51rpYGQhuVA-1 Received: by mail-vs1-f70.google.com with SMTP id c22so3430229vsp.16 for ; Sun, 01 Nov 2020 01:16:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iW7eD7rDQIY9xV2EDq6kFi0FLOsfauVwgQHxv8ZGnqM=; b=iHuoEGRGqAh+hESsTGaHIcWA4KMlI7YxzOZ1oHzcCDTPxgw9tVEJ0TQTlCMbXZWvwE NswZfQ4fGJORSUL+SiMBLnHVIUIxMLvKjMA4SQ4a64UqB8wUwYygaHllHyYtGSYDviss xRTf88euDz/Dukcfv0sHuLdYDKpsBO5VqheYbxr/2u7HK1Inlwfm+0wJXvu3fjRPlOXZ +6GEnxrR1vaj3S6vNgqVsK1u5ccmZrLzLQzQzKYSyK5kl5RwoV8kUm3eIzsylP/MDUiE d64MWpfGlcRzWuAUna0u3lbdnev/+UpRphbJU5znNx7wAJUdCn2Wu1YLRq9VEiSU79Gw ajKw== X-Gm-Message-State: AOAM531e0VDe7N1xLm5QgIRRf6S2BATmTVNwb+GAclD+xRVf9zCcleC6 frF4G34idE3kd1RyMZw1vUkJrj5bSzrr+/VBKIeE1KabEkJXv/NiT2HDO6tLajvzPHDDdwKfedG 6dF6F0+NottJLrzRMuBA= X-Received: by 2002:ab0:4983:: with SMTP id e3mr5501064uad.41.1604222189697; Sun, 01 Nov 2020 01:16:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJxBIUoJcUaM0jdHT0ftUmzdldFlAX6LI/vvFsLG2ANrBGFHV7j1Lf9aHe0eNYOTVM/j2ekLiH8HLFDoa1lt1d4= X-Received: by 2002:ab0:4983:: with SMTP id e3mr5501058uad.41.1604222189411; Sun, 01 Nov 2020 01:16:29 -0800 (PST) MIME-Version: 1.0 References: <20200612212434.6852-2-timothy.mcdaniel@intel.com> <1604168282-30079-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: From: David Marchand Date: Sun, 1 Nov 2020 10:16:18 +0100 Message-ID: To: "McDaniel, Timothy" Cc: dev , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , Jerin Jacob Kollanukkaran , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v14 00/23] Add DLB PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Oct 31, 2020 at 11:25 PM McDaniel, Timothy wrote: > > I still see a build error with clang for unused stuff. > > > > There is no point in sending a new series unless the clang build is > > fixed once and for all. > > > Where do I find the clang output? I followed the links in the 0-day email= , and from patchwork clicking on the patches with the red failure indicator= , > but none of those seemed to lead me to any clang error output. My build s= erver does not have clang, which presents a problem > for me. I've tried to use gcc -Wunused and it failed to catch anything. = Is there a way for me to submit a clang job to a dpdk server. I did not think that installing clang was such a hurdle... You could check this with per patch compilation in Travis but that would be a waste of cpu/time. I guess the reason why gcc does not complain is because those symbols are marked with inline. """ -Wunused-function Warn whenever a static function is declared but not defined or a non-inline static function is unused. This warning is enabled by -Wall. """ Please remove "inline" in all .c unless you have numbers showing it has a beneficial impact. Looking with the whole patchset applied: $ git grep -w inline 'drivers/event/dlb/**.c' drivers/event/dlb/dlb.c:static inline uint16_t drivers/event/dlb/dlb.c:static inline uint16_t drivers/event/dlb/dlb.c:static inline uint16_t drivers/event/dlb/dlb.c:static inline uint16_t drivers/event/dlb/dlb.c:static inline int drivers/event/dlb/dlb.c:static inline void drivers/event/dlb/dlb.c:static inline int drivers/event/dlb/dlb.c:static inline int drivers/event/dlb/dlb.c:static inline int drivers/event/dlb/dlb.c:static inline void drivers/event/dlb/dlb.c:static inline void drivers/event/dlb/dlb.c:static inline void drivers/event/dlb/dlb.c:static inline int drivers/event/dlb/dlb.c:static inline uint16_t drivers/event/dlb/dlb.c:static inline uint16_t drivers/event/dlb/dlb.c:static inline uint16_t drivers/event/dlb/dlb.c:static inline uint16_t drivers/event/dlb/dlb.c:static inline uint16_t drivers/event/dlb/dlb.c:static inline void drivers/event/dlb/dlb.c:static inline int drivers/event/dlb/dlb.c:static inline int drivers/event/dlb/dlb.c:static inline int drivers/event/dlb/dlb.c:static inline int16_t drivers/event/dlb/dlb.c:static inline int16_t drivers/event/dlb/dlb_selftest.c:static inline int drivers/event/dlb/dlb_selftest.c:static inline int drivers/event/dlb/dlb_selftest.c:static inline int drivers/event/dlb/dlb_selftest.c:static inline int drivers/event/dlb/dlb_selftest.c:static inline int drivers/event/dlb/dlb_selftest.c:static inline int drivers/event/dlb/pf/base/dlb_resource.c:static inline void dlb_flush_csr(struct dlb_hw *hw) Stopping at 84be92444bb9 ("event/dlb: add dequeue and its burst variants"), then removing those inline tokens, the problem is reproduced even with gcc: FAILED: drivers/a715181@@tmp_rte_event_dlb@sta/event_dlb_dlb.c.o ccache gcc -Idrivers/a715181@@tmp_rte_event_dlb@sta -Idrivers -I../../dpdk/drivers -Idrivers/event/dlb -I../../dpdk/drivers/event/dlb -Ilib/librte_eventdev -I../../dpdk/lib/librte_eventdev -I. -I../../dpdk/ -Iconfig -I../../dpdk/config -Ilib/librte_eal/include -I../../dpdk/lib/librte_eal/include -Ilib/librte_eal/linux/include -I../../dpdk/lib/librte_eal/linux/include -Ilib/librte_eal/x86/include -I../../dpdk/lib/librte_eal/x86/include -Ilib/librte_eal/common -I../../dpdk/lib/librte_eal/common -Ilib/librte_eal -I../../dpdk/lib/librte_eal -Ilib/librte_kvargs -I../../dpdk/lib/librte_kvargs -Ilib/librte_telemetry/../librte_metrics -I../../dpdk/lib/librte_telemetry/../librte_metrics -Ilib/librte_telemetry -I../../dpdk/lib/librte_telemetry -Ilib/librte_ring -I../../dpdk/lib/librte_ring -Ilib/librte_ethdev -I../../dpdk/lib/librte_ethdev -Ilib/librte_net -I../../dpdk/lib/librte_net -Ilib/librte_mbuf -I../../dpdk/lib/librte_mbuf -Ilib/librte_mempool -I../../dpdk/lib/librte_mempool -Ilib/librte_meter -I../../dpdk/lib/librte_meter -Ilib/librte_hash -I../../dpdk/lib/librte_hash -Ilib/librte_rcu -I../../dpdk/lib/librte_rcu -Ilib/librte_timer -I../../dpdk/lib/librte_timer -Ilib/librte_cryptodev -I../../dpdk/lib/librte_cryptodev -Ilib/librte_pci -I../../dpdk/lib/librte_pci -Idrivers/bus/pci -I../../dpdk/drivers/bus/pci -I../../dpdk/drivers/bus/pci/linux -I/home/dmarchan/intel-ipsec-mb/install/include -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O2 -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Dnative -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -MD -MQ 'drivers/a715181@@tmp_rte_event_dlb@sta/event_dlb_dlb.c.o' -MF 'drivers/a715181@@tmp_rte_event_dlb@sta/event_dlb_dlb.c.o.d' -o 'drivers/a715181@@tmp_rte_event_dlb@sta/event_dlb_dlb.c.o' -c ../../dpdk/drivers/event/dlb/dlb.c ../../dpdk/drivers/event/dlb/dlb.c:2784:1: error: =E2=80=98dlb_event_enqueue_forward_burst_delayed=E2=80=99 defined but not u= sed [-Werror=3Dunused-function] 2784 | dlb_event_enqueue_forward_burst_delayed(void *event_port, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../dpdk/drivers/event/dlb/dlb.c:2768:1: error: =E2=80=98dlb_event_enqueue_new_burst_delayed=E2=80=99 defined but not used [-Werror=3Dunused-function] 2768 | dlb_event_enqueue_new_burst_delayed(void *event_port, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../dpdk/drivers/event/dlb/dlb.c:2753:1: error: =E2=80=98dlb_event_enqueue_delayed=E2=80=99 defined but not used [-Werror=3Dunused-function] 2753 | dlb_event_enqueue_delayed(void *event_port, | ^~~~~~~~~~~~~~~~~~~~~~~~~ ../../dpdk/drivers/event/dlb/dlb.c:2738:1: error: =E2=80=98dlb_event_enqueue_burst_delayed=E2=80=99 defined but not used [-Werror=3Dunused-function] 2738 | dlb_event_enqueue_burst_delayed(void *event_port, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors ninja: build stopped: subcommand failed. --=20 David Marchand