From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36A82A00C2; Mon, 26 Sep 2022 13:53:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 263DA4069B; Mon, 26 Sep 2022 13:53:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8428C40695 for ; Mon, 26 Sep 2022 13:52:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664193179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3yMI0BdXYNpE5YCMDgv3WT5GmhabdFFN69b/pAES0Xw=; b=DwRO+JMYtW0/tmB0eWCaMjxR8Me58pPtnO94fovVwuSINF5SmCry4lphiXhMgXX8qXH3aO gL5RJVGnUmaYbkoN7yGmGUREIg2JhOnLKwBJKKylTR3qMKEJbw9oCRbl0774PKCbhOxiy2 7l5d/z0cPSnFwr/SymGShBUGI88hZrY= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-296-ke5_-lFaNumKpMGd180nnw-1; Mon, 26 Sep 2022 07:52:57 -0400 X-MC-Unique: ke5_-lFaNumKpMGd180nnw-1 Received: by mail-ej1-f72.google.com with SMTP id sa15-20020a1709076d0f00b00781d793f51fso1967268ejc.18 for ; Mon, 26 Sep 2022 04:52:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=3yMI0BdXYNpE5YCMDgv3WT5GmhabdFFN69b/pAES0Xw=; b=wTWro9C+qw7MYBOaPne2uo9VtJjomrnVSSUbUbBAzZp4miLGrZjtkAVlTgXDK/rKN+ A9atr2lISn9GhSj7UV8tppg9qoK6hIIWiGA4zsEvizVc46kAwxW+JyS2OrKNlsfYfQE+ S/l9XyWhFpG+qvm6WC2aQlWC5pL2KLbdzhLkhn2bj4f3AL9n91nAqs489Ow6LN0uPq+k pLYmO3jfJFnmpSsghhy0xLCUSGthdr3skQ0HO0arf7Og7CIQLITEkzqa1LovA4GIw9+r V7gAOzaT/lse4QtkJIGMIJTEjtBofR1MiqgKh8698keoKOsmlSPjZmnn+UsQ6eN3Zla/ DX3w== X-Gm-Message-State: ACrzQf3JiHEX41YxD7sVjJ4ETAkj96CigNRAC/2EXdh1EJxYMsj/Xvhc inJhtd16nHmS1yJ/9An5Lw/XsDlNAbK/F6m+yM3WaSKsDiXNV1sJ/WUFOMlcumYga6AvaIRYxp6 obW4VDnpOmyJXzkj+toU= X-Received: by 2002:a05:6402:1c0e:b0:457:4f32:fcd5 with SMTP id ck14-20020a0564021c0e00b004574f32fcd5mr3882652edb.75.1664193176909; Mon, 26 Sep 2022 04:52:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5ifiZauyu23Ac8Rne25TNDq7G9gcwnbq5hfNPGGP6izTlpHJlxKu2lrnA4XeUl4X9PqP7KurCqd3m8lJ3uhRY= X-Received: by 2002:a05:6402:1c0e:b0:457:4f32:fcd5 with SMTP id ck14-20020a0564021c0e00b004574f32fcd5mr3882640edb.75.1664193176707; Mon, 26 Sep 2022 04:52:56 -0700 (PDT) MIME-Version: 1.0 References: <20220623164245.561371-1-bruce.richardson@intel.com> <20220909093523.471727-1-bruce.richardson@intel.com> In-Reply-To: <20220909093523.471727-1-bruce.richardson@intel.com> From: David Marchand Date: Mon, 26 Sep 2022 13:52:45 +0200 Message-ID: Subject: Re: [PATCH v3 00/13] telemetry JSON escaping and other enhancements To: Bruce Richardson Cc: dev@dpdk.org, Ciara Power , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Chengwen Feng X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 9, 2022 at 11:36 AM Bruce Richardson wrote: > > This patchset contains fixes for the problem of handling characters returned by > telemetry callbacks which require escaping when encoded in JSON format. It also > includes unit tests to validate the correct encoding in such scenarios and a > number of smaller enhancements to telemetry and telemetry testing > > V3: > * reorder patchset to put previous patch 6 (dict name limiting) at the > start of the series > * fix missed rename of TEST_OUTPUT to CHECK_OUTPUT in patch 10 > > RFC->V2: > * limited characters allowed in dictionary element names and command > names to side-step the encoding problems there > * added support for proper escaping of dictionary string values > * added more testing and test cases > * added other misc telemetry cleanups and refactoring > > Bruce Richardson (13): > telemetry: limit characters allowed in dictionary names > test/telemetry_json: print success or failure per subtest > telemetry: fix escaping of invalid json characters > test/telemetry_json: add test for string character escaping > telemetry: add escaping of strings in arrays > test/telemetry-json: add test for escaping strings in arrays > telemetry: add escaping of strings in dicts > test/telemetry_json: add test for string escaping in objects > telemetry: limit command characters > test/telemetry_data: refactor for maintainability > test/telemetry_data: add test cases for character escaping > telemetry: eliminate duplicate code for json output > telemetry: make help command more helpful > > app/test/test_telemetry_data.c | 138 +++++++++++++++++++-------- > app/test/test_telemetry_json.c | 98 +++++++++++++++++-- > doc/guides/rel_notes/deprecation.rst | 8 -- > lib/telemetry/rte_telemetry.h | 8 ++ > lib/telemetry/telemetry.c | 51 +++++----- > lib/telemetry/telemetry_data.c | 32 +++++++ > lib/telemetry/telemetry_json.h | 72 ++++++++++++-- > 7 files changed, 318 insertions(+), 89 deletions(-) Updated release notes, and applied, thanks. -- David Marchand