From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAD0DA04C7; Mon, 14 Sep 2020 15:26:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8855E07; Mon, 14 Sep 2020 15:26:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 4FD76160 for ; Mon, 14 Sep 2020 15:26:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600089964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8irc0+g+nVDblfNRk7U12JLkN8YXw+oquqPZh90xXtc=; b=A9GqWXpfgsxvy33Yq7wACWBhpv3HOow6KW32wKzhO2ErflxquyZT20iZO0Lzt59JhseoPk kgF034DOuKs2NE1Z5KIGuOiiY0TuMbQrY8RLBOmNhMJubmq/eBEC8dtDIU6kYKqC7OiEuS 4aI4Z8FjSC7XIX61lUO8mAWDJHnxFzQ= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-579-nxghbBS5MTqsLzDZwT3eRA-1; Mon, 14 Sep 2020 09:26:03 -0400 X-MC-Unique: nxghbBS5MTqsLzDZwT3eRA-1 Received: by mail-ua1-f70.google.com with SMTP id w17so1306420uaj.0 for ; Mon, 14 Sep 2020 06:26:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8irc0+g+nVDblfNRk7U12JLkN8YXw+oquqPZh90xXtc=; b=qJSIH2qrlMnZrBFkNCLqSMFZouz89yGPtEwDAOamtCgTQ+evGyOaNmUybhdtAOYICk ZtPbX3JTkZEE7aboSewp2SnE2TjKNkiQmoyft4EaSj+WMLWwQpGfba6vcgcNtRMeu1ev m4Cfj9u7zwrdt/Jls9++vqsujo7wTI/251V1+C6TfpZl9jMwJvHV9QiPlx/pN7GrB3HQ d6LUCEJXO4zkyL6ytgM/BYJTJAC4/9VQYkHB96BwBrmwl1FvdJMvvYcLs6e+WKC0GnoR 7SVLz4m8wTraf7yy/OiD4LTOSv5ADKt32STWe9dy6ObeLTnlsI9CdbqBIYIS36KBvtpd iHXw== X-Gm-Message-State: AOAM5313NbCsPP8uGtEfh/gCmJ4XEguf2MWHV5pUphs5zX7QYsS9xPhW Xm4i+Gjtc1py5CfcNMyV8Um8Y1OFnQHlBO4SFKNbKJCFI+EYF84dGfsfEKUn2wKJpZd15+dhA4e 0lBU5baP4+areLwPMYpw= X-Received: by 2002:ab0:6054:: with SMTP id o20mr6582189ual.87.1600089962240; Mon, 14 Sep 2020 06:26:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynZlkHNxpIVaOE4+R/UBn0W8R/TUrBXefK5ESOwIaGcmeOlBpygPZUasBFvR5hBoNREcdSRmvTYGe+Q06doz4= X-Received: by 2002:ab0:6054:: with SMTP id o20mr6582176ual.87.1600089961937; Mon, 14 Sep 2020 06:26:01 -0700 (PDT) MIME-Version: 1.0 References: <20200901144826.1978703-1-conor.walsh@intel.com> <20200914125335.272243-1-conor.walsh@intel.com> In-Reply-To: <20200914125335.272243-1-conor.walsh@intel.com> From: David Marchand Date: Mon, 14 Sep 2020 15:25:50 +0200 Message-ID: To: Conor Walsh Cc: dev , "Ananyev, Konstantin" , Akhil Goyal Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] lib/ipsec: remove experimental tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Conor, On Mon, Sep 14, 2020 at 2:54 PM Conor Walsh wrote: > > Since librte_ipsec was first introduced in 19.02 and there were no changes > in it's public API since 19.11, it should be considered mature enough to > remove the 'experimental' tag from it. > The RTE_SATP_LOG2_NUM enum is also being dropped from rte_ipsec_sa.h to > avoid possible ABI problems in the future. > > --- > v2: RTE_SATP_LOG2_NUM dropped from enum Small comments that I guess could be fixed while applying. Commit title prefixes don't start with lib/. > > Signed-off-by: Conor Walsh > --- > MAINTAINERS | 2 +- > doc/guides/rel_notes/release_20_11.rst | 1 + > lib/librte_ipsec/rte_ipsec.h | 8 -------- > lib/librte_ipsec/rte_ipsec_group.h | 3 --- > lib/librte_ipsec/rte_ipsec_sa.h | 8 +------- > lib/librte_ipsec/rte_ipsec_sad.h | 7 ------- > lib/librte_ipsec/rte_ipsec_version.map | 2 +- > 7 files changed, 4 insertions(+), 27 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ed163f5d5..f66772908 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1286,7 +1286,7 @@ M: Jiayu Hu > F: lib/librte_gso/ > F: doc/guides/prog_guide/generic_segmentation_offload_lib.rst > > -IPsec - EXPERIMENTAL > +IPsec > M: Konstantin Ananyev > T: git://dpdk.org/next/dpdk-next-crypto > F: lib/librte_ipsec/ > diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst > index df227a177..b750fcf65 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -100,6 +100,7 @@ ABI Changes > Also, make sure to start the actual text at the margin. > ======================================================= > > +* ipsec: ``RTE_SATP_LOG2_NUM`` has been dropped from ``enum`` There is no ABI compat in this release, and this is an API change. Documentation blocks are separated with double empty lines (like it was before your patch). > > Known Issues > ------------ -- David Marchand