From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 865DCA04BA; Fri, 2 Oct 2020 13:01:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 029721D563; Fri, 2 Oct 2020 13:01:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 592FA1D55F for <dev@dpdk.org>; Fri, 2 Oct 2020 13:01:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601636488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/VuzSi5FhN4S5VKTSrWsA97GrRTgRYSRxFfteHzd+bU=; b=LEm+FZTbkLuSgh1Ek8dbAXyxGs8yFP5rOvcU9pE0g/lhXodUtuaK3eTQWjefuBWdX5bJ6G +x9mwkhgmzYuz7HMBEw5ujdDLcvi6/5bv7P1hfkfFAR68UFhwEeGQOO1haQXvsQinMzq7V +F0SydQf9GWrp71NG0oYDVXZ7RIM+Ik= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-DhC7Xy2tMeaeh72Ksdbm6g-1; Fri, 02 Oct 2020 07:01:26 -0400 X-MC-Unique: DhC7Xy2tMeaeh72Ksdbm6g-1 Received: by mail-vs1-f70.google.com with SMTP id f2so84651vsp.8 for <dev@dpdk.org>; Fri, 02 Oct 2020 04:01:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/VuzSi5FhN4S5VKTSrWsA97GrRTgRYSRxFfteHzd+bU=; b=H2sLgWK+GiP++HONVB74xUvXWcnXclbn5rsJZQe4bopw0VIegGSTNK0MyPiFhlqE8g PDSXDfn7qRGo2Tn7FqO9bn5859xYFHV1iRzeoSQMqsq4Q7Go1l5k7/ozfPcj4JT4F5F7 Q0661+Tk/gHCppj2H7J0khTntaEO2qw7B7yUJ2LuB3BZJ1BipNhymZI2BzHs/KcbGED8 4PT1NDyqgOC5n4YzQ/Uxyb/W/BGQ48zKAYgthQyLV2i/ga2/fFEJPco+FUvaleAb/nye ODEttDw9pQeEMyrkQNTcXKplP+uN2QiUHRFiso9FTgr4g4ny4T5om4fCwPRbRgRgYh+x QPjQ== X-Gm-Message-State: AOAM533Ube68F5mR4ICGfKyKIJxyemIUQasZ7f+3Chth3yeq5is5zYFg 1Osp9wP7qxEMdXuYtGH0OqulJDpCDrvz48JU5icrfNBd1LC+1x4E2hOfI7n3BOFVfovkE0Ay5iT I79bMFHneiyrKpL5SM7I= X-Received: by 2002:ab0:7313:: with SMTP id v19mr466955uao.87.1601636485442; Fri, 02 Oct 2020 04:01:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweloinO+inL1bzRVqg+/V38r0CGba7qpTGSESJeg8dzbaznD3cRcz1+13tRMTsMgum6vDknUvMfiME8gX64Ng= X-Received: by 2002:ab0:7313:: with SMTP id v19mr466925uao.87.1601636485089; Fri, 02 Oct 2020 04:01:25 -0700 (PDT) MIME-Version: 1.0 References: <20200929102224.440322-1-kevin.laatz@intel.com> <20200930114024.446473-1-kevin.laatz@intel.com> <20200930114024.446473-12-kevin.laatz@intel.com> In-Reply-To: <20200930114024.446473-12-kevin.laatz@intel.com> From: David Marchand <david.marchand@redhat.com> Date: Fri, 2 Oct 2020 13:01:13 +0200 Message-ID: <CAJFAV8zn78Ryf3s4ONM0MAc-QMmSuBGx9FhZTTQ0VNfK8sTxmA@mail.gmail.com> To: Kevin Laatz <kevin.laatz@intel.com>, Thomas Monjalon <thomas@monjalon.net>, Bruce Richardson <bruce.richardson@intel.com> Cc: dev <dev@dpdk.org>, "Burakov, Anatoly" <anatoly.burakov@intel.com>, Robin Jarry <robin.jarry@6wind.com>, Stephen Hemminger <stephen@networkplumber.org>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, John McNamara <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>, Timothy Redaelli <tredaelli@redhat.com>, Luca Boccassi <bluca@debian.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v10 11/11] doc: support python3 only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz <kevin.laatz@intel.com> wrote: > diff --git a/doc/guides/conf.py b/doc/guides/conf.py > index 9ebc26ed3f..ef550f68c0 100644 > --- a/doc/guides/conf.py > +++ b/doc/guides/conf.py > @@ -1,7 +1,7 @@ > +#!/usr/bin/env python3 > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2010-2015 Intel Corporation > > -from __future__ import print_function > from docutils import nodes > from distutils.version import LooseVersion > from sphinx import __version__ as sphinx_version > @@ -13,12 +13,7 @@ > from os.path import dirname > from os.path import join as path_join > > -try: > - # Python 2. > - import ConfigParser as configparser > -except: > - # Python 3. > - import configparser > +import configparser I am ok with dropping this part: the doc generation with python 2 / an old sphinx is already broken since 20.02 with meson. I can give details for people interested. > > try: > import sphinx_rtd_theme > diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst > index 0be9546a6a..4fc010ca49 100644 > --- a/doc/guides/contributing/coding_style.rst > +++ b/doc/guides/contributing/coding_style.rst > @@ -765,7 +765,7 @@ specializations, run the ``app/test`` binary, and use the ``dump_log_types`` > Python Code > ----------- > > -All Python code should work with Python 2.7+ and 3.2+ and be compliant with > +All Python code should work with 3.2+ and be compliant with > `PEP8 (Style Guide for Python Code) <https://www.python.org/dev/peps/pep-0008/>`_. I am for dropping any mention of a version here. On current HEAD of the main branch, the requirements already ask for a 3.5 version. I would simply ask for PEP8 compliance in this doc. Opinion? > > The ``pep8`` tool can be used for testing compliance with the guidelines. > diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst > index 6b9f573fce..66d9723dd6 100644 > --- a/doc/guides/linux_gsg/sys_reqs.rst > +++ b/doc/guides/linux_gsg/sys_reqs.rst > @@ -47,7 +47,7 @@ Compilation of the DPDK > > * Python v3.5+ is needed to build DPDK using meson and ninja > > - * Python 2.7+ or 3.2+, to use various helper scripts included in the DPDK package. > + * Python 3.2+, to use various helper scripts included in the DPDK package. Dropped this hunk, as it has already been updated with the "make removal" series. -- David Marchand