From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 356D8A0546; Thu, 16 Jul 2020 10:18:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3B571BEA7; Thu, 16 Jul 2020 10:18:25 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 2BC244F9A for ; Thu, 16 Jul 2020 10:18:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594887504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aow1b2s42xKbEhi7t4Mi57I+jzPRGB6yv0Jm/ErjFcE=; b=ZVtlGCXc5o1CVBJMsiaylb4XbY7+OKzzAeNeLCu+px6+Zjw40ORYNQufk1idZuwbX5RGAM 9v4CuBxRjnF+wj6f5gkEU/E8A7VsSFeLL0gieNsleN00SZf0hB9IKdfxByKPpXnZDkyKtn Hi1e7NCg40eL10qBn4ItxeJ+zaoSumc= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-344-rp8zafzjPtuvYila-tfrDw-1; Thu, 16 Jul 2020 04:18:23 -0400 X-MC-Unique: rp8zafzjPtuvYila-tfrDw-1 Received: by mail-vs1-f72.google.com with SMTP id j16so898226vsj.4 for ; Thu, 16 Jul 2020 01:18:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aow1b2s42xKbEhi7t4Mi57I+jzPRGB6yv0Jm/ErjFcE=; b=JqeymqawNnxfGlA7jxK2jwCGJKpUeCHoelQ5ymv6ZQpLrzobupOx2eIuMJR8m1l4qo jCbjPZggvDLOTfai/tYjIZ2tKbAgQDoOjLDG6MBu4PoZlZ8sJH3EHpUpZoWiTNjdF+T+ QFFn0LUO+2m0Xqsj1ionGMgeTdqbVOou47Wo6p4Zriu4cOow8jz/eyedslP1MzGUlzt9 hYfrrRiSf7M7XyvVKfkgN8bJz7XSid/JIK5EJMG2oT6PBLLNC2jrDsM+LnC0OjMfFMiW Mpj1dCK7h8hNmT5Fdac0ZtTMrhBvBVNLQNY3yWR/PsIudVk8gWRmZFhUE2ZUmIu7PWc0 OSdA== X-Gm-Message-State: AOAM531dVdWIEMrCFEf9vgG6pj0YudXPwc5T9aIDiXqZb7b2llnwAcKI aoxLxz7ya8snUgVZuPygGBrZXKLMejD94Umz4+AZ6ot7LdcJSRh1y29fIDfjEZt8Xj6H99nn33N aALBCumCU0f+GHRTcu6k= X-Received: by 2002:a67:b741:: with SMTP id l1mr2328597vsh.180.1594887502726; Thu, 16 Jul 2020 01:18:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfuRhuHImswat4XwsY/jsqa1ubeeJCnOPk0OsTzGFzZRJD/tLRzti5mwELokETpP/LYrTMGfT8eYB+1XfzdjA= X-Received: by 2002:a67:b741:: with SMTP id l1mr2328588vsh.180.1594887502511; Thu, 16 Jul 2020 01:18:22 -0700 (PDT) MIME-Version: 1.0 References: <20200715171828.95887-1-amorenoz@redhat.com> <20200715171828.95887-5-amorenoz@redhat.com> <506d7594-efd0-ed82-2f3a-6306540c7cc1@redhat.com> In-Reply-To: <506d7594-efd0-ed82-2f3a-6306540c7cc1@redhat.com> From: David Marchand Date: Thu, 16 Jul 2020 10:18:11 +0200 Message-ID: To: Adrian Moreno , "Xia, Chenbo" Cc: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "Wang, Zhihong" , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 16, 2020 at 9:53 AM Adrian Moreno wrote: > >> + if (ret > UINT8_MAX) { > >> + PMD_INIT_LOG(ERR, "Invalid VHOST_USER_GET_STATUS > >> response 0x%" PRIx64 "\n", ret); > > > > There's a coding style issue here: > > CHECK:CAMELCASE: Avoid CamelCase: > > Could you fix this? > > I did see this one as well. It also seems new because PRIx64 is widely used in DPDK. > > find -iname *.c | xargs grep -i "PRIx64" | wc -l > 520 > > So, ether we have to modify the script to ignore this one or change all 520 > cases, right? This is a false positive. We won't drop use of this standard macro because checkpatch is not happy with it. I don't see how to silence this warning but I can see that the kernel uses this macro: so I guess people are simply ignoring this one. -- David Marchand