From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id CB44041E23;
Thu, 9 Mar 2023 22:10:19 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id AA73740ED7;
Thu, 9 Mar 2023 22:10:19 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id 3322540695
for <dev@dpdk.org>; Thu, 9 Mar 2023 22:10:18 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1678396217;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=Bu1FCxZqb0wkqW4CTPh1bgj1dcpPXxODYgwqRU+7Nro=;
b=SXBYYQl0uLHizM63Y+k4zE33j/XaOV5ZawT70yQXcX+xMG90otFV3HLcmJOkyOPIes8k0V
cwOe7gTiaz5jztHJQp1ix1V4DiPZu4vO/I3riOKwJ6DKBdnOuc78WifkzugjcsBkr1grLA
Lh1ky848d2KzpYnqkwx24Gt0hmidVbo=
Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com
[209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-85-ryRIh5XGN0GLSIKEjorx8w-1; Thu, 09 Mar 2023 16:10:16 -0500
X-MC-Unique: ryRIh5XGN0GLSIKEjorx8w-1
Received: by mail-pl1-f200.google.com with SMTP id
c3-20020a170902724300b0019d1ffec36dso1656987pll.9
for <dev@dpdk.org>; Thu, 09 Mar 2023 13:10:16 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112; t=1678396215;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=Bu1FCxZqb0wkqW4CTPh1bgj1dcpPXxODYgwqRU+7Nro=;
b=StXcpATSyVY2YPrBOVLAIy32WxA9kWxAAINvCKqLPk8/RX3MYZd6AqypfFEIw+QslQ
a5IsllMqepGkoR4wfpxdwzG7dF7jPtkN75kEYFv32T6GqVObX9D1lIIhDF4Uxg3AP6l6
ql+rY0RgrIGe1hklQmhbXe7dPbM5rB1snUYYY/YYjmzhQknF+SsqO6jm0hIjcr5sO0OW
zv0BcQysKpvGgy3ScZrYc30U+Gq/6wJSJ6+Dmz0Sl3rcdwjUhAsO3NVsAOTySjNsMuIO
NYV0twBxTlZtyhFxaByQBaSB5Vm5QgrM3g1W2UYu7Q+1omamAxrqnHtyXvWeylg9m5kx
jqaQ==
X-Gm-Message-State: AO0yUKWy/aomZSakKjLxhNCFdrPpkgDGire6J7jFFyzCHabzvzgTeNOA
QLIE4J2NuHuBCGwobesUqPWMqzW684GK22bh3/TOROpTTohaIcnSKWH9+orrZIDbM7wNstMUwSU
Os94ni/V74UMpxmmFMoc=
X-Received: by 2002:a05:6a00:225a:b0:593:c9dd:9069 with SMTP id
i26-20020a056a00225a00b00593c9dd9069mr10108361pfu.5.1678396215487;
Thu, 09 Mar 2023 13:10:15 -0800 (PST)
X-Google-Smtp-Source: AK7set9vFYkVH23XghGmGCIs0+EIrDH2eGQhaFWdqH3tYpzRLnDIwr4qiKj659BqCeHTeGCH0SVR2MgEjiKYf5vFUhk=
X-Received: by 2002:a05:6a00:225a:b0:593:c9dd:9069 with SMTP id
i26-20020a056a00225a00b00593c9dd9069mr10108354pfu.5.1678396215176; Thu, 09
Mar 2023 13:10:15 -0800 (PST)
MIME-Version: 1.0
References: <20230207001937.875608-1-stephen@networkplumber.org>
<20230219231416.22524-1-stephen@networkplumber.org>
<20230219231416.22524-3-stephen@networkplumber.org>
In-Reply-To: <20230219231416.22524-3-stephen@networkplumber.org>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 9 Mar 2023 22:10:03 +0100
Message-ID: <CAJFAV8znt1Vjrtxie49j2UJjNehuurmyPjbi2ZRy_Ti923CNqw@mail.gmail.com>
Subject: Re: [PATCH v4 2/9] net/ring: build on Windows
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>,
Bruce Richardson <bruce.richardson@intel.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Mon, Feb 20, 2023 at 12:14=E2=80=AFAM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The command line arguments are stored in node_action_pair
> and the name[] was sized to PATH_MAX which does not exist on Windows.
> Since the name is either "CREATE" or "ATTACH" it is not
> related to PATH_MAX (4096).
>
> With this fix driver builds ok on windows, but need to modify the
> test meson build to skip the eventdev test on Windows.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
> app/test/meson.build | 2 +-
> drivers/net/ring/meson.build | 6 ------
> drivers/net/ring/rte_eth_ring.c | 4 +++-
> 3 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/app/test/meson.build b/app/test/meson.build
> index f34d19e3c3cb..a713f0382280 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -390,7 +390,7 @@ if dpdk_conf.has('RTE_NET_BOND')
> driver_test_names +=3D 'link_bonding_mode4_autotest'
> endif
> endif
> -if dpdk_conf.has('RTE_NET_RING')
> +if dpdk_conf.has('RTE_LIB_EVENTDEV') and dpdk_conf.has('RTE_NET_RING')
> test_deps +=3D 'net_ring'
> test_sources +=3D 'test_pmd_ring_perf.c'
> test_sources +=3D 'test_pmd_ring.c'
> diff --git a/drivers/net/ring/meson.build b/drivers/net/ring/meson.build
> index 72792e26b05a..3534a3cc2287 100644
> --- a/drivers/net/ring/meson.build
> +++ b/drivers/net/ring/meson.build
> @@ -1,12 +1,6 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017 Intel Corporation
>
> -if is_windows
> - build =3D false
> - reason =3D 'not supported on Windows'
> - subdir_done()
> -endif
> -
> sources =3D files('rte_eth_ring.c')
> headers =3D files('rte_eth_ring.h')
> pmd_supports_disable_iova_as_pa =3D true
> diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_r=
ing.c
> index bd5a47dd9017..e8bc9b627102 100644
> --- a/drivers/net/ring/rte_eth_ring.c
> +++ b/drivers/net/ring/rte_eth_ring.c
> @@ -9,6 +9,7 @@
> #include <ethdev_driver.h>
> #include <rte_malloc.h>
> #include <rte_memcpy.h>
> +#include <rte_os_shim.h>
Is it still needed, since this patch drops use of PATH_MAX?
> #include <rte_string_fns.h>
> #include <bus_vdev_driver.h>
> #include <rte_kvargs.h>
> @@ -17,6 +18,7 @@
> #define ETH_RING_NUMA_NODE_ACTION_ARG "nodeaction"
> #define ETH_RING_ACTION_CREATE "CREATE"
> #define ETH_RING_ACTION_ATTACH "ATTACH"
> +#define ETH_RING_ACTION_MAX_LEN 8 /* CREATE | ACTION */
> #define ETH_RING_INTERNAL_ARG "internal"
> #define ETH_RING_INTERNAL_ARG_MAX_LEN 19 /* "0x..16chars..\0" */
>
> @@ -539,7 +541,7 @@ eth_dev_ring_create(const char *name,
> }
>
> struct node_action_pair {
> - char name[PATH_MAX];
> + char name[ETH_RING_ACTION_MAX_LEN];
> unsigned int node;
> enum dev_action action;
> };
> --
> 2.39.1
>
--=20
David Marchand