From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4AD943199; Wed, 18 Oct 2023 13:00:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8679402DD; Wed, 18 Oct 2023 13:00:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 20BC640297 for ; Wed, 18 Oct 2023 13:00:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697626821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UTXPaYUpaiWPbaIsroBAABxYU87PyL+wXTxatCMxmAk=; b=DwPHS6Noynemu6OMGfSLX7ADN6cnMBdjQDab9PQFv8lpvSvF9kP/u4Snk7I1r/uclyykur MOCGQ/6PFqfIMuPu8midE58HbUZ6RElcLOPU9HSIuL1MIHBKSglM5je3hlORIBsAWEnTkq NdJIdlCIni5q2r7/a4sHpJeXdFtPAHs= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-467-MI2NK_jvOKaVATFvsxKMKw-1; Wed, 18 Oct 2023 07:00:20 -0400 X-MC-Unique: MI2NK_jvOKaVATFvsxKMKw-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2c5194d4e98so35559141fa.3 for ; Wed, 18 Oct 2023 04:00:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697626819; x=1698231619; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UTXPaYUpaiWPbaIsroBAABxYU87PyL+wXTxatCMxmAk=; b=bYlKwVyIUeD5ErOEOJaH/yCNRme3aKp4fKor76SwsWQJdG8XNVVWDAIudRm2Z46c4P LM92W5Hs3VuFl4+S4/3TRdDyiSPWhouev4TtGCetTxAVBLhmNEIo1OMS7dFahkS3Idgc ON1UYyXSvHtFwoxF4yGDT1r+lg2Nv2G2+o5nboYhciwIj/H1XtgB0cYUab9BHCAGCR1y 91A+uSINXBqCjSQoRh2m6zfuznqCd3mshYGcXWO6IwTlReqvnFf7Y6Ee5iVihRMeh1DA 86pAWEKnlMaf9F2BoM0OvCZlqcJf9zA/McLQBMGABk11ujOtxP/9ShCYtMbcev4it4eP q1bw== X-Gm-Message-State: AOJu0YzflnHNE8PQyNtpNGE4JAsQclASg+JGef43WXrIvWeNuzdLd3vd CuGt9CBx7rodQaz6Lex9Mv4CocgcODjHyFPXAbW3AzIh/fInjpQZKnFfsFTu+6H5q71ANK5i010 h8Edi3zcseIl8BIPA8cY= X-Received: by 2002:a2e:be10:0:b0:2c5:11fe:53b2 with SMTP id z16-20020a2ebe10000000b002c511fe53b2mr4060895ljq.37.1697626818985; Wed, 18 Oct 2023 04:00:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQnpKrJ3wXelmjkuNcl9JQn4iT1iZ0Gnvt6XjX0Fy3fPBKt+/5/vp3RpwDaYed9O0rbh2ImKK9cPjzp6WCbuI= X-Received: by 2002:a2e:be10:0:b0:2c5:11fe:53b2 with SMTP id z16-20020a2ebe10000000b002c511fe53b2mr4060885ljq.37.1697626818699; Wed, 18 Oct 2023 04:00:18 -0700 (PDT) MIME-Version: 1.0 References: <20230530114202.850814-1-eagostini@nvidia.com> In-Reply-To: From: David Marchand Date: Wed, 18 Oct 2023 13:00:07 +0200 Message-ID: Subject: Re: [PATCH v1] bus/pci: get PCI address from rte_device To: Elena Agostini Cc: "dev@dpdk.org" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Bing Zhao X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 31, 2023 at 11:52=E2=80=AFAM David Marchand wrote: > > (I reformatted the mail a bit) > > On Wed, May 31, 2023 at 10:51=E2=80=AFAM Elena Agostini wrote: > > > On Wed, May 31, 2023 at 10:44=E2=80=AFAM Elena Agostini eagostini@nvi= dia.com wrote: > > > > > On Tue, May 30, 2023 at 1:48=E2=80=AFPM eagostini@nvidia.com wrot= e: > > > > > > From: Elena Agostini eagostini@nvidia.com > > > > > > In DPDK 22.11 pci bus related structure have been hidden intern= ally > > > > > > so the application doesn't have a direct access to those info a= nymore. > > > > > > This patch introduces a get function to retrieve a PCI address > > > > > > from an rte_device handler. > > > > > > Signed-off-by: Elena Agostini eagostini@nvidia.com > > > > > > I would prefer we don't add specific bus API when there is an alt= ernative. > > > > > The PCI address is already reported as a string in the generic de= vice > > > > > object name. > > > > > Would that be enough for your usecase? > > > > > No as I need to parse anyway the PCI address string in the form of = domain/bus/devid/function. > > > > I am curious. Can you explain why you would need such information? > > > Use-case is the Aerial 5G where two processes have to exchange info > > about PCI devices sending messages according to some specific format. > > It seems strange that different processes need to exchange this bus > level information. > For dataplane, having a simpler metadata (like a portid maybe?) is > better than a domain/bus/devid/function quartet. > For controlplane, having an abstraction or a human readable string is > probably better too. > > In any case, for what you request here, the application can parse the > generic device name into a rte_pci_addr via rte_pci_addr_parse(). > Is it not enough? No reply for some time now, marking this patch as rejected. --=20 David Marchand