From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 546FF2BBB for ; Mon, 6 May 2019 14:57:03 +0200 (CEST) Received: by mail-ua1-f67.google.com with SMTP id g16so4608803uad.2 for ; Mon, 06 May 2019 05:57:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hK3Dnk+n6iQp0bC5f0ZJE2p058c2C6wyHj/mzYo2Wrs=; b=PwKSSYHY0E1VQhPh5JmsyvHBJyCMCnkBq3ogDoRQJQ+pXI1f/wSKZSSFRTBnUg8bye urChNEbEw3dB5BmO9oS3TnE8PIzZvIEmLYn/33dX8GBFeAqpaVdOkty/6fP6gL+UGb92 Is/7O6OV/l9b76aYyZiVmxyPnOdthevbGfJvEJO1t4hNno6K5YBuXuUrgx7vdynNOc6/ UlPvQ3cKsGGmPnehD7jnIj8vuuwL/jerXUhKzqEc2bK/0/eu89500vNJ+Yxt84discvv 4+yPsUgL7kY/vziHySQEnvnNMZeSbUWCbLDwvd9FCaii8/2rm5732cRJxrPHJ9Ic5vgb +iAA== X-Gm-Message-State: APjAAAW1i4DG78IJDFc4X4+18o5dBl9tfnOczh4dNzzh/t4UXmyNjkyI PTd+aBC5WfVPQiz7fi2Viuwt8Qd0XUkxURetgKxTDw== X-Google-Smtp-Source: APXvYqxqJecuztGvgb7/+U0R+iNhBcOGKPYVfKJBH63gNthP5ZrXakGD980+SvxS3lTEuWyurPyuZs/Wfm3UtAEY5kE= X-Received: by 2002:a9f:2085:: with SMTP id 5mr1220647uaa.53.1557147422367; Mon, 06 May 2019 05:57:02 -0700 (PDT) MIME-Version: 1.0 References: <1556894060-13573-1-git-send-email-david.marchand@redhat.com> <1556894060-13573-2-git-send-email-david.marchand@redhat.com> <20190503150346.GA32640@hmswarspite.think-freely.org> In-Reply-To: From: David Marchand Date: Mon, 6 May 2019 14:56:51 +0200 Message-ID: To: Neil Horman Cc: dev , Thomas Monjalon , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 May 2019 12:57:03 -0000 On Fri, May 3, 2019 at 7:16 PM David Marchand wrote: > On Fri, May 3, 2019 at 5:18 PM Neil Horman wrote: > >> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote: >> > Even if rare, the check script should handle removing a section. >> > >> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") >> > Cc: stable@dpdk.org >> > >> > Signed-off-by: David Marchand >> > --- >> > devtools/check-symbol-change.sh | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/devtools/check-symbol-change.sh >> b/devtools/check-symbol-change.sh >> > index 8da7650..d5fad04 100755 >> > --- a/devtools/check-symbol-change.sh >> > +++ b/devtools/check-symbol-change.sh >> > @@ -32,6 +32,7 @@ build_map_changes() >> > # symbol rule below >> > /^.*{/ { >> > gsub("+", ""); >> > + gsub("-", ""); >> > if (in_map == 1) { >> > sec=$(NF-1); in_sec=1; >> > } >> > -- >> > 1.8.3.1 >> > >> > >> Don't you also need to add some logic in the symbol detection match rule >> to >> print an appropriate indicator that a symbol is being removed? With just >> this >> change, you will note that you are parsing a section, but you will never >> trigger >> a symbol match >> > > I do remember seeing a warning about the "-EXPERIMENTAL" section. > And this is why I added this. > But since then I reorganised my series and eliminated some parts... so you > are most likely right. > I will double check and repost. > > Yes, you are right, I moved this out of another patch that I ended up not sending. But it makes no sense by itself. I will drop this in v2. Any comments on the other patches ? Thanks Neil. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 08403A0096 for ; Mon, 6 May 2019 14:57:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D6B612BBB; Mon, 6 May 2019 14:57:04 +0200 (CEST) Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 546FF2BBB for ; Mon, 6 May 2019 14:57:03 +0200 (CEST) Received: by mail-ua1-f67.google.com with SMTP id g16so4608803uad.2 for ; Mon, 06 May 2019 05:57:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hK3Dnk+n6iQp0bC5f0ZJE2p058c2C6wyHj/mzYo2Wrs=; b=PwKSSYHY0E1VQhPh5JmsyvHBJyCMCnkBq3ogDoRQJQ+pXI1f/wSKZSSFRTBnUg8bye urChNEbEw3dB5BmO9oS3TnE8PIzZvIEmLYn/33dX8GBFeAqpaVdOkty/6fP6gL+UGb92 Is/7O6OV/l9b76aYyZiVmxyPnOdthevbGfJvEJO1t4hNno6K5YBuXuUrgx7vdynNOc6/ UlPvQ3cKsGGmPnehD7jnIj8vuuwL/jerXUhKzqEc2bK/0/eu89500vNJ+Yxt84discvv 4+yPsUgL7kY/vziHySQEnvnNMZeSbUWCbLDwvd9FCaii8/2rm5732cRJxrPHJ9Ic5vgb +iAA== X-Gm-Message-State: APjAAAW1i4DG78IJDFc4X4+18o5dBl9tfnOczh4dNzzh/t4UXmyNjkyI PTd+aBC5WfVPQiz7fi2Viuwt8Qd0XUkxURetgKxTDw== X-Google-Smtp-Source: APXvYqxqJecuztGvgb7/+U0R+iNhBcOGKPYVfKJBH63gNthP5ZrXakGD980+SvxS3lTEuWyurPyuZs/Wfm3UtAEY5kE= X-Received: by 2002:a9f:2085:: with SMTP id 5mr1220647uaa.53.1557147422367; Mon, 06 May 2019 05:57:02 -0700 (PDT) MIME-Version: 1.0 References: <1556894060-13573-1-git-send-email-david.marchand@redhat.com> <1556894060-13573-2-git-send-email-david.marchand@redhat.com> <20190503150346.GA32640@hmswarspite.think-freely.org> In-Reply-To: From: David Marchand Date: Mon, 6 May 2019 14:56:51 +0200 Message-ID: To: Neil Horman Cc: dev , Thomas Monjalon , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190506125651.J9cZPLPOoLjspcHlobTq8rr6ywGqpfwoDfPUhoEhBcQ@z> On Fri, May 3, 2019 at 7:16 PM David Marchand wrote: > On Fri, May 3, 2019 at 5:18 PM Neil Horman wrote: > >> On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote: >> > Even if rare, the check script should handle removing a section. >> > >> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") >> > Cc: stable@dpdk.org >> > >> > Signed-off-by: David Marchand >> > --- >> > devtools/check-symbol-change.sh | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/devtools/check-symbol-change.sh >> b/devtools/check-symbol-change.sh >> > index 8da7650..d5fad04 100755 >> > --- a/devtools/check-symbol-change.sh >> > +++ b/devtools/check-symbol-change.sh >> > @@ -32,6 +32,7 @@ build_map_changes() >> > # symbol rule below >> > /^.*{/ { >> > gsub("+", ""); >> > + gsub("-", ""); >> > if (in_map == 1) { >> > sec=$(NF-1); in_sec=1; >> > } >> > -- >> > 1.8.3.1 >> > >> > >> Don't you also need to add some logic in the symbol detection match rule >> to >> print an appropriate indicator that a symbol is being removed? With just >> this >> change, you will note that you are parsing a section, but you will never >> trigger >> a symbol match >> > > I do remember seeing a warning about the "-EXPERIMENTAL" section. > And this is why I added this. > But since then I reorganised my series and eliminated some parts... so you > are most likely right. > I will double check and repost. > > Yes, you are right, I moved this out of another patch that I ended up not sending. But it makes no sense by itself. I will drop this in v2. Any comments on the other patches ? Thanks Neil. -- David Marchand