From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDA0443C4D; Tue, 5 Mar 2024 10:04:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DEA640A70; Tue, 5 Mar 2024 10:04:40 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6E0034014F for ; Tue, 5 Mar 2024 10:04:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709629479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IgnH8P4I6A0mEFCmU4lBPJXovOkAdWQ8g8O6reX58js=; b=X1F2UUVn4GuyCosgkIxCxpM7QxiX9dwt/FZTW/99dVir9ISyjJUQ2VD1fre2Bf0syYlgdz i+uPwMQJu0ZeF38cw5vphy0KPmHTeewAOMUDht+/8losrxvx9rxixhiVUPqJI4jtyMllz6 eMNb3H6+63ETvR1BoH3XqAIsSEj1gcI= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-QeeMQEYkOWqFP3jkU9bpkA-1; Tue, 05 Mar 2024 04:04:37 -0500 X-MC-Unique: QeeMQEYkOWqFP3jkU9bpkA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d3dcb043afso15188321fa.2 for ; Tue, 05 Mar 2024 01:04:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709629476; x=1710234276; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IgnH8P4I6A0mEFCmU4lBPJXovOkAdWQ8g8O6reX58js=; b=tZKEOxvjaP7mE+cc9RCc6TxNskYx8knPtn3xkclMdJqzKkv4CoZK4GLfsMvGjL6AcQ rLQ/NS+vdqsH082XeT8Z5onaCXT2R94bYy9Tx40hU5jFH+h8s54teiBQSE0Xjv89+dvy fEl8odYQ3yF4Yw/BKK8MNHhYoXZJ/oAo+0O3rgd6aI1UUPysgjGIKoCccid4b1nk5ffv UhygEeVlHM2wQfpf3WlqD903TIc2bXHZH3nfm/wREBCpd2uj/IfJVw/y/w4OxRa8dow7 O95917CjkGQodjap8z7eUlUKIILz5jAUrKJ5br0dCjtZTCrBj9XtrXLX0CoqaMhfQ7Ar v8aA== X-Gm-Message-State: AOJu0Yznu/8oS5tuZ9vzHcdNJUvZHO+y5UXRt6M6YVW21688h1xK3IW2 TH3gJSt5VYD6Tuj8PtFAZ/3suMaBlCtybph7lten+kEV+cA9BWT+O+aXMwmOLbIn3eZYgintdNk 7VNrQki+IoTEla79Jr+eFOcBr5+P7n1N65HHDCy60q0FfXeHmPoi6jznuSFPlHVs6XecpWNnK/s qBVnF2sh1E62vIjVY= X-Received: by 2002:a05:6512:b8c:b0:513:2102:7afe with SMTP id b12-20020a0565120b8c00b0051321027afemr1029622lfv.7.1709629476230; Tue, 05 Mar 2024 01:04:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEax6/rvg0ljN4rwjeySaB/TyP/TmVaCQ5k++hLgo9/08YVBkugEGeJK9SuGZgpw4MB6ZniDjYIbxbNX/bhPm8= X-Received: by 2002:a05:6512:b8c:b0:513:2102:7afe with SMTP id b12-20020a0565120b8c00b0051321027afemr1029589lfv.7.1709629475821; Tue, 05 Mar 2024 01:04:35 -0800 (PST) MIME-Version: 1.0 References: <20231205094536.2816720-5-david.marchand@redhat.com> <20240227103903.1338151-1-david.marchand@redhat.com> In-Reply-To: <20240227103903.1338151-1-david.marchand@redhat.com> From: David Marchand Date: Tue, 5 Mar 2024 10:04:23 +0100 Message-ID: Subject: Re: [PATCH v4] vhost: enhance virtqueue access lock asserts To: David Marchand Cc: dev@dpdk.org, echaudro@redhat.com, Maxime Coquelin , Chenbo Xia X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 27, 2024 at 11:39=E2=80=AFAM David Marchand wrote: > > A simple comment in vhost_user_msg_handler() is not that robust. > > Add a lock_all_qps property to message handlers so that their > implementation can add a build check and assert a vq is locked. > > Signed-off-by: David Marchand > Reviewed-by: Maxime Coquelin > --- > Changes since v3: > - directly called static_assert() with improved message, > > Changes since v2: > - dropped review tags, > - following use of static_assert() in RTE_BUILD_BUG_ON, reworked build > check by using enums (one enum is now defined per message type), > - as the added enums must be defined early, moved the definitions of > handlers at the top of the file, > > Changes since v1: > - moved this patch as the last of the series, Applied, thanks. --=20 David Marchand