From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43506A0548; Thu, 1 Apr 2021 14:33:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B65C914115A; Thu, 1 Apr 2021 14:33:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 440B6141152 for ; Thu, 1 Apr 2021 14:33:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617280404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z54Xb/Owqrb6TyNEQkMPJXInlE8SRTSViSiPjKq8MaM=; b=VjmnQfoOjolclR9hpyPoo4fnLJbDW4hFInU+nrqXUXBtGqShR88XEDrYYZHBhbCwk5jQx3 LrzIoFewlCgapxpvHBej44EpWG+PbboeC2lGUdffHDu5tjhFQmQb/U7AA8klFw6Kz1EWnF GefrEly0/Ui2CEobYCSlxYvBVto8XAk= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-370-qVlVOTyIO66OjfQD1GGuug-1; Thu, 01 Apr 2021 08:33:21 -0400 X-MC-Unique: qVlVOTyIO66OjfQD1GGuug-1 Received: by mail-vk1-f197.google.com with SMTP id h75so1730847vka.9 for ; Thu, 01 Apr 2021 05:33:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z54Xb/Owqrb6TyNEQkMPJXInlE8SRTSViSiPjKq8MaM=; b=IovSvbRO9uIjETxxXGkTeNgTb5JjJ6k2xu4u4E3QcyZxF2aDg/yOKCTtW1rF1VSk68 24ClBBKnIM48mnH22fZedNztDyqK0BYYlvuvwmHz0viRjVlkqOQxffuAbWH8JFfxmlzR Vig/SHKlNqtTrnm/tAQX4ZgCV2aH74TWd5nUYVJM5XkWC3GYR0NMU0hzyPRNKHn/Ox94 WpwEqhTTGFGReuvUnd/q+e3SUj5hBYEv3z+uCo2zeaqbMVsoDmzuiH4sFsoNZdi4ySam eIgbqn8l+NcaDy6XUOnPupRdDD3JGCckQpp+AZo8O3t5qViEaF3tuYBMK0gNfgiKM3TT nfxw== X-Gm-Message-State: AOAM532yUdHCpTzbipLyHIUsD45+tR8Y6ROSz3H96k0aYBl3Ri/LG3ar mfD7fD9vaGdd1id7pHdTgggWLA87S767bjDaqv1rdbr3gN/M1UAp5H9sc1ky+s9/6cH/LnGSmyk mFYvFadVwHt5QuL0pIcc= X-Received: by 2002:a05:6102:a84:: with SMTP id n4mr4884169vsg.18.1617280400755; Thu, 01 Apr 2021 05:33:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJhnAoDx8L0Bx06TQ1vD9Jxr63i/iIIjv1fxIeEn3OrIpzZJfgkRDyFceKt+UD5YlRCsrNWEIhUNbuV1dKES4= X-Received: by 2002:a05:6102:a84:: with SMTP id n4mr4884154vsg.18.1617280400521; Thu, 01 Apr 2021 05:33:20 -0700 (PDT) MIME-Version: 1.0 References: <20210331085345.6290-1-leyi.rong@intel.com> In-Reply-To: <20210331085345.6290-1-leyi.rong@intel.com> From: David Marchand Date: Thu, 1 Apr 2021 14:33:09 +0200 Message-ID: To: Leyi Rong Cc: Qi Zhang , Beilei Xing , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/i40e: add Tx preparation for vector data path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 31, 2021 at 11:17 AM Leyi Rong wrote: > > Fill up dev->tx_pkt_prepare to i40e_pkt_prepare when on vector and simple > data path selection, as the sanity check is needed ideally. > > Signed-off-by: Leyi Rong > --- > drivers/net/i40e/i40e_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c > index 61cb204be2..b3d7765e3b 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -3412,7 +3412,7 @@ i40e_set_tx_function(struct rte_eth_dev *dev) > PMD_INIT_LOG(DEBUG, "Simple tx finally be used."); > dev->tx_pkt_burst = i40e_xmit_pkts_simple; > } > - dev->tx_pkt_prepare = NULL; > + dev->tx_pkt_prepare = i40e_prep_pkts; > } else { > PMD_INIT_LOG(DEBUG, "Xmit tx finally be used."); > dev->tx_pkt_burst = i40e_xmit_pkts; I find this a bit surprising to set this op at two different locations. Why not simply leave the value set in i40e_ethdev.c? -- David Marchand